From mboxrd@z Thu Jan  1 00:00:00 1970
From: Baruch Siach <baruch@tkos.co.il>
Date: Thu, 18 Jun 2020 22:25:17 +0300
Subject: [PATCH 4/4] mx6cuboxi: Convert to DM_ETH
In-Reply-To: <20200618190524.21272-4-festevam@gmail.com>
References: <20200618190524.21272-1-festevam@gmail.com>
 <20200618190524.21272-4-festevam@gmail.com>
Message-ID: <87lfkkkwgy.fsf@tarshish>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Fabio,

Thanks for your debug and fix. Small nits below.

On Thu, Jun 18 2020, Fabio Estevam wrote:
> Migration to DM_ETH is mandatory, so convert mx6cuboxi to Ethernet
> Driver Model.
>
> This also brings the benefit of restoring Ethernet functionality.
>
> Reported-by: Tom Rini <trini@konsulko.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  board/solidrun/mx6cuboxi/mx6cuboxi.c | 123 ++++-----------------------
>  configs/mx6cuboxi_defconfig          |   4 +
>  include/configs/mx6cuboxi.h          |   6 --
>  3 files changed, 21 insertions(+), 112 deletions(-)
>
> diff --git a/board/solidrun/mx6cuboxi/mx6cuboxi.c b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> index 94707bccb2..225fea2cb2 100644
> --- a/board/solidrun/mx6cuboxi/mx6cuboxi.c
> +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c
> @@ -17,7 +17,6 @@
>  #include <image.h>
>  #include <init.h>
>  #include <log.h>
> -#include <net.h>
>  #include <asm/arch/clock.h>
>  #include <asm/arch/imx-regs.h>
>  #include <asm/arch/iomux.h>
> @@ -34,7 +33,6 @@
>  #include <fsl_esdhc_imx.h>
>  #include <malloc.h>
>  #include <miiphy.h>

Do we still need this header?

> -#include <netdev.h>
>  #include <asm/arch/crm_regs.h>
>  #include <asm/io.h>
>  #include <asm/arch/sys_proto.h>
> @@ -237,110 +235,6 @@ int board_mmc_init(bd_t *bis)
>  	return 0;
>  }
>  
> -static iomux_v3_cfg_t const enet_pads[] = {
> -	IOMUX_PADS(PAD_ENET_MDIO__ENET_MDIO | MUX_PAD_CTRL(ENET_PAD_CTRL)),

The definitions of these ENET_PAD_CTRL* macros can go away as well.

baruch

> -	IOMUX_PADS(PAD_ENET_MDC__ENET_MDC | MUX_PAD_CTRL(ENET_PAD_CTRL)),
> -	/* AR8035 reset */
> -	IOMUX_PADS(PAD_KEY_ROW4__GPIO4_IO15 | MUX_PAD_CTRL(ENET_PAD_CTRL_PD)),
> -	/* AR8035 interrupt */
> -	IOMUX_PADS(PAD_DI0_PIN2__GPIO4_IO18 | MUX_PAD_CTRL(NO_PAD_CTRL)),
...

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -