* [U-Boot] [PATCH] configs: mcbin: enable network driver
@ 2018-11-22 11:42 Baruch Siach
2018-11-29 13:12 ` Stefan Roese
2018-11-30 14:39 ` Stefan Roese
0 siblings, 2 replies; 6+ messages in thread
From: Baruch Siach @ 2018-11-22 11:42 UTC (permalink / raw)
To: u-boot
Enable the mvpp2 Ethernet driver and the Marvell Ethernet PHY driver.
This makes the Macchiatobin 1Gb Ethernet interface usable.
Cc: Konstantin Porotchkin <kostap@marvell.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
configs/mvebu_mcbin-88f8040_defconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configs/mvebu_mcbin-88f8040_defconfig b/configs/mvebu_mcbin-88f8040_defconfig
index 44436bc2a941..9df4c51c6f18 100644
--- a/configs/mvebu_mcbin-88f8040_defconfig
+++ b/configs/mvebu_mcbin-88f8040_defconfig
@@ -5,7 +5,6 @@ CONFIG_SYS_MALLOC_F_LEN=0x2000
CONFIG_TARGET_MVEBU_ARMADA_8K=y
CONFIG_DEBUG_UART_BASE=0xf0512000
CONFIG_DEBUG_UART_CLOCK=200000000
-CONFIG_SMBIOS_PRODUCT_NAME=""
CONFIG_DEBUG_UART=y
CONFIG_AHCI=y
CONFIG_DISTRO_DEFAULTS=y
@@ -35,6 +34,7 @@ CONFIG_CMD_EXT4_WRITE=y
CONFIG_MAC_PARTITION=y
CONFIG_DEFAULT_DEVICE_TREE="armada-8040-mcbin"
CONFIG_ENV_IS_IN_SPI_FLASH=y
+CONFIG_NET_RANDOM_ETHADDR=y
CONFIG_AHCI_MVEBU=y
CONFIG_DM_GPIO=y
CONFIG_DM_I2C=y
@@ -48,8 +48,9 @@ CONFIG_SPI_FLASH_MACRONIX=y
CONFIG_SPI_FLASH_SPANSION=y
CONFIG_SPI_FLASH_STMICRO=y
CONFIG_SPI_FLASH_WINBOND=y
-CONFIG_PHYLIB=y
+CONFIG_PHY_MARVELL=y
CONFIG_PHY_GIGE=y
+CONFIG_MVPP2=y
CONFIG_PCI=y
CONFIG_DM_PCI=y
CONFIG_PCIE_DW_MVEBU=y
@@ -72,4 +73,3 @@ CONFIG_USB_ETHER_ASIX=y
CONFIG_USB_ETHER_MCS7830=y
CONFIG_USB_ETHER_RTL8152=y
CONFIG_USB_ETHER_SMSC95XX=y
-CONFIG_SMBIOS_MANUFACTURER=""
--
2.19.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] configs: mcbin: enable network driver
2018-11-22 11:42 [U-Boot] [PATCH] configs: mcbin: enable network driver Baruch Siach
@ 2018-11-29 13:12 ` Stefan Roese
2018-11-29 13:14 ` Stefan Roese
2018-11-30 14:39 ` Stefan Roese
1 sibling, 1 reply; 6+ messages in thread
From: Stefan Roese @ 2018-11-29 13:12 UTC (permalink / raw)
To: u-boot
On 22.11.18 12:42, Baruch Siach wrote:
> Enable the mvpp2 Ethernet driver and the Marvell Ethernet PHY driver.
> This makes the Macchiatobin 1Gb Ethernet interface usable.
>
> Cc: Konstantin Porotchkin <kostap@marvell.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> configs/mvebu_mcbin-88f8040_defconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configs/mvebu_mcbin-88f8040_defconfig b/configs/mvebu_mcbin-88f8040_defconfig
> index 44436bc2a941..9df4c51c6f18 100644
> --- a/configs/mvebu_mcbin-88f8040_defconfig
> +++ b/configs/mvebu_mcbin-88f8040_defconfig
> @@ -5,7 +5,6 @@ CONFIG_SYS_MALLOC_F_LEN=0x2000
> CONFIG_TARGET_MVEBU_ARMADA_8K=y
> CONFIG_DEBUG_UART_BASE=0xf0512000
> CONFIG_DEBUG_UART_CLOCK=200000000
> -CONFIG_SMBIOS_PRODUCT_NAME=""
> CONFIG_DEBUG_UART=y
> CONFIG_AHCI=y
> CONFIG_DISTRO_DEFAULTS=y
> @@ -35,6 +34,7 @@ CONFIG_CMD_EXT4_WRITE=y
> CONFIG_MAC_PARTITION=y
> CONFIG_DEFAULT_DEVICE_TREE="armada-8040-mcbin"
> CONFIG_ENV_IS_IN_SPI_FLASH=y
> +CONFIG_NET_RANDOM_ETHADDR=y
> CONFIG_AHCI_MVEBU=y
> CONFIG_DM_GPIO=y
> CONFIG_DM_I2C=y
> @@ -48,8 +48,9 @@ CONFIG_SPI_FLASH_MACRONIX=y
> CONFIG_SPI_FLASH_SPANSION=y
> CONFIG_SPI_FLASH_STMICRO=y
> CONFIG_SPI_FLASH_WINBOND=y
> -CONFIG_PHYLIB=y
> +CONFIG_PHY_MARVELL=y
> CONFIG_PHY_GIGE=y
> +CONFIG_MVPP2=y
> CONFIG_PCI=y
> CONFIG_DM_PCI=y
> CONFIG_PCIE_DW_MVEBU=y
> @@ -72,4 +73,3 @@ CONFIG_USB_ETHER_ASIX=y
> CONFIG_USB_ETHER_MCS7830=y
> CONFIG_USB_ETHER_RTL8152=y
> CONFIG_USB_ETHER_SMSC95XX=y
> -CONFIG_SMBIOS_MANUFACTURER=""
>
Viele Grüße,
Stefan
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] configs: mcbin: enable network driver
2018-11-29 13:12 ` Stefan Roese
@ 2018-11-29 13:14 ` Stefan Roese
2018-11-29 17:11 ` Baruch Siach
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Roese @ 2018-11-29 13:14 UTC (permalink / raw)
To: u-boot
On 29.11.18 14:12, Stefan Roese wrote:
> On 22.11.18 12:42, Baruch Siach wrote:
>> Enable the mvpp2 Ethernet driver and the Marvell Ethernet PHY driver.
>> This makes the Macchiatobin 1Gb Ethernet interface usable.
>>
>> Cc: Konstantin Porotchkin <kostap@marvell.com>
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>
> Reviewed-by: Stefan Roese <sr@denx.de>
BTW: Could you please change your patch subject for all those patches
to reflect the architecture. Something like this:
configs: mcbin: enable network driver
->
arm: mvebu: configs: mcbin: enable network driver
Thanks,
Stefan
> Thanks,
> Stefan
>
>> ---
>> configs/mvebu_mcbin-88f8040_defconfig | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/configs/mvebu_mcbin-88f8040_defconfig b/configs/mvebu_mcbin-88f8040_defconfig
>> index 44436bc2a941..9df4c51c6f18 100644
>> --- a/configs/mvebu_mcbin-88f8040_defconfig
>> +++ b/configs/mvebu_mcbin-88f8040_defconfig
>> @@ -5,7 +5,6 @@ CONFIG_SYS_MALLOC_F_LEN=0x2000
>> CONFIG_TARGET_MVEBU_ARMADA_8K=y
>> CONFIG_DEBUG_UART_BASE=0xf0512000
>> CONFIG_DEBUG_UART_CLOCK=200000000
>> -CONFIG_SMBIOS_PRODUCT_NAME=""
>> CONFIG_DEBUG_UART=y
>> CONFIG_AHCI=y
>> CONFIG_DISTRO_DEFAULTS=y
>> @@ -35,6 +34,7 @@ CONFIG_CMD_EXT4_WRITE=y
>> CONFIG_MAC_PARTITION=y
>> CONFIG_DEFAULT_DEVICE_TREE="armada-8040-mcbin"
>> CONFIG_ENV_IS_IN_SPI_FLASH=y
>> +CONFIG_NET_RANDOM_ETHADDR=y
>> CONFIG_AHCI_MVEBU=y
>> CONFIG_DM_GPIO=y
>> CONFIG_DM_I2C=y
>> @@ -48,8 +48,9 @@ CONFIG_SPI_FLASH_MACRONIX=y
>> CONFIG_SPI_FLASH_SPANSION=y
>> CONFIG_SPI_FLASH_STMICRO=y
>> CONFIG_SPI_FLASH_WINBOND=y
>> -CONFIG_PHYLIB=y
>> +CONFIG_PHY_MARVELL=y
>> CONFIG_PHY_GIGE=y
>> +CONFIG_MVPP2=y
>> CONFIG_PCI=y
>> CONFIG_DM_PCI=y
>> CONFIG_PCIE_DW_MVEBU=y
>> @@ -72,4 +73,3 @@ CONFIG_USB_ETHER_ASIX=y
>> CONFIG_USB_ETHER_MCS7830=y
>> CONFIG_USB_ETHER_RTL8152=y
>> CONFIG_USB_ETHER_SMSC95XX=y
>> -CONFIG_SMBIOS_MANUFACTURER=""
>>
>
> Viele Grüße,
> Stefan
>
Viele Grüße,
Stefan
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] configs: mcbin: enable network driver
2018-11-29 13:14 ` Stefan Roese
@ 2018-11-29 17:11 ` Baruch Siach
2018-11-30 5:50 ` Stefan Roese
0 siblings, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2018-11-29 17:11 UTC (permalink / raw)
To: u-boot
Hi Stefan,
Stefan Roese writes:
> On 29.11.18 14:12, Stefan Roese wrote:
>> On 22.11.18 12:42, Baruch Siach wrote:
>>> Enable the mvpp2 Ethernet driver and the Marvell Ethernet PHY driver.
>>> This makes the Macchiatobin 1Gb Ethernet interface usable.
>>>
>>> Cc: Konstantin Porotchkin <kostap@marvell.com>
>>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>>
>> Reviewed-by: Stefan Roese <sr@denx.de>
>
> BTW: Could you please change your patch subject for all those patches
> to reflect the architecture. Something like this:
>
> configs: mcbin: enable network driver
> ->
> arm: mvebu: configs: mcbin: enable network driver
No problem. Should I resend this patch with that change?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] configs: mcbin: enable network driver
2018-11-29 17:11 ` Baruch Siach
@ 2018-11-30 5:50 ` Stefan Roese
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Roese @ 2018-11-30 5:50 UTC (permalink / raw)
To: u-boot
Hi Baruch,
On 29.11.18 18:11, Baruch Siach wrote:
> Hi Stefan,
>
> Stefan Roese writes:
>> On 29.11.18 14:12, Stefan Roese wrote:
>>> On 22.11.18 12:42, Baruch Siach wrote:
>>>> Enable the mvpp2 Ethernet driver and the Marvell Ethernet PHY driver.
>>>> This makes the Macchiatobin 1Gb Ethernet interface usable.
>>>>
>>>> Cc: Konstantin Porotchkin <kostap@marvell.com>
>>>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>>>
>>> Reviewed-by: Stefan Roese <sr@denx.de>
>>
>> BTW: Could you please change your patch subject for all those patches
>> to reflect the architecture. Something like this:
>>
>> configs: mcbin: enable network driver
>> ->
>> arm: mvebu: configs: mcbin: enable network driver
>
> No problem. Should I resend this patch with that change?
No, that's not necessary. But please do so for future patches.
Thanks,
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] configs: mcbin: enable network driver
2018-11-22 11:42 [U-Boot] [PATCH] configs: mcbin: enable network driver Baruch Siach
2018-11-29 13:12 ` Stefan Roese
@ 2018-11-30 14:39 ` Stefan Roese
1 sibling, 0 replies; 6+ messages in thread
From: Stefan Roese @ 2018-11-30 14:39 UTC (permalink / raw)
To: u-boot
On 22.11.18 12:42, Baruch Siach wrote:
> Enable the mvpp2 Ethernet driver and the Marvell Ethernet PHY driver.
> This makes the Macchiatobin 1Gb Ethernet interface usable.
>
> Cc: Konstantin Porotchkin <kostap@marvell.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Applied to u-boot-marvell/master.
Thanks,
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-30 14:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-22 11:42 [U-Boot] [PATCH] configs: mcbin: enable network driver Baruch Siach
2018-11-29 13:12 ` Stefan Roese
2018-11-29 13:14 ` Stefan Roese
2018-11-29 17:11 ` Baruch Siach
2018-11-30 5:50 ` Stefan Roese
2018-11-30 14:39 ` Stefan Roese
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox