public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Bill Pringlemeir <bpringlemeir@nbsps.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: vf610: fix boot from SD-card
Date: Thu, 08 Jan 2015 12:32:29 -0500	[thread overview]
Message-ID: <87lhld5gb6.fsf@nbsps.com> (raw)
In-Reply-To: <1420737505-32119-1-git-send-email-stefan@agner.ch> (Stefan Agner's message of "Thu, 8 Jan 2015 18:18:25 +0100")

On  8 Jan 2015, stefan at agner.ch wrote:

> Boot from SD-card (and probably also from NAND) was broken since
> commit d6d07a9bec ("arm: vf610: add NAND support for vf610twr").
> It looks like the increased size of U-Boot lead to a situation
> where the boot ROM overwrote its own stack/heap while loading
> U-Boot from the SD-card to the SRAM. However, U-Boot worked fine
> when loaded through USB serial loader directly into SRAM. It
> looks like loading from SD-card uses other stack/heap location
> then the serial loader (or maybe no stack or heap at all).
> This fix moves U-Boot to gfxRAM, which is 512kB in size and is not
> used by the boot ROM nor the SD-card loader of it.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> We use U-Boot from gfxRAM on Vybrid since quite a while for the
> Colibri VF50/VF61 modules in our downstream U-Boot branch. Hence
> this is quite well tested.
>
> Just today I discovered that this is broken on the Tower module.
> Back then, when I made the offending change, I only tested on the
> Tower board using the serial loader, since I thought the behaviour
> should be exactly the same. But now, I know better... :-)
>
> If still possible, it would be great to get this into v2015.01...
>
> include/configs/vf610twr.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/configs/vf610twr.h b/include/configs/vf610twr.h
> index 6fd0b17..bd79e81 100644
> --- a/include/configs/vf610twr.h
> +++ b/include/configs/vf610twr.h
> @@ -125,7 +125,10 @@
> #define CONFIG_BOOTDELAY		3
>
> #define CONFIG_LOADADDR			0x82000000
> -#define CONFIG_SYS_TEXT_BASE		0x3f008000
> +
> +/* We boot from the gfxRAM area of the OCRAM. */
> +#define CONFIG_SYS_TEXT_BASE		0x3f408000
> +#define CONFIG_BOARD_SIZE_LIMIT		524288
>
> #define CONFIG_EXTRA_ENV_SETTINGS \
> 	"script=boot.scr\0" \

Acked-by: Bill Pringlemeir <bpringlemeir@nbsps.com>

See also:
 http://lists.denx.de/pipermail/u-boot/2014-December/197641.html

It seems since v2014.04 u-boot on the Vybrid Tower SD card has not
booted.  Most users will probably boot this way.

 https://community.freescale.com/docs/DOC-95248

Thanks,
Bill Pringlemeir.

  reply	other threads:[~2015-01-08 17:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08 17:18 [U-Boot] [PATCH] arm: vf610: fix boot from SD-card Stefan Agner
2015-01-08 17:32 ` Bill Pringlemeir [this message]
2015-01-09 14:13   ` Stefan Agner
2015-01-09 14:29     ` Otavio Salvador
2015-01-09 14:51     ` Stefano Babic
2015-01-08 18:29 ` Bill Pringlemeir
2015-01-09 15:28 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lhld5gb6.fsf@nbsps.com \
    --to=bpringlemeir@nbsps.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox