From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Marek Vasut <marek.vasut+renesas@mailbox.org>, u-boot@lists.denx.de
Cc: Marek Vasut <marek.vasut+renesas@mailbox.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Jerome Forissier <jerome.forissier@arm.com>,
Mattijs Korpershoek <mkorpershoek@kernel.org>,
Peng Fan <peng.fan@nxp.com>, Tom Rini <trini@konsulko.com>,
Yao Zi <me@ziyao.cc>
Subject: Re: [PATCH] cmd: mmc: Drop trailing space in Name: before newline
Date: Tue, 17 Feb 2026 10:50:21 +0100 [thread overview]
Message-ID: <87ms17k8bm.fsf@kernel.org> (raw)
In-Reply-To: <20260208145142.10341-1-marek.vasut+renesas@mailbox.org>
Hi Marek,
Thank you for the patch.
On Sun, Feb 08, 2026 at 15:51, Marek Vasut <marek.vasut+renesas@mailbox.org> wrote:
> The Name: line of 'mmc info' command prints a trailing space before
> newline. This is not useful and shows up as trailing space e.g. when
> the output is checked into documentation. Remove the trailing space.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
> ---
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Jerome Forissier <jerome.forissier@arm.com> <jerome@forissier.org>
> Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Yao Zi <me@ziyao.cc>
> Cc: u-boot@lists.denx.de
> ---
> cmd/mmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cmd/mmc.c b/cmd/mmc.c
> index 6cb1ef5dc23..81b1ca4ad84 100644
> --- a/cmd/mmc.c
> +++ b/cmd/mmc.c
> @@ -29,12 +29,12 @@ static void print_mmcinfo(struct mmc *mmc)
> printf("Manufacturer ID: %x\n", mmc->cid[0] >> 24);
> if (IS_SD(mmc)) {
> printf("OEM: %x\n", (mmc->cid[0] >> 8) & 0xffff);
> - printf("Name: %c%c%c%c%c \n", mmc->cid[0] & 0xff,
> + printf("Name: %c%c%c%c%c\n", mmc->cid[0] & 0xff,
> (mmc->cid[1] >> 24), (mmc->cid[1] >> 16) & 0xff,
> (mmc->cid[1] >> 8) & 0xff, mmc->cid[1] & 0xff);
> } else {
> printf("OEM: %x\n", (mmc->cid[0] >> 8) & 0xff);
> - printf("Name: %c%c%c%c%c%c \n", mmc->cid[0] & 0xff,
> + printf("Name: %c%c%c%c%c%c\n", mmc->cid[0] & 0xff,
> (mmc->cid[1] >> 24), (mmc->cid[1] >> 16) & 0xff,
> (mmc->cid[1] >> 8) & 0xff, mmc->cid[1] & 0xff,
> (mmc->cid[2] >> 24));
> --
> 2.51.0
next prev parent reply other threads:[~2026-02-17 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 14:51 [PATCH] cmd: mmc: Drop trailing space in Name: before newline Marek Vasut
2026-02-08 15:03 ` Tom Rini
2026-02-17 9:50 ` Mattijs Korpershoek [this message]
2026-02-26 4:25 ` Peng Fan (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ms17k8bm.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=jerome.forissier@arm.com \
--cc=jh80.chung@samsung.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=me@ziyao.cc \
--cc=peng.fan@nxp.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox