* [PATCH] cmd: mmc: Drop trailing space in Name: before newline
@ 2026-02-08 14:51 Marek Vasut
2026-02-08 15:03 ` Tom Rini
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marek Vasut @ 2026-02-08 14:51 UTC (permalink / raw)
To: u-boot
Cc: Marek Vasut, Jaehoon Chung, Jerome Forissier, Mattijs Korpershoek,
Peng Fan, Tom Rini, Yao Zi
The Name: line of 'mmc info' command prints a trailing space before
newline. This is not useful and shows up as trailing space e.g. when
the output is checked into documentation. Remove the trailing space.
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Jerome Forissier <jerome.forissier@arm.com> <jerome@forissier.org>
Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Tom Rini <trini@konsulko.com>
Cc: Yao Zi <me@ziyao.cc>
Cc: u-boot@lists.denx.de
---
cmd/mmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/cmd/mmc.c b/cmd/mmc.c
index 6cb1ef5dc23..81b1ca4ad84 100644
--- a/cmd/mmc.c
+++ b/cmd/mmc.c
@@ -29,12 +29,12 @@ static void print_mmcinfo(struct mmc *mmc)
printf("Manufacturer ID: %x\n", mmc->cid[0] >> 24);
if (IS_SD(mmc)) {
printf("OEM: %x\n", (mmc->cid[0] >> 8) & 0xffff);
- printf("Name: %c%c%c%c%c \n", mmc->cid[0] & 0xff,
+ printf("Name: %c%c%c%c%c\n", mmc->cid[0] & 0xff,
(mmc->cid[1] >> 24), (mmc->cid[1] >> 16) & 0xff,
(mmc->cid[1] >> 8) & 0xff, mmc->cid[1] & 0xff);
} else {
printf("OEM: %x\n", (mmc->cid[0] >> 8) & 0xff);
- printf("Name: %c%c%c%c%c%c \n", mmc->cid[0] & 0xff,
+ printf("Name: %c%c%c%c%c%c\n", mmc->cid[0] & 0xff,
(mmc->cid[1] >> 24), (mmc->cid[1] >> 16) & 0xff,
(mmc->cid[1] >> 8) & 0xff, mmc->cid[1] & 0xff,
(mmc->cid[2] >> 24));
--
2.51.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cmd: mmc: Drop trailing space in Name: before newline
2026-02-08 14:51 [PATCH] cmd: mmc: Drop trailing space in Name: before newline Marek Vasut
@ 2026-02-08 15:03 ` Tom Rini
2026-02-17 9:50 ` Mattijs Korpershoek
2026-02-26 4:25 ` Peng Fan (OSS)
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2026-02-08 15:03 UTC (permalink / raw)
To: Marek Vasut
Cc: u-boot, Jaehoon Chung, Jerome Forissier, Mattijs Korpershoek,
Peng Fan, Yao Zi
[-- Attachment #1: Type: text/plain, Size: 405 bytes --]
On Sun, Feb 08, 2026 at 03:51:03PM +0100, Marek Vasut wrote:
> The Name: line of 'mmc info' command prints a trailing space before
> newline. This is not useful and shows up as trailing space e.g. when
> the output is checked into documentation. Remove the trailing space.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cmd: mmc: Drop trailing space in Name: before newline
2026-02-08 14:51 [PATCH] cmd: mmc: Drop trailing space in Name: before newline Marek Vasut
2026-02-08 15:03 ` Tom Rini
@ 2026-02-17 9:50 ` Mattijs Korpershoek
2026-02-26 4:25 ` Peng Fan (OSS)
2 siblings, 0 replies; 4+ messages in thread
From: Mattijs Korpershoek @ 2026-02-17 9:50 UTC (permalink / raw)
To: Marek Vasut, u-boot
Cc: Marek Vasut, Jaehoon Chung, Jerome Forissier, Mattijs Korpershoek,
Peng Fan, Tom Rini, Yao Zi
Hi Marek,
Thank you for the patch.
On Sun, Feb 08, 2026 at 15:51, Marek Vasut <marek.vasut+renesas@mailbox.org> wrote:
> The Name: line of 'mmc info' command prints a trailing space before
> newline. This is not useful and shows up as trailing space e.g. when
> the output is checked into documentation. Remove the trailing space.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
> ---
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Cc: Jerome Forissier <jerome.forissier@arm.com> <jerome@forissier.org>
> Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Yao Zi <me@ziyao.cc>
> Cc: u-boot@lists.denx.de
> ---
> cmd/mmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cmd/mmc.c b/cmd/mmc.c
> index 6cb1ef5dc23..81b1ca4ad84 100644
> --- a/cmd/mmc.c
> +++ b/cmd/mmc.c
> @@ -29,12 +29,12 @@ static void print_mmcinfo(struct mmc *mmc)
> printf("Manufacturer ID: %x\n", mmc->cid[0] >> 24);
> if (IS_SD(mmc)) {
> printf("OEM: %x\n", (mmc->cid[0] >> 8) & 0xffff);
> - printf("Name: %c%c%c%c%c \n", mmc->cid[0] & 0xff,
> + printf("Name: %c%c%c%c%c\n", mmc->cid[0] & 0xff,
> (mmc->cid[1] >> 24), (mmc->cid[1] >> 16) & 0xff,
> (mmc->cid[1] >> 8) & 0xff, mmc->cid[1] & 0xff);
> } else {
> printf("OEM: %x\n", (mmc->cid[0] >> 8) & 0xff);
> - printf("Name: %c%c%c%c%c%c \n", mmc->cid[0] & 0xff,
> + printf("Name: %c%c%c%c%c%c\n", mmc->cid[0] & 0xff,
> (mmc->cid[1] >> 24), (mmc->cid[1] >> 16) & 0xff,
> (mmc->cid[1] >> 8) & 0xff, mmc->cid[1] & 0xff,
> (mmc->cid[2] >> 24));
> --
> 2.51.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cmd: mmc: Drop trailing space in Name: before newline
2026-02-08 14:51 [PATCH] cmd: mmc: Drop trailing space in Name: before newline Marek Vasut
2026-02-08 15:03 ` Tom Rini
2026-02-17 9:50 ` Mattijs Korpershoek
@ 2026-02-26 4:25 ` Peng Fan (OSS)
2 siblings, 0 replies; 4+ messages in thread
From: Peng Fan (OSS) @ 2026-02-26 4:25 UTC (permalink / raw)
To: u-boot, Marek Vasut
Cc: Peng Fan, Jaehoon Chung, Jerome Forissier, Mattijs Korpershoek,
Tom Rini, Yao Zi
From: Peng Fan <peng.fan@nxp.com>
On Sun, 08 Feb 2026 15:51:03 +0100, Marek Vasut wrote:
> The Name: line of 'mmc info' command prints a trailing space before
> newline. This is not useful and shows up as trailing space e.g. when
> the output is checked into documentation. Remove the trailing space.
>
>
Applied to mmc-next-2026-02-26, thanks!
[1/1] cmd: mmc: Drop trailing space in Name: before newline
commit: 6f7d976317c59aad1af0b8bb169adca9b5802ca0
Best regards,
--
Peng Fan <peng.fan@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-26 3:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-08 14:51 [PATCH] cmd: mmc: Drop trailing space in Name: before newline Marek Vasut
2026-02-08 15:03 ` Tom Rini
2026-02-17 9:50 ` Mattijs Korpershoek
2026-02-26 4:25 ` Peng Fan (OSS)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox