Re: [PATCH 0/2] libavb: update to AOSP 1.3.0

[Mattijs Korpershoek <mkorpershoek@kernel.org>]

Hi Igor,

On Mon, Jul 27, 2026 at 11:31, Igor Opaniuk <igor.opaniuk@gmail.com> wrote:

> Hi Mattijs,
>
> On Mon, Jul 27, 2026 at 9:38 AM Mattijs Korpershoek
> <mkorpershoek@kernel.org> wrote:
>>
>> Hi Igor,
>>
>> On Fri, Jul 24, 2026 at 15:14, Mattijs Korpershoek <mkorpershoek@kernel.org> wrote:
>>
>> > Hi,
>> >
>> > On Sun, 12 Jul 2026 16:07:09 +0200, Igor Opaniuk wrote:
>> >> The vendored libavb under lib/libavb/ has been frozen at a ~2019 AOSP
>> >> snapshot (AVB version 1.1.0) for about six years. A v1.1.0 library
>> >> rejects any vbmeta whose required libavb minor version is greater than 1
>> >> with UNSUPPORTED_VERSION, so an image signed by a newer avbtool that uses
>> >> a 1.2/1.3 feature fails to verify. This series re-syncs the library to
>> >> version 1.3.0 and picks up the accumulated upstream fixes.
>> >>
>> >> [...]
>> >
>> > Thanks, Applied to https://git.u-boot-project.org/u-boot/custodians/u-boot-dfu (u-boot-dfu)
>> >
>> > [1/2] libavb: update to AOSP 1.3.0
>> >       https://git.u-boot-project.org/u-boot/custodians/u-boot-dfu/-/commit/963ec1af8a4b6d5d185ad289dbb0178ef2199d5f
>> > [2/2] doc: android: refresh AVB provenance and pin libavb reference
>> >       https://git.u-boot-project.org/u-boot/custodians/u-boot-dfu/-/commit/f8aba1d9c54c19a7c863bd5b4d035aa46a10bab0
>>
>> This seems to break sandbox build/test. See:
>> https://git.u-boot-project.org/u-boot/custodians/u-boot-dfu/-/jobs/48391
>>
>> Some relevant part of the logs:
>> $ tools/buildman/buildman -o ${UBOOT_TRAVIS_BUILD_DIR} -w -E -W -e --board ${TEST_PY_BD} ${OVERRIDE}
>> Building current source for 1 boards (1 thread, 112 jobs per thread)
>>    sandbox:  +   sandbox
>> +lib/libavb/avb_cmdline.c:371:48: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
>> +  371 | AvbCmdlineSubstList* avb_new_cmdline_subst_list() {
>> +      |                                                ^
>> +      |                                                 void
>> +1 error generated.
>> +make[3]: *** [scripts/Makefile.build:272: lib/libavb/avb_cmdline.o] Error 1
>> +make[2]: *** [scripts/Makefile.build:497: lib/libavb] Error 2
>> +make[1]: *** [Makefile:2210: lib] Error 2
>> +make: *** [Makefile:189: __sub-make] Error 2
>>     0    0    1 /1              sandbox
>>
>> Could you please send me a fix for this?
>> If not, I'll have to drop the patches from my tree in a couple of days.
> I've sent v2. Thanks for reporting the issue.

Thank you for the quick update and fix. I really appreciate it.
I've dropped v1 from u-boot-dfu and applied v2 instead.

>
>>
>> Thanks
>> Mattijs
>
>
>
> -- 
> Best regards - Atentamente - Meilleures salutations
>
> Igor Opaniuk
>
> mailto: igor.opaniuk@gmail.com
> skype: igor.opanyuk
> https://www.linkedin.com/in/iopaniuk