* [PATCH] boot: specify SPL_FIT_FULL_CHECK applies to SPL
@ 2025-10-29 11:08 Quentin Schulz
2025-10-31 15:14 ` Mattijs Korpershoek
2025-11-07 14:17 ` Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Quentin Schulz @ 2025-10-29 11:08 UTC (permalink / raw)
To: Simon Glass, u-boot
Cc: Tom Rini, Mattijs Korpershoek, Michal Simek, Marek Vasut,
Casey Connolly, Martin Schwan, Quentin Schulz
From: Quentin Schulz <quentin.schulz@cherry.de>
SPL_FIT_FULL_CHECK currently shares its description and help text with
FIT_FULL_CHECK which is quite confusing, so let's specify this applies
to SPL.
Fixes: 6f3c2d8aa5e6 ("image: Add an option to do a full check of the FIT")
Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
---
boot/Kconfig | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/boot/Kconfig b/boot/Kconfig
index 9adb051400f..db114baa077 100644
--- a/boot/Kconfig
+++ b/boot/Kconfig
@@ -193,13 +193,13 @@ config SPL_FIT_PRINT
Support printing the content of the fitImage in a verbose manner in SPL.
config SPL_FIT_FULL_CHECK
- bool "Do a full check of the FIT before using it"
+ bool "Do a full check of the FIT within SPL before using it"
depends on SPL_FIT
help
- Enable this do a full check of the FIT to make sure it is valid. This
- helps to protect against carefully crafted FITs which take advantage
- of bugs or omissions in the code. This includes a bad structure,
- multiple root nodes and the like.
+ Enable this do a full check of the FIT within SPL to make sure it is
+ valid. This helps to protect against carefully crafted FITs which take
+ advantage of bugs or omissions in the code. This includes a bad
+ structure, multiple root nodes and the like.
config SPL_FIT_SIGNATURE
bool "Enable signature verification of FIT firmware within SPL"
---
base-commit: 4cad9faf8d2887b8851f0ced5194ffbaa92ca71e
change-id: 20251029-spl-fit-full-check-desc-15d43348db55
Best regards,
--
Quentin Schulz <quentin.schulz@cherry.de>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] boot: specify SPL_FIT_FULL_CHECK applies to SPL
2025-10-29 11:08 [PATCH] boot: specify SPL_FIT_FULL_CHECK applies to SPL Quentin Schulz
@ 2025-10-31 15:14 ` Mattijs Korpershoek
2025-11-07 14:17 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Mattijs Korpershoek @ 2025-10-31 15:14 UTC (permalink / raw)
To: Quentin Schulz, Simon Glass, u-boot
Cc: Tom Rini, Mattijs Korpershoek, Michal Simek, Marek Vasut,
Casey Connolly, Martin Schwan, Quentin Schulz
Hi Quentin,
Thank you for the patch.
On Wed, Oct 29, 2025 at 12:08, Quentin Schulz <foss+uboot@0leil.net> wrote:
> From: Quentin Schulz <quentin.schulz@cherry.de>
>
> SPL_FIT_FULL_CHECK currently shares its description and help text with
> FIT_FULL_CHECK which is quite confusing, so let's specify this applies
> to SPL.
>
> Fixes: 6f3c2d8aa5e6 ("image: Add an option to do a full check of the FIT")
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
> ---
> boot/Kconfig | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/boot/Kconfig b/boot/Kconfig
> index 9adb051400f..db114baa077 100644
> --- a/boot/Kconfig
> +++ b/boot/Kconfig
> @@ -193,13 +193,13 @@ config SPL_FIT_PRINT
> Support printing the content of the fitImage in a verbose manner in SPL.
>
> config SPL_FIT_FULL_CHECK
> - bool "Do a full check of the FIT before using it"
> + bool "Do a full check of the FIT within SPL before using it"
> depends on SPL_FIT
> help
> - Enable this do a full check of the FIT to make sure it is valid. This
> - helps to protect against carefully crafted FITs which take advantage
> - of bugs or omissions in the code. This includes a bad structure,
> - multiple root nodes and the like.
> + Enable this do a full check of the FIT within SPL to make sure it is
> + valid. This helps to protect against carefully crafted FITs which take
> + advantage of bugs or omissions in the code. This includes a bad
> + structure, multiple root nodes and the like.
>
> config SPL_FIT_SIGNATURE
> bool "Enable signature verification of FIT firmware within SPL"
>
> ---
> base-commit: 4cad9faf8d2887b8851f0ced5194ffbaa92ca71e
> change-id: 20251029-spl-fit-full-check-desc-15d43348db55
>
> Best regards,
> --
> Quentin Schulz <quentin.schulz@cherry.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] boot: specify SPL_FIT_FULL_CHECK applies to SPL
2025-10-29 11:08 [PATCH] boot: specify SPL_FIT_FULL_CHECK applies to SPL Quentin Schulz
2025-10-31 15:14 ` Mattijs Korpershoek
@ 2025-11-07 14:17 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2025-11-07 14:17 UTC (permalink / raw)
To: Simon Glass, u-boot, Quentin Schulz
Cc: Mattijs Korpershoek, Michal Simek, Marek Vasut, Casey Connolly,
Martin Schwan, Quentin Schulz
On Wed, 29 Oct 2025 12:08:58 +0100, Quentin Schulz wrote:
> SPL_FIT_FULL_CHECK currently shares its description and help text with
> FIT_FULL_CHECK which is quite confusing, so let's specify this applies
> to SPL.
>
>
Applied to u-boot/master, thanks!
[1/1] boot: specify SPL_FIT_FULL_CHECK applies to SPL
commit: 3e68c01baf80c66d0c94be753137f01fba29632d
--
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-07 14:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-29 11:08 [PATCH] boot: specify SPL_FIT_FULL_CHECK applies to SPL Quentin Schulz
2025-10-31 15:14 ` Mattijs Korpershoek
2025-11-07 14:17 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox