Re: [PATCH V5 00/17] board: ti: Add support for BeaglePlay

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

On mer., août 23, 2023 at 22:10, Nishanth Menon <nm@ti.com> wrote:

> Add support for BeaglePlay - rev 5
>
> Full series: https://github.com/nmenon/fix-k3-dt-u-boot/commits/beagleplay-v4.2
>
> Caveats:
> * networking: pending https://lore.kernel.org/all/20230822121350.51324-1-rogerq@kernel.org/
> * 32kclk and usb: pending:
>   https://lore.kernel.org/u-boot/20230725185253.2123433-4-nm@ti.com/
>   OR https://github.com/nmenon/fix-k3-dt-u-boot/commit/853b29d63c1ca642be316f1afb0fb778610dec46
>   being properly resolved (NOTE: without this patch, wlan is broken in
>   Linux as the 32kclk from SoC is incorrectly supplied to wlan as 25MHz)
> * There seems to be a bug in Linux kernel with sdhci that seems to
>   depend on u-boot initialization of sdhci for functionality.
>
> CI loop check: https://github.com/u-boot/u-boot/pull/425 (whenever that
> gets done I guess).
>
> Bootlogs:
> SD Boot: https://gist.github.com/nmenon/c74acb3a895053e05623e886df77c8fe
> eMMC, no SD boot: https://gist.github.com/nmenon/16df3b8fc0e9102f29ebb7836b950a08
> eMMC with SD card: https://gist.github.com/nmenon/042dbe7c08589e7bfe1919da1fedc545
>
> Complete code (with the tmp patch) can be found at:
> https://github.com/nmenon/fix-k3-dt-u-boot/tree/beagleplay-v5
>
> Baseline: 97841de68043 (origin/next) Merge branch '2023-08-22-assorted-code-cleanups' into next
>
> Changes since V4:
> * Switched boot from distro_boot to bootstd - AM62 as a start will rely
>   on txt env file.
> * Cleanups around am625_init.c (new patches)
> * Review comment fixups for documentation
> * I have'nt picked up Mattijs's tested by since this is a different
>   approach (bootstd Vs distro_bootcmd)
> * Dropped the sdhci patches AND CFG_EXTRA_ENV_SETTINGS (Instead, we
>   switch entirely to bootstd and move am62x-sk to bootstd along with
>   it).
>
> V4: https://lore.kernel.org/all/20230822184135.2328409-1-nm@ti.com/
> V3: https://lore.kernel.org/all/20230815164440.2713726-1-nm@ti.com/
> V2: https://lore.kernel.org/u-boot/20230727234446.3651836-1-nm@ti.com/
> V1: https://lore.kernel.org/all/20230725185253.2123433-1-nm@ti.com/
>
> Nishanth Menon (16):
>   include: configs: ti_armv7_common: Add documentation for protected
>     section
>   include: configs: am62x_evm: Drop unused SDRAM address
>   include: configs: am62x_evm: Wrap distroboot with
>     CONFIG_DISTRO_DEFAULTS
>   board: ti: am62x: am62x.env: Add explicit boot_targets
>   configs: am62x_evm_a53_defconfig: Switch to bootstd
>   include: configs: am62x_evm: Drop distro_bootcmd usage
>   include: env: ti: ti_armv7_common.env: Rename to ti_common.env
>   include: env: ti: ti_common: Add a generic findfdt
>   board: ti: am62x: am62x.env: Use default findfdt
>   arm: mach-k3: am625_init: Use IS_ENABLED()
>   arm: mach-k3: am625_init: Convert rtc_erratumi2327_init to static
>   configs: am62x_evm*: Enable EMMC_BOOT configuration
>   arm: mach-k3: am625: Add support for UDA FS
>   arm: dts: k3-am625-sk-binman: Add labels for unsigned binary
>   board: ti: am62x: Add am62x_beagleplay_* defconfigs and env file
>   doc: board: ti: Add BeaglePlay documentation
>
> Robert Nelson (1):
>   arm: dts: Add k3-am625-beagleplay

I re-tested v5.

Using baseline 97841de68043 ("Merge branch '2023-08-22-assorted-code-cleanups' into next")
I could boot all the way to U-boot proper shell.

And the LEDs work for me as well with:

=> led led-0 toggle

So for the whole series:

Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

Note that I did not tried any boot related commands since I mostly work
on Android booting and I have not rebased my wip-branch yet.

>
>  arch/arm/dts/Makefile                         |    2 +
>  .../dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi | 2195 +++++++++++++++++
>  arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi  |  195 ++
>  arch/arm/dts/k3-am625-beagleplay.dts          |  758 ++++++
>  arch/arm/dts/k3-am625-r5-beagleplay.dts       |   86 +
>  arch/arm/dts/k3-am625-sk-binman.dtsi          |    4 +-
>  arch/arm/mach-k3/am625_init.c                 |   49 +-
>  board/siemens/iot2050/iot2050.env             |    2 +-
>  board/ti/am62ax/am62ax.env                    |    2 +-
>  board/ti/am62x/MAINTAINERS                    |    7 +
>  board/ti/am62x/am62x.env                      |    7 +-
>  board/ti/am62x/beagleplay.env                 |   18 +
>  board/ti/am62x/beagleplay_a53.config          |   55 +
>  board/ti/am62x/beagleplay_r5.config           |   15 +
>  board/ti/am64x/am64x.env                      |    2 +-
>  board/ti/am65x/am65x.env                      |    2 +-
>  board/ti/j721e/j721e.env                      |    2 +-
>  board/ti/j721s2/j721s2.env                    |    2 +-
>  board/ti/ks2_evm/k2e_evm.env                  |    2 +-
>  board/ti/ks2_evm/k2g_evm.env                  |    2 +-
>  board/ti/ks2_evm/k2hk_evm.env                 |    2 +-
>  board/ti/ks2_evm/k2l_evm.env                  |    2 +-
>  configs/am62x_evm_a53_defconfig               |    6 +-
>  configs/am62x_evm_r5_defconfig                |    1 +
>  doc/board/ti/am62x_beagleplay.rst             |  256 ++
>  doc/board/ti/img/beagleplay_emmc.svg          |  697 ++++++
>  doc/board/ti/k3.rst                           |    1 +
>  include/configs/am62x_evm.h                   |    6 -
>  include/configs/ti_armv7_common.h             |    2 +-
>  .../ti/{ti_armv7_common.env => ti_common.env} |   12 +
>  30 files changed, 4342 insertions(+), 50 deletions(-)
>  create mode 100644 arch/arm/dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi
>  create mode 100644 arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
>  create mode 100644 arch/arm/dts/k3-am625-beagleplay.dts
>  create mode 100644 arch/arm/dts/k3-am625-r5-beagleplay.dts
>  create mode 100644 board/ti/am62x/beagleplay.env
>  create mode 100644 board/ti/am62x/beagleplay_a53.config
>  create mode 100644 board/ti/am62x/beagleplay_r5.config
>  create mode 100644 doc/board/ti/am62x_beagleplay.rst
>  create mode 100644 doc/board/ti/img/beagleplay_emmc.svg
>  rename include/env/ti/{ti_armv7_common.env => ti_common.env} (71%)
>
> -- 
> 2.40.0