From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B479C678D5 for ; Tue, 7 Mar 2023 19:53:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 48EEE85B7E; Tue, 7 Mar 2023 20:53:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=xs4all.nl header.i=@xs4all.nl header.b="EeZwhC1t"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9C35C85BBD; Tue, 7 Mar 2023 20:53:44 +0100 (CET) Received: from ewsoutbound.kpnmail.nl (ewsoutbound.kpnmail.nl [195.121.94.168]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 24BA985B7A for ; Tue, 7 Mar 2023 20:53:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mark.kettenis@xs4all.nl X-KPN-MessageId: bbba9351-bd21-11ed-a1d8-005056aba152 Received: from smtp.kpnmail.nl (unknown [10.31.155.37]) by ewsoutbound.so.kpn.org (Halon) with ESMTPS id bbba9351-bd21-11ed-a1d8-005056aba152; Tue, 07 Mar 2023 20:53:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=xs4all01; h=subject:to:from:message-id:date; bh=BvAzOSPnk3FQADPz/YZIyzkJeQn9cfT0U+5AvoDYIsQ=; b=EeZwhC1tJpJvmqVeuwH7SPUp1DSA8jEJqi9i7HFLzSAPdHMJ6ASlJGEUPmhLaaz7UFI+PUOyaFK3c +CCyL5QRwmKrxNu6yk385LygRLMIZ1UA6zGVUOdnKlBIgbkdhV+nkS5EN5ebPTFhS+pvV08DUvRols iXCCypoHL+J9ZaOGB4muEI6VFos8YZoUsUChNDwWfFa5cA5W8cPVRKef/Ay7M1LhbE6nMsTz/ScO/E TSyyqrF7V6qlH05qP0cKO4sBJCm24iRzie6wtZbjsRaxxGzI2qdxUrjqohvwhjjthi7Fnru3Ioe+aj wjjsxnGW0t7SIYYqLnWY+I3nwPJSBKA== X-KPN-MID: 33|oQ+CgZ1f4sVp1nD3KwKRu32EnNaMhx3MGNxP27ZcBQxNeWbOFRkwckW5932tMNa CDsEgtVaTIBDUFfQCs+yrARYtuKo+A7mE19L2cHBXKvs= X-KPN-VerifiedSender: Yes X-CMASSUN: 33|QvcW/Y+dtu9/u0/7Zku9LfXqVoUgJG5/bosmcRJwdzeHHbOF46L1Kn8T9GoC8x/ 81QwE8CFmwBmdV2L0LAVK5Q== X-Originating-IP: 80.61.163.207 Received: from bloch.sibelius.xs4all.nl (80-61-163-207.fixed.kpn.net [80.61.163.207]) by smtp.xs4all.nl (Halon) with ESMTPSA id bff3672a-bd21-11ed-ae07-005056ab1411; Tue, 07 Mar 2023 20:53:38 +0100 (CET) Date: Tue, 07 Mar 2023 20:53:36 +0100 Message-Id: <87o7p4cp8f.fsf@bloch.sibelius.xs4all.nl> From: Mark Kettenis To: Vasily Khoruzhick Cc: sjg@chromium.org, philipp.tomsich@vrull.eu, kever.yang@rock-chips.com, gajjar04akash@gmail.com, abbaraju.manojsai@amarulasolutions.com, jagan@amarulasolutions.com, john@metanate.com, jianing.ren@rock-chips.com, u-boot@lists.denx.de, anarsoul@gmail.com In-Reply-To: <20230307193748.25712-2-anarsoul@gmail.com> (message from Vasily Khoruzhick on Tue, 7 Mar 2023 11:37:48 -0800) Subject: Re: [PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates References: <20230307193748.25712-1-anarsoul@gmail.com> <20230307193748.25712-2-anarsoul@gmail.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean > From: Vasily Khoruzhick > Date: Tue, 7 Mar 2023 11:37:48 -0800 > > combphy0 is failing to probe due to unhandled assigned-clocks and > assigned-clocks-rates. That is probably the wrong approach. It should be possible to boot an OS with the device tree provided by U-Boot. Removing these properties means the OS doesn't see them either. But if the assigned-clocks property isn't needed it wouldn't be there would it? > commit 5bec4b0de785 ("arm64: dts: rk356x-u-boot: Drop combphy1 assigned-clocks/rates") > dropped these properties for combphy1, so let's drop them for combphy0 as well. > > Signed-off-by: Vasily Khoruzhick > --- > arch/arm/dts/rk3568-evb-u-boot.dtsi | 1 + > arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 1 + > arch/arm/dts/rk3568-u-boot.dtsi | 11 +++++++++++ > 3 files changed, 13 insertions(+) > create mode 100644 arch/arm/dts/rk3568-u-boot.dtsi > > diff --git a/arch/arm/dts/rk3568-evb-u-boot.dtsi b/arch/arm/dts/rk3568-evb-u-boot.dtsi > index 17503d3d27..77430da3ba 100644 > --- a/arch/arm/dts/rk3568-evb-u-boot.dtsi > +++ b/arch/arm/dts/rk3568-evb-u-boot.dtsi > @@ -4,6 +4,7 @@ > */ > > #include "rk356x-u-boot.dtsi" > +#include "rk3568-u-boot.dtsi" > > / { > chosen { > diff --git a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi > index ed47efa44b..44cf33ed4b 100644 > --- a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi > +++ b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi > @@ -5,6 +5,7 @@ > */ > > #include "rk356x-u-boot.dtsi" > +#include "rk3568-u-boot.dtsi" > > / { > chosen { > diff --git a/arch/arm/dts/rk3568-u-boot.dtsi b/arch/arm/dts/rk3568-u-boot.dtsi > new file mode 100644 > index 0000000000..c6776666df > --- /dev/null > +++ b/arch/arm/dts/rk3568-u-boot.dtsi > @@ -0,0 +1,11 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2023 Vasily Khoruzhick > + */ > + > +#include "rockchip-u-boot.dtsi" > + > +&combphy0 { > + /delete-property/ assigned-clocks; > + /delete-property/ assigned-clock-rates; > +}; > -- > 2.39.2 > >