From: Mattijs Korpershoek via U-Boot <u-boot@lists.u-boot-project.org>
To: u-boot@lists.denx.de, Marek Vasut <marex@nabladev.com>
Cc: Lukasz Majewski <lukma@nabladev.com>,
Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v2] cmd: ums: Set Device Descriptor iSerial based on serial# env variable
Date: Wed, 22 Jul 2026 09:01:19 +0200 [thread overview]
Message-ID: <87pl0fik3k.fsf@kernel.org> (raw)
In-Reply-To: <178470329369.163835.10555173122638201570.b4-ty@b4>
On Wed, Jul 22, 2026 at 08:54, Mattijs Korpershoek via U-Boot <u-boot@lists.u-boot-project.org> wrote:
> Hi,
>
> On Fri, 26 Jun 2026 16:28:17 +0200, Marek Vasut wrote:
>> The DFU code currently sets the content of "serial#" environment
>> variable into Device Descriptor iSerial field. This is useful when
>> there are multiple devices connected to the same host PC and they
>> have to be told apart. Replicate the same behavior in the UMS code.
>>
>> Example without serial# set, which is the original behavior:
>> "
>> u-boot=> ums 0 mmc 1
>> UMS: LUN 0, dev mmc 1, hwpart 0, sector 0x0, count 0x1d5a000
>>
>> [...]
>
> Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu)
>
> [1/1] cmd: ums: Set Device Descriptor iSerial based on serial# env variable
> https://source.denx.de/u-boot/custodians/u-boot-dfu/-/commit/3caa8f42e1f657177780be5a445502cbb9181e43
Err, I forgot to update my automation. This patch has been applied to
the new source location:
https://git.u-boot-project.org/u-boot/custodians/u-boot-dfu.git
See: https://git.u-boot-project.org/u-boot/custodians/u-boot-dfu/-/commit/3caa8f42e1f657177780be5a445502cbb9181e43
>
> --
> Mattijs
prev parent reply other threads:[~2026-07-22 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 14:28 [PATCH v2] cmd: ums: Set Device Descriptor iSerial based on serial# env variable Marek Vasut
2026-06-29 11:11 ` Mattijs Korpershoek
2026-07-22 6:54 ` Mattijs Korpershoek via U-Boot
2026-07-22 7:01 ` Mattijs Korpershoek via U-Boot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pl0fik3k.fsf@kernel.org \
--to=u-boot@lists.u-boot-project.org \
--cc=lukma@nabladev.com \
--cc=marex@nabladev.com \
--cc=mkorpershoek@kernel.org \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox