From: Rasmus Villemoes <ravi@prevas.dk>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [PATCH v2 0/2] 'part name' subcommand and some robustification
Date: Sat, 08 Nov 2025 01:02:14 +0100 [thread overview]
Message-ID: <87pl9tcry1.fsf@prevas.dk> (raw)
In-Reply-To: <20251107201927.GA2243313@bill-the-cat> (Tom Rini's message of "Fri, 7 Nov 2025 14:19:27 -0600")
On Fri, Nov 07 2025, Tom Rini <trini@konsulko.com> wrote:
> On Mon, Oct 20, 2025 at 02:10:58PM +0200, Rasmus Villemoes wrote:
>
>> Implement a "part name" subcommand, mirroring the existing "part
>> number" subcommand.
>>
>> In the discussion for v1 of that, it came up that there's a bit of
>> inconsistency in how much and what one can assume to be initialized in
>> 'struct disk_partition' after a successful call of one of the
>> get_info* family of functions. The new patch 1/2 tries to consolidate
>> that by making sure all ->get_info invocations go through a common
>> helper that at least always initializes the string members.
>>
>> Rasmus Villemoes (2):
>> disk/part.c: ensure strings in struct disk_partition are valid after
>> successful get_info
>> cmd/part.c: implement "part name" subcommand
>>
>> cmd/gpt.c | 4 +--
>> cmd/part.c | 16 ++++++++++-
>> disk/part.c | 62 ++++++++++++++++++++++++------------------
>> doc/usage/cmd/part.rst | 13 +++++++++
>> include/part.h | 16 +++++++++++
>> 5 files changed, 81 insertions(+), 30 deletions(-)
>
> This leads to some of the bootstd tests failing in CI, unfortunately.
Do you have a link?
Also, how exactly should one run those bootstd tests? When I just build
sandbox_defconfig and do 'ut bootstd', I get 130 failures, so I assume I
need to do something extra.
Rasmus
next prev parent reply other threads:[~2025-11-08 0:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 12:10 [PATCH v2 0/2] 'part name' subcommand and some robustification Rasmus Villemoes
2025-10-20 12:10 ` [PATCH v2 1/2] disk/part.c: ensure strings in struct disk_partition are valid after successful get_info Rasmus Villemoes
2025-11-03 14:07 ` Quentin Schulz
2025-10-20 12:11 ` [PATCH v2 2/2] cmd/part.c: implement "part name" subcommand Rasmus Villemoes
2025-11-03 14:14 ` Quentin Schulz
2025-11-03 20:38 ` Rasmus Villemoes
2025-11-04 9:36 ` Quentin Schulz
2025-11-07 20:19 ` [PATCH v2 0/2] 'part name' subcommand and some robustification Tom Rini
2025-11-08 0:02 ` Rasmus Villemoes [this message]
2025-11-08 15:01 ` Tom Rini
2025-11-10 0:33 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pl9tcry1.fsf@prevas.dk \
--to=ravi@prevas.dk \
--cc=quentin.schulz@cherry.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox