From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH v2] patman: Add a 'keep_change_id' setting
Date: Thu, 02 Nov 2023 20:30:16 -0400 [thread overview]
Message-ID: <87pm0rlluv.fsf@gmail.com> (raw)
In-Reply-To: <CAPnjgZ2V0QejBkqyCB98rt4v7AZbuOp-cDHFy5oA0GBsXjvk4w@mail.gmail.com> (Simon Glass's message of "Thu, 2 Nov 2023 17:49:28 -0500")
Hi Simon,
Simon Glass <sjg@chromium.org> writes:
> On Thu, 12 Oct 2023 at 20:06, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>>
>> A Change-Id can be useful for traceability purposes, and some projects
>> may wish to have them preserved. This change makes it configurable
>> via a new 'keep_change_id' setting.
>>
>> Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>
>> ---
>>
>> Changes in v2:
>> - Add missing argument to send parser
>> - Correctly propagate args.keep_change_id
>>
>> tools/patman/__main__.py | 2 ++
>> tools/patman/control.py | 12 +++++++++---
>> tools/patman/patchstream.py | 17 ++++++++++++-----
>> tools/patman/patman.rst | 11 ++++++-----
>> tools/patman/test_checkpatch.py | 16 ++++++++++++++++
>> 5 files changed, 45 insertions(+), 13 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> Applied to u-boot-dm, thanks!
And thanks for the timely review! :-)
--
Maxim
prev parent reply other threads:[~2023-11-03 0:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 1:19 [PATCH] patman: Add a 'keep_change_id' setting Maxim Cournoyer
2023-10-13 3:06 ` [PATCH v2] " Maxim Cournoyer
2023-10-13 16:57 ` Simon Glass
2023-11-02 22:49 ` Simon Glass
2023-11-03 0:30 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm0rlluv.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox