Re: [PATCH V6 00/20] board: ti: Add support for BeaglePlay

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

On ven., août 25, 2023 at 13:02, Nishanth Menon <nm@ti.com> wrote:

> Alright, 6th time is a charm ;) Hopefully this takes care of all
> the un-addressed concerns we have had. Thanks all for pitching in,
> reviewing and improving and I will stop finding things to
> cleanup (promise).
>
> Baseline: 7c6b18fb5494 (origin/next) Merge branch '2023-08-24-enable-more-features-in-qemu-arm' into next
> Full series available: https://github.com/nmenon/fix-k3-dt-u-boot/commits/beagleplay-v6
> Boot Logs: https://gist.github.com/nmenon/8be4106e2d0b572aa5e77d93476095b4
>
> Caveats:
> * Networking: pending https://lore.kernel.org/all/20230822121350.51324-1-rogerq@kernel.org/
> * 32kclk and usb: pending:
>   https://lore.kernel.org/u-boot/20230725185253.2123433-4-nm@ti.com/
>   OR https://github.com/nmenon/fix-k3-dt-u-boot/commit/853b29d63c1ca642be316f1afb0fb778610dec46
>   being properly resolved (NOTE: without this patch, wlan is broken in
>   Linux as the 32kclk from SoC is incorrectly supplied to wlan as 25MHz)
> * There seems to be a bug in Linux kernel with sdhci that seems to
>   depend on u-boot initialization of sdhci for functionality (TI
>   internal actions already triggered).
> * buildman discussion about config fragments:
>   https://lore.kernel.org/all/CAPnjgZ14CUVt=rM943hh9PQUhK9LJDgZYPxUsATYQe3wwOUYqQ@mail.gmail.com/
> * Documentation that we can copy paste:
>   https://lore.kernel.org/all/20230824154036.3650607-1-nm@ti.com/
>   and followon in kernel.org:
>   https://lore.kernel.org/all/149528e1-062b-ebed-aa25-d37be5fe5894@iogearbox.net/
>   if it all percolates back down to u-boot tree, should be trivial
>   cleanup.
> * Build fails with binman implementation for TI SoCs - Neha will take
>   care of
>   https://lore.kernel.org/all/227d74cf-9e95-4f5f-af96-49d054cde7aa@ti.com/
> * This series picks up Jan's patch for working around Device Manager not
>   compliant with EFI specification reqs and applies it to am62x_sk (TI
>   internal action already triggered)
>   https://lore.kernel.org/all/20230825011623.c74qqidp6wgvc5kl@plaza/
> * I noticed that when drivers like the am654_sdhci.c uses
>   deffered_probe, the default probe function does'nt fail
>   https://source.denx.de/u-boot/u-boot/-/blob/master/boot/bootflow.c#L279
>   So ends up attempting for each of the boot_targets even if mmc dev
>   dev_id would fail. Not really sure how to solve it, so will leave it
>   here. (the https://gist.github.com/nmenon/8be4106e2d0b572aa5e77d93476095b4#file-beagleplay-emmc-sd-not-inserted
>   should show a bunch of 'MMC: no card present' each of which costs around
>   1 second.
>
> Changes since V5:
> * New patches to clean up mmc.env to sync with BOOTSTD operations yet
>   enable easier non-U-Boot developer experience for uEnv.txt and
>   optimize access to non-plugged in sd-card.
> * Picked up Jan's patch[1] as part of this series.
> * Introduced default_findfdt.env as review comment
> * Saw Simon's feedback on uSD boot, and documented that as well, will be
>   good for new devs to have that info in one flow.
> * Quick overall diff: https://gist.github.com/nmenon/6d934f4e1092aa293a771d26b0f2bff7
>
> V5: https://lore.kernel.org/all/20230824031101.3460411-1-nm@ti.com/
> V4: https://lore.kernel.org/all/20230822184135.2328409-1-nm@ti.com/
> V3: https://lore.kernel.org/all/20230815164440.2713726-1-nm@ti.com/
> V2: https://lore.kernel.org/u-boot/20230727234446.3651836-1-nm@ti.com/
> V1: https://lore.kernel.org/all/20230725185253.2123433-1-nm@ti.com/
>
> Jan Kiszka (1):
>   configs: am62x_evm_a53_defconfig: Disable semi-functional PSCI reset
>     support
>
> Nishanth Menon (18):
>   include: env: ti: mmc: envboot/mmcboot: Check result of mmc dev before
>     proceeding
>   include: env: ti: mmc: envboot: Only attempt boot.scr if BOOTSTD is
>     not enabled
>   include: configs: ti_armv7_common: Add documentation for protected
>     section
>   include: configs: am62x_evm: Drop unused SDRAM address
>   include: configs: am62x_evm: Wrap distroboot with
>     CONFIG_DISTRO_DEFAULTS
>   board: ti: am62x: am62x.env: Add explicit boot_targets
>   configs: am62x_evm_a53_defconfig: Switch to bootstd
>   include: configs: am62x_evm: Drop distro_bootcmd usage
>   include: env: ti: ti_armv7_common.env: Rename to ti_common.env
>   include: env: ti: Add a generic default_findfdt.env
>   board: ti: am62x: am62x.env: Use default findfdt
>   arm: mach-k3: am625_init: Use IS_ENABLED()
>   arm: mach-k3: am625_init: Convert rtc_erratumi2327_init to static
>   configs: am62x_evm*: Enable EMMC_BOOT configuration
>   arm: mach-k3: am625: Add support for UDA FS
>   arm: dts: k3-am625-sk-binman: Add labels for unsigned binary
>   board: ti: am62x: Add am62x_beagleplay_* defconfigs and env file
>   doc: board: ti: Add BeaglePlay documentation
>
> Robert Nelson (1):
>   arm: dts: Add k3-am625-beagleplay

I re-tested v6.

Using baseline 11cf91f755c7 ("Merge branch '2023-08-26-bootstd-chromeos-impreovements-and-move-to-gcc-13.2' into next")
I could boot all the way to U-boot proper shell.

And the LEDs work for me as well with:

=> led led-0 toggle

So for the whole series:

Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

Note that I did not tried any boot related commands since I mostly work
on Android booting and I have not rebased my wip-branch yet.

>
>  arch/arm/dts/Makefile                         |    2 +
>  .../dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi | 2195 +++++++++++++++++
>  arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi  |  195 ++
>  arch/arm/dts/k3-am625-beagleplay.dts          |  758 ++++++
>  arch/arm/dts/k3-am625-r5-beagleplay.dts       |   86 +
>  arch/arm/dts/k3-am625-sk-binman.dtsi          |    4 +-
>  arch/arm/mach-k3/am625_init.c                 |   49 +-
>  board/siemens/iot2050/iot2050.env             |    2 +-
>  board/ti/am62ax/am62ax.env                    |    2 +-
>  board/ti/am62x/MAINTAINERS                    |    7 +
>  board/ti/am62x/am62x.env                      |    8 +-
>  board/ti/am62x/beagleplay.env                 |   19 +
>  board/ti/am62x/beagleplay_a53.config          |   55 +
>  board/ti/am62x/beagleplay_r5.config           |   15 +
>  board/ti/am64x/am64x.env                      |    2 +-
>  board/ti/am65x/am65x.env                      |    2 +-
>  board/ti/j721e/j721e.env                      |    2 +-
>  board/ti/j721s2/j721s2.env                    |    2 +-
>  board/ti/ks2_evm/k2e_evm.env                  |    2 +-
>  board/ti/ks2_evm/k2g_evm.env                  |    2 +-
>  board/ti/ks2_evm/k2hk_evm.env                 |    2 +-
>  board/ti/ks2_evm/k2l_evm.env                  |    2 +-
>  configs/am62x_evm_a53_defconfig               |    7 +-
>  configs/am62x_evm_r5_defconfig                |    1 +
>  doc/board/ti/am62x_beagleplay.rst             |  322 +++
>  doc/board/ti/img/beagleplay_emmc.svg          |  697 ++++++
>  doc/board/ti/k3.rst                           |    1 +
>  include/configs/am62x_evm.h                   |    6 -
>  include/configs/ti_armv7_common.h             |    2 +-
>  include/env/ti/default_findfdt.env            |   12 +
>  include/env/ti/mmc.env                        |   12 +-
>  .../ti/{ti_armv7_common.env => ti_common.env} |    0
>  32 files changed, 4419 insertions(+), 54 deletions(-)
>  create mode 100644 arch/arm/dts/k3-am625-beagleplay-ddr4-1600MTs.dtsi
>  create mode 100644 arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
>  create mode 100644 arch/arm/dts/k3-am625-beagleplay.dts
>  create mode 100644 arch/arm/dts/k3-am625-r5-beagleplay.dts
>  create mode 100644 board/ti/am62x/beagleplay.env
>  create mode 100644 board/ti/am62x/beagleplay_a53.config
>  create mode 100644 board/ti/am62x/beagleplay_r5.config
>  create mode 100644 doc/board/ti/am62x_beagleplay.rst
>  create mode 100644 doc/board/ti/img/beagleplay_emmc.svg
>  create mode 100644 include/env/ti/default_findfdt.env
>  rename include/env/ti/{ti_armv7_common.env => ti_common.env} (100%)
>
> [1] https://lore.kernel.org/all/c93b19ed-43fe-44a2-9726-371fb9d2f825@web.de/
> -- 
> 2.40.0