* [U-Boot] [PATCH v2 1/1] common: Compile error with CONFIG_MULTI_DTB_FIT and not SPL
@ 2018-10-23 8:21 Lars Povlsen
2018-10-24 8:26 ` Jean-Jacques Hiblot
2018-11-09 18:43 ` [U-Boot] [U-Boot, v2, " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Lars Povlsen @ 2018-10-23 8:21 UTC (permalink / raw)
To: u-boot
common/common_fit.c is including <spl.h>, but not actually using it. The
inclusion will cuase compile error on platforms using CONFIG_OF_SEPARATE
and not SPL.
Signed-off-by: Lars Povlsen <lars.povlsen@microsemi.com>
---
common/common_fit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/common/common_fit.c b/common/common_fit.c
index 577b352..a35c7e9 100644
--- a/common/common_fit.c
+++ b/common/common_fit.c
@@ -8,7 +8,6 @@
#include <errno.h>
#include <image.h>
#include <linux/libfdt.h>
-#include <spl.h>
ulong fdt_getprop_u32(const void *fdt, int node, const char *prop)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [U-Boot] [PATCH v2 1/1] common: Compile error with CONFIG_MULTI_DTB_FIT and not SPL
2018-10-23 8:21 [U-Boot] [PATCH v2 1/1] common: Compile error with CONFIG_MULTI_DTB_FIT and not SPL Lars Povlsen
@ 2018-10-24 8:26 ` Jean-Jacques Hiblot
2018-11-09 18:43 ` [U-Boot] [U-Boot, v2, " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Jean-Jacques Hiblot @ 2018-10-24 8:26 UTC (permalink / raw)
To: u-boot
On 23/10/2018 10:21, Lars Povlsen wrote:
> common/common_fit.c is including <spl.h>, but not actually using it. The
> inclusion will cuase compile error on platforms using CONFIG_OF_SEPARATE
> and not SPL.
>
> Signed-off-by: Lars Povlsen <lars.povlsen@microsemi.com>
> ---
> common/common_fit.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/common/common_fit.c b/common/common_fit.c
> index 577b352..a35c7e9 100644
> --- a/common/common_fit.c
> +++ b/common/common_fit.c
> @@ -8,7 +8,6 @@
> #include <errno.h>
> #include <image.h>
> #include <linux/libfdt.h>
> -#include <spl.h>
>
> ulong fdt_getprop_u32(const void *fdt, int node, const char *prop)
> {
Reviewed-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* [U-Boot] [U-Boot, v2, 1/1] common: Compile error with CONFIG_MULTI_DTB_FIT and not SPL
2018-10-23 8:21 [U-Boot] [PATCH v2 1/1] common: Compile error with CONFIG_MULTI_DTB_FIT and not SPL Lars Povlsen
2018-10-24 8:26 ` Jean-Jacques Hiblot
@ 2018-11-09 18:43 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2018-11-09 18:43 UTC (permalink / raw)
To: u-boot
On Tue, Oct 23, 2018 at 10:21:25AM +0200, Lars Povlsen wrote:
> common/common_fit.c is including <spl.h>, but not actually using it. The
> inclusion will cuase compile error on platforms using CONFIG_OF_SEPARATE
> and not SPL.
>
> Signed-off-by: Lars Povlsen <lars.povlsen@microsemi.com>
> Reviewed-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181109/03112611/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-09 18:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-23 8:21 [U-Boot] [PATCH v2 1/1] common: Compile error with CONFIG_MULTI_DTB_FIT and not SPL Lars Povlsen
2018-10-24 8:26 ` Jean-Jacques Hiblot
2018-11-09 18:43 ` [U-Boot] [U-Boot, v2, " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox