From: Bill Pringlemeir <bpringlemeir@nbsps.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mx25: Fix boot hang by avoiding vector relocation
Date: Thu, 08 Jan 2015 10:10:45 -0500 [thread overview]
Message-ID: <87ppap5mve.fsf@nbsps.com> (raw)
In-Reply-To: <20150108143526.GV10826@bill-the-cat> (Tom Rini's message of "Thu, 8 Jan 2015 09:35:26 -0500")
> On Tue, Jan 06, 2015 at 01:06:48PM -0200, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Since commit 3ff46cc42b9d73d0 ("arm: relocate the exception vectors")
>> mx25pdk hangs like this:
>>
>> CPU: Freescale i.MX25 rev1.2 at 399 MHz
>> Reset cause: WDOG
>> Board: MX25PDK
>> I2C: ready
>> DRAM: 64 MiB
>> (hangs)
>>
>> Add a specific relocate_vectors macro that skips the vector
>> relocation, as the i.MX25 SoC does not provide RAM at the high
>> vectors address (0xFFFF0000), and (0x00000000) maps to ROM.
>>
>> This allows mx25 to boot again.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
On 8 Jan 2015, trini at ti.com wrote:
> I'd like to pull this in for the release. I'd also really like
> someone else to ack or otherwise comment on this (and why this is more
> right than not just relocating the vectors as v1 did, I see both boot
> to a U-Boot prompt but shouldn't we do a bit more testing to confirm
> that we don't need to relocate these exception vectors or have we now
> introduced some subtle breakage (or perhaps not so subtle once you hit
> it) in these cases? Thanks!
Acked-By: Bill Pringlemeir <bpringlemeir@nbsps.com>
The addresses in v1 of the patch are for the imx27. The will do nothing
for the imx25. On the imx25, the address 0x0 is ROM and will BUS error
on a write (default without any patch). The address 0xffff0000 is
mapped to a WEIM peripheral (external Addr+Data w chip select) and
writes there will not BUS error (so v1 patch works). However, it is
misleading as the real 'hook' vectors are located in IRAM (0x78xxxxxx);
it is very similar in concept to imx27. It is better just to provide a
stub that does nothing than misleading people to think they are hooked.
The HAB code on the iMX25 ROM has some vectors installed so that any
errors will reset or go to serial boot mode. This is what this platform
has done all along. The most correct way would be to hook the vectors,
but the hook addresses are only in an NDA doc and would require some
testing, etc. because even that document is not 100% clear.
Fwiw,
Bill Pringlemeir.
next prev parent reply other threads:[~2015-01-08 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 15:06 [U-Boot] [PATCH v2] mx25: Fix boot hang by avoiding vector relocation Fabio Estevam
2015-01-08 14:35 ` Tom Rini
2015-01-08 15:10 ` Bill Pringlemeir [this message]
2015-01-09 13:34 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppap5mve.fsf@nbsps.com \
--to=bpringlemeir@nbsps.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox