From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Bastien Curutchet (DAVE.eu)" <bastien.curutchet@bootlin.com>
Cc: u-boot@lists.denx.de,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Michal Simek <michal.simek@amd.com>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Michael Trimarchi <michael@amarulasolutions.com>,
Andrea Scian <andrea.scian@dave.eu>,
Tom Rini <trini@konsulko.com>,
Andrew Goodbody <andrew.goodbody@linaro.org>
Subject: Re: [PATCH v3 6/6] mtd: rawnand: nand_base: Don't overwrite read/write_page_raw() for soft ECC
Date: Fri, 03 Jul 2026 12:19:21 +0200 [thread overview]
Message-ID: <87qzlknzo6.fsf@bootlin.com> (raw)
In-Reply-To: <20260702-dave-upstream-nand-fixes-v3-6-3814352982ad@bootlin.com> (Bastien Curutchet's message of "Thu, 02 Jul 2026 15:08:46 +0200")
On 02/07/2026 at 15:08:46 +02, "Bastien Curutchet (DAVE.eu)" <bastien.curutchet@bootlin.com> wrote:
> On writes, the Zynq NAND controller needs a bit to be set in the address
> register for the last 4 bytes sent. This is correctly handled by the
> zynq_nand_write_page_raw() operation but the callback is overwritten
> by the core when soft ECC is on. It leads to write failures.
>
> Don't overwrite the write_page_raw callback if it already has a specific
> implementation in the NAND driver.
> Do the same for the read_page_raw callback to keep symetry between reads
> and writes.
>
> Signed-off-by: Bastien Curutchet (DAVE.eu)
> <bastien.curutchet@bootlin.com>
This solution is aligned with what we have done in Linux as well, thanks
for the fix which seems rather straightforward this way.
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
prev parent reply other threads:[~2026-07-03 13:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 13:08 [PATCH v3 0/6] mtd: rawnand: zynq: Fixes and software ECC support Bastien Curutchet
2026-07-02 13:08 ` [PATCH v3 1/6] mtd: rawnand: zynq: Align the layout structures with the driver namespace Bastien Curutchet
2026-07-02 13:08 ` [PATCH v3 2/6] mtd: rawnand: zynq: Add comments about very bad practices Bastien Curutchet
2026-07-02 13:08 ` [PATCH v3 3/6] mtd: rawnand: zynq: Make sure an of node is attached Bastien Curutchet
2026-07-02 13:08 ` [PATCH v3 4/6] mtd: rawnand: zynq: Do not fail the probe for no reason Bastien Curutchet
2026-07-02 13:08 ` [PATCH v3 5/6] mtd: rawnand: zynq: Fix Software ECC engine support Bastien Curutchet
2026-07-02 13:08 ` [PATCH v3 6/6] mtd: rawnand: nand_base: Don't overwrite read/write_page_raw() for soft ECC Bastien Curutchet (DAVE.eu)
2026-07-03 10:19 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzlknzo6.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=andrea.scian@dave.eu \
--cc=andrew.goodbody@linaro.org \
--cc=bastien.curutchet@bootlin.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=michael@amarulasolutions.com \
--cc=michal.simek@amd.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox