From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: "Petr Beneš" <petr.benes@ysoft.com>, trini@konsulko.com, marex@denx.de
Cc: lukma@denx.de, mkorpershoek@kernel.org, u-boot@lists.denx.de,
"Petr Beneš" <petr.benes@ysoft.com>
Subject: Re: [PATCH v2 1/2] usb: ci_udc: Check ci_ep->desc before use
Date: Tue, 06 Jan 2026 14:20:28 +0100 [thread overview]
Message-ID: <87qzs2g9nn.fsf@kernel.org> (raw)
In-Reply-To: <20251218142737.3169753-1-petr.benes@ysoft.com>
Hi Petr,
Thank you for the patch.
On Thu, Dec 18, 2025 at 15:27, Petr Beneš <petr.benes@ysoft.com> wrote:
> There are two places where ci_ep->desc could be accessed despite it is
> not valid at that moment. Either the endpoint has not been enabled yet
> or it has been disabled meanwhile (The ethernet gadged behaves this way
> at least.). That results in dereferencing a null pointer.
>
> Moreover, the patch gets rid of possible outstanding requests if the
> endpoint's state changes to disabled.
>
> Signed-off-by: Petr Beneš <petr.benes@ysoft.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
> ---
>
> v2: return values aligned with Linux as requested by Mattijs
>
next prev parent reply other threads:[~2026-01-06 13:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 14:27 [PATCH v2 1/2] usb: ci_udc: Check ci_ep->desc before use Petr Beneš
2025-12-18 14:27 ` [PATCH v2 2/2] usb: ci_udc: cosmetics: EP and requests debug info Petr Beneš
2026-01-06 13:20 ` Mattijs Korpershoek [this message]
2026-01-09 8:25 ` [PATCH v2 1/2] usb: ci_udc: Check ci_ep->desc before use Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzs2g9nn.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=petr.benes@ysoft.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox