From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EF98C61DA4 for ; Sun, 19 Feb 2023 02:19:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 27709857E9; Sun, 19 Feb 2023 03:19:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=debian.org header.i=@debian.org header.b="OUFD/Tui"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BF93A85011; Sun, 19 Feb 2023 03:19:36 +0100 (CET) Received: from cascadia.aikidev.net (cascadia.aikidev.net [IPv6:2600:3c01:e000:267:0:a171:de7:c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 378328514E; Sun, 19 Feb 2023 03:19:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=vagrant@debian.org Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:20]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 3BA911AB5B; Sat, 18 Feb 2023 18:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1676773167; bh=M4aeKzzVoFe7NJ7dl81l9NJXPZQ2EY8Femr1JyOIkss=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=OUFD/TuiJ14NOz/ZwDlF7e/xM0S1m1TtALMBQkkqyVsyoBivQrDmqIZYFq4tnwatn lKOMenqdinQKbzAs5YmYXrFYVZ51Jego/cJnkuUGC/vU5V8Tt2ff2uZqxkLCyEoXxE MK2JbwryPzIzDovieMAMIHMMt83x+JDR+9C2tQLqr7GyQ7nPZMs/omxZoxdo0yRMcZ OnJqK8d3qSeJTcsqm6SFIxr648Kve4UbqG15VIqzOD4lR5Mu8e6RRY7yrNpPBKpX0A SfmkO8yBpD6Mvtcr+Pp1E4MOk/++bozFJLRjVPaxj2j1f54pcpTbYiFP2zoBbbgJCo hEK2CL1ZuzcoA== From: Vagrant Cascadian To: Simon Glass , U-Boot Mailing List Cc: U-Boot Custodians , Simon Glass , Jeffy Chen , Johan Jonker , Kever Yang , Peng Fan , Philipp Tomsich , Philipp Tomsich , huang lin Subject: rk3399 boards broken, only partially converted to standard boot? (was Re: [PATCH 71/71] rockchip: Convert rockpro64-rk3399 to use standard boot) In-Reply-To: <20221207085137.445249-72-sjg@chromium.org> References: <20221207085137.445249-1-sjg@chromium.org> <20221207085137.445249-72-sjg@chromium.org> Date: Sat, 18 Feb 2023 18:19:22 -0800 Message-ID: <87r0um9z2t.fsf@contorta> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2022-12-07, Simon Glass wrote: > Drop the use of scripts and rely on standard boot for all operation. This patch, applied as 3891c68ef50eda38d78c95ecd03aed030aa6bb53 broke booting on pinebook-pro-rk3399, which still tries to "run distro_bootcmd" but distro_bootcmd is no longer defined... probably several other rk3399 systems are similarly affected? Maybe other rockchip systems as well? Reverting the patch fixes booting on the pinebook-pro-rk3399, at least. It seems that rockpro64-rk3399 was used as an example, so that presumably works, but in actuality, this commit only modifies common files for many rockchip and rk3399 boards and nothing rockpro64-rk3399 specific, so the commit message is a bit misleading. I am not sure what the best way forward is; to quickly convert all the other boards in a new patch series, or incrementally shift one system at a time over (and somehow restore previous behavior in the meantime?)... as it stands it appears we are left with rk3399 boards partially converted but broken... FWIW, I have not confirmed for sure that other boards are broken, so it might just be pinebook-pro-rk3399 for some reason. I have a few rk3399 based boards I can test to confirm... live well, vagrant > include/configs/rk3399_common.h | 5 +---- > include/configs/rockchip-common.h | 2 ++ > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_com= mon.h > index 2f9aee58197..f2c231dd978 100644 > --- a/include/configs/rk3399_common.h > +++ b/include/configs/rk3399_common.h > @@ -42,15 +42,12 @@ > #define ROCKCHIP_DEVICE_SETTINGS > #endif >=20=20 > -#include > -#include > #define CONFIG_EXTRA_ENV_SETTINGS \ > ENV_MEM_LAYOUT_SETTINGS \ > "fdtfile=3D" CONFIG_DEFAULT_FDT_FILE "\0" \ > "partitions=3D" PARTS_DEFAULT \ > ROCKCHIP_DEVICE_SETTINGS \ > - BOOTENV \ > - BOOTENV_SF \ > + "boot_targets=3D" BOOT_TARGETS "\0" \ > "altbootcmd=3D" \ > "setenv boot_syslinux_conf extlinux/extlinux-rollback.conf;" \ > "run distro_bootcmd\0" > diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip= -common.h > index 4c964cc3770..5a06365c760 100644 > --- a/include/configs/rockchip-common.h > +++ b/include/configs/rockchip-common.h > @@ -67,12 +67,14 @@ > BOOT_TARGET_PXE(func) \ > BOOT_TARGET_DHCP(func) \ > BOOT_TARGET_SF(func) > +#define BOOT_TARGETS "mmc1 mmc0 nvme scsi usb pxe dhcp spi" > #else > #define BOOT_TARGET_DEVICES(func) \ > BOOT_TARGET_MMC(func) \ > BOOT_TARGET_USB(func) \ > BOOT_TARGET_PXE(func) \ > BOOT_TARGET_DHCP(func) > +#define BOOT_TARGETS "mmc1 mmc0 usb pxe dhcp" > #endif >=20=20 > #ifdef CONFIG_ARM64 > --=20 > 2.39.0.rc0.267.gcb52ba06e7-goog --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY/GHKgAKCRDcUY/If5cW qtE9AQDNlB3BWjmBghs7py/KS25kn8iZRJ2JW0A11XZ3KXUlvwD8DIKEmqukcYUI jjefGW2Do/5tkelJzL8Pmfz/cGjNNgo= =3pkN -----END PGP SIGNATURE----- --=-=-=--