public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] qemu-riscv64_smode, sifive-fu540: fix extlinux (define preboot)
Date: Wed, 25 Sep 2019 18:54:19 -0700	[thread overview]
Message-ID: <87r243g6us.fsf@yucca> (raw)
In-Reply-To: <20190821190720.4286-1-david.abdurachmanov@sifive.com>

On 2019-08-21, David Abdurachmanov wrote:
> Commit 37304aaf60bf92a5dc3ef222ba520698bd862a44 removed preboot
> commands in RISC-V targets and broke extlinux support as reported
> by Fu Wei <wefu@redhat.com>.
>
> The patch finishes migration of CONFIG_USE_PREBOOT and CONFIG_REBOOT
> to Kconfig.

Tested using qemu-riscv64_smode and it fixes extlinux booting. Thanks!

Please CC me on future updates to the patch series.

Tested-by: Vagrant Cascadian <vagrant@debian.org>

live well,
  vagrant

> Signed-off-by: David Abdurachmanov <david.abdurachmanov@sifive.com>
> ---
>  configs/qemu-riscv64_smode_defconfig | 2 ++
>  configs/sifive_fu540_defconfig       | 2 ++
>  include/configs/sifive-fu540.h       | 4 ----
>  3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/configs/qemu-riscv64_smode_defconfig b/configs/qemu-riscv64_smode_defconfig
> index 74743a5ebe..2e1f7fa91f 100644
> --- a/configs/qemu-riscv64_smode_defconfig
> +++ b/configs/qemu-riscv64_smode_defconfig
> @@ -9,3 +9,5 @@ CONFIG_DISPLAY_CPUINFO=y
>  CONFIG_DISPLAY_BOARDINFO=y
>  # CONFIG_CMD_MII is not set
>  CONFIG_OF_PRIOR_STAGE=y
> +CONFIG_USE_PREBOOT=y
> +CONFIG_PREBOOT="setenv fdt_addr ${fdtcontroladdr}; fdt addr ${fdtcontroladdr};"
> diff --git a/configs/sifive_fu540_defconfig b/configs/sifive_fu540_defconfig
> index 48865e5f11..a852579309 100644
> --- a/configs/sifive_fu540_defconfig
> +++ b/configs/sifive_fu540_defconfig
> @@ -9,3 +9,5 @@ CONFIG_MISC_INIT_R=y
>  CONFIG_DISPLAY_CPUINFO=y
>  CONFIG_DISPLAY_BOARDINFO=y
>  CONFIG_OF_PRIOR_STAGE=y
> +CONFIG_USE_PREBOOT=y
> +CONFIG_PREBOOT="setenv fdt_addr ${fdtcontroladdr}; fdt addr ${fdtcontroladdr};"
> diff --git a/include/configs/sifive-fu540.h b/include/configs/sifive-fu540.h
> index 858b7a7da1..ba4aa0652c 100644
> --- a/include/configs/sifive-fu540.h
> +++ b/include/configs/sifive-fu540.h
> @@ -40,8 +40,4 @@
>  	"ramdisk_addr_r=0x88300000\0" \
>  	BOOTENV
>  
> -#define CONFIG_PREBOOT \
> -	"setenv fdt_addr ${fdtcontroladdr};" \
> -	"fdt addr ${fdtcontroladdr};"
> -
>  #endif /* __CONFIG_H */
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190925/74669c55/attachment.sig>

  parent reply	other threads:[~2019-09-26  1:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21 19:07 [U-Boot] [PATCH] qemu-riscv64_smode, sifive-fu540: fix extlinux (define preboot) David Abdurachmanov
2019-08-26 12:42 ` Bin Meng
2019-08-26 18:00   ` David Abdurachmanov
2019-08-29  1:57 ` Atish Patra
2019-09-26  1:54 ` Vagrant Cascadian [this message]
2019-12-18  1:05   ` Vagrant Cascadian
2019-12-18  9:00     ` David Abdurachmanov
2019-12-18 15:11       ` Vagrant Cascadian
2019-12-19  5:42         ` David Abdurachmanov
2020-02-04 15:29           ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r243g6us.fsf@yucca \
    --to=vagrant@debian.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox