From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] armv8/fsl-layerscape: add dwc3 gadget driver support
Date: Wed, 01 Jun 2016 09:37:06 +0300 [thread overview]
Message-ID: <87r3chl8j1.fsf@linux.intel.com> (raw)
In-Reply-To: <HE1PR0401MB202805223D37602C32AA115DE3470@HE1PR0401MB2028.eurprd04.prod.outlook.com>
Hi,
Rajesh Bhagat <rajesh.bhagat@nxp.com> writes:
>> Marek Vasut <marex@denx.de> writes:
>> >> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index
>> >> 85cc96a..5eeb71d 100644
>> >> --- a/drivers/usb/dwc3/core.c
>> >> +++ b/drivers/usb/dwc3/core.c
>> >> @@ -690,6 +690,18 @@ int dwc3_uboot_init(struct dwc3_device *dwc3_dev)
>> >> return -ENOMEM;
>> >> }
>> >>
>> >> +#if defined(CONFIG_LS1043A)
>> >
>> > How was this added in Linux ? I doubt such horrid ifdef was allowed.
>> > I presume it went through either DT or struct dwc3_device, right ?
>> > So fix this here the same way.
>>
>> dwc3 doesn't have any of that. I wouldn't take it :-p
>>
>
> Hello Felipe/Marek,
>
> It is not currently added in Linux, These registers setting is required for
> Setting the burst beat transactions and enabling the snooping for DWC3 USB IP.
that's fine, but you don't need to ifdef around that. Pass these values
from your platform code.
> Can it be added using dwc3 uboot glue layer e.g. dwc3-fsl.c ?
keep in core, but pass them from plat code instead of hardcoding under ifdef.
Also, get rid of the magic constant ;-)
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160601/53441d1c/attachment.sig>
next prev parent reply other threads:[~2016-06-01 6:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 11:32 [U-Boot] [PATCH 0/3] armv8/fsl-layerscape: add dwc3 gadget driver support Rajat Srivastava
2016-05-31 11:32 ` [U-Boot] [PATCH 1/3] usb: ums: support multiple controllers using controller_index Rajat Srivastava
2016-05-31 14:51 ` Lukasz Majewski
2016-06-01 4:03 ` Rajesh Bhagat
2016-05-31 11:32 ` [U-Boot] [PATCH 2/3] armv8/fsl-layerscape: add dwc3 gadget driver support Rajat Srivastava
2016-05-31 12:04 ` Marek Vasut
2016-05-31 12:10 ` Felipe Balbi
2016-06-01 4:08 ` Rajesh Bhagat
2016-06-01 6:37 ` Felipe Balbi [this message]
2016-06-01 7:07 ` Rajesh Bhagat
2016-05-31 14:55 ` Lukasz Majewski
2016-05-31 11:32 ` [U-Boot] [PATCH 3/3] armv8/fsl-layerscape: enable " Rajat Srivastava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3chl8j1.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox