From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B088AEB64D7 for ; Wed, 21 Jun 2023 14:16:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3EC3E846FB; Wed, 21 Jun 2023 16:15:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="TyT4wTTP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7A01686354; Wed, 21 Jun 2023 16:15:57 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4AF548468A for ; Wed, 21 Jun 2023 16:15:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=maz@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 26961612B7; Wed, 21 Jun 2023 14:15:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 705C8C43391; Wed, 21 Jun 2023 14:15:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687356950; bh=2YbU4j8Mn6cegWpzV1McgTDuUlVaQSvxKGpFk2W3B/o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TyT4wTTPclddbUYbPutEKLXbroiifxs9fhy/y6c2Ko9gPY1PgSOtPyxq/fj6AZSwU NZTeCfs+rK+qKScc95+ihKoatesDKN7ZGGPLyeeWZoMTG/Xe8OLUjywen6oSbtiGVg /YZFa2V9PQhhvJjfPGT+2X5HRjt4SqfqBThZMQQUyTtUYv+FegfjubQcsxAKBGPMRT EKThIcId+Nrtmm8huuMLNJ4vMjmBd1zYO7jemxDO0BGUT02a59htMh4sOSlvooMsuc zYR07vWcXG83Z9menDa2XStTRX2HdMGy/0CZANiJTWKCmqv0ZXeKacOjHifTKn2clM 122ig4g+1qzHw== Received: from [104.132.96.110] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qBycd-007AFh-AQ; Wed, 21 Jun 2023 15:15:47 +0100 Date: Wed, 21 Jun 2023 15:15:44 +0100 Message-ID: <87sfakq4tr.wl-maz@kernel.org> From: Marc Zyngier To: Jit Loon Lim Cc: u-boot@lists.denx.de, Jagan Teki , Marek , Simon , Tien Fong , Kok Kiang , Raaj , Dinesh , Boon Khai , Alif , Teik Heng , Hazim , Sieu Mun Tang , Ying-Chun Liu , Kah Jing Lee Subject: Re: [PATCH v1] cache_v8: agilex5: Disable Dcache in the SPL In-Reply-To: <20230621140651.12756-1-jit.loon.lim@intel.com> References: <20230621140651.12756-1-jit.loon.lim@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 104.132.96.110 X-SA-Exim-Rcpt-To: jit.loon.lim@intel.com, u-boot@lists.denx.de, jagan@amarulasolutions.com, marex@denx.de, simon.k.r.goldschmidt@gmail.com, tien.fong.chee@intel.com, kok.kiang.hea@intel.com, raaj.lokanathan@intel.com, dinesh.maniyam@intel.com, boon.khai.ng@intel.com, alif.zakuan.yuslaimi@intel.com, teik.heng.chong@intel.com, muhammad.hazim.izzat.zamri@intel.com, sieu.mun.tang@intel.com, paul.liu@linaro.org, kah.jing.lee@intel.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Wed, 21 Jun 2023 15:06:51 +0100, Jit Loon Lim wrote: > > From: Kah Jing Lee > > Dcache feature is not enabled in SPL and enable it will cause ISR > exception. Since the Dcache is not supported in SPL, new > CONFIG_SPL_SYS_DISABLE_DCACHE_OPS is added to Kconfig to disable Dcache > in SPL. > > Signed-off-by: Kah Jing Lee This is missing your own SoB. Now, I'd like to understand what you are actually trying to fix. What is this 'ISR' exception? This isn't something the architecture describes. Unless you are using CMOs on something that isn't memory or for which you don't have a mapping, this should never generate an exception. Thanks, M. -- Without deviation from the norm, progress is not possible.