From: Vagrant Cascadian <vagrant@debian.org>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
U-Boot Custodians <u-boot-custodians@lists.denx.de>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Johan Jonker <jbx6244@gmail.com>,
Kever Yang <kever.yang@rock-chips.com>,
Peng Fan <peng.fan@nxp.com>,
Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
huang lin <hl@rock-chips.com>
Subject: Re: rk3399 boards broken, only partially converted to standard boot? (was Re: [PATCH 71/71] rockchip: Convert rockpro64-rk3399 to use standard boot)
Date: Tue, 21 Feb 2023 12:32:23 -0800 [thread overview]
Message-ID: <87sfeypxns.fsf@yucca> (raw)
In-Reply-To: <CAPnjgZ0cvqxA_zEDExhwXYsyJDjVcY-LXENFpmErhRMg80+5Mw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2168 bytes --]
On 2023-02-20, Simon Glass wrote:
> On Sat, 18 Feb 2023 at 19:19, Vagrant Cascadian <vagrant@debian.org> wrote:
>> On 2022-12-07, Simon Glass wrote:
>> > Drop the use of scripts and rely on standard boot for all operation.
>>
>> This patch, applied as 3891c68ef50eda38d78c95ecd03aed030aa6bb53 broke
>> booting on pinebook-pro-rk3399, which still tries to "run
>> distro_bootcmd" but distro_bootcmd is no longer defined... probably
>> several other rk3399 systems are similarly affected? Maybe other
>> rockchip systems as well? Reverting the patch fixes booting on the
>> pinebook-pro-rk3399, at least.
>>
>> It seems that rockpro64-rk3399 was used as an example, so that
>> presumably works, but in actuality, this commit only modifies common
>> files for many rockchip and rk3399 boards and nothing rockpro64-rk3399
>> specific, so the commit message is a bit misleading.
>>
>> I am not sure what the best way forward is; to quickly convert all the
>> other boards in a new patch series, or incrementally shift one system at
>> a time over (and somehow restore previous behavior in the
>> meantime?)... as it stands it appears we are left with rk3399 boards
>> partially converted but broken...
>>
>> FWIW, I have not confirmed for sure that other boards are broken, so it
>> might just be pinebook-pro-rk3399 for some reason. I have a few rk3399
>> based boards I can test to confirm...
>
> I suspect it needs BOOTSTD_DEFAULTS enabled. Could you try that? I can
> send a patch if you like?
I added CONFIG_BOOTSTD_DEFAULTS=y to
configs/pinebook-pro-rk3399_defconfig but it still had the same issue...
bootcmd does not get updated to use bootstd instead of distro_bootcmd
... and distro_bootcmd is not defined, so it fails to boot! At least it
gets as far as a u-boot prompt!
As mentioned on irc, I wasn't able to get rockpro64-rk3399 to boot at
all (hanging at SPL), so cannot test if it also needs further changes
for BOOTSTD to work... and for good measure, rock64-rk3328 also fails in
the same way.
I also have puma-rk3399, firefly-rk3399 and firefly-rk3288 to
test... though might wait on some of those till the dust settles a
bit...
live well,
vagrant
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2023-02-21 20:37 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 8:50 [PATCH 00/71] bootstd: Allow migration from distro_bootcmd scripts Simon Glass
2022-12-07 8:50 ` [PATCH 01/71] dm: core: Correct ordering of uclasses IDs Simon Glass
2022-12-07 8:50 ` [PATCH 02/71] dm: core: Support sorting devices with dm tree Simon Glass
2022-12-07 8:50 ` [PATCH 03/71] dm: test: Correct assertion in dm_test_part() Simon Glass
2022-12-07 8:50 ` [PATCH 04/71] lib: Add a function to split a string into substrings Simon Glass
2022-12-07 8:50 ` [PATCH 05/71] bootstd: Remove special-case code for boot_targets Simon Glass
2022-12-07 8:50 ` [PATCH 06/71] bootstd: Simplify locating existing bootdevs Simon Glass
2022-12-07 8:50 ` [PATCH 07/71] test: Fix the help for the ut command Simon Glass
2022-12-07 8:50 ` [PATCH 08/71] test: Drop duplicate restore of DM state Simon Glass
2022-12-07 8:50 ` [PATCH 09/71] sandbox: mmc: Start off with a zeroed file Simon Glass
2022-12-07 8:50 ` [PATCH 10/71] vbe: Avoid a build failure when bloblist is not enabled Simon Glass
2022-12-07 8:50 ` [PATCH 11/71] vbe: sandbox: Drop VBE node in chosen Simon Glass
2022-12-07 8:50 ` [PATCH 12/71] dm: part: Update test to use mmc2 Simon Glass
2022-12-07 8:50 ` [PATCH 13/71] dm: test: Correct ordering of DM setup Simon Glass
2022-12-07 8:50 ` [PATCH 14/71] ide: Drop non-DM code for BLK Simon Glass
2022-12-07 8:50 ` [PATCH 15/71] dm: mmc: Use bootdev_setup_sibling_blk() Simon Glass
2022-12-07 8:50 ` [PATCH 16/71] bootstd: Add a default method to get bootflows Simon Glass
2022-12-07 8:50 ` [PATCH 17/71] sandbox: Allow ethernet to be disabled at runtime Simon Glass
2022-12-07 8:50 ` [PATCH 18/71] sandbox: Allow ethernet bootdevs to be disabled for tests Simon Glass
2022-12-07 8:50 ` [PATCH 19/71] sandbox: Enable the Ethernet bootdev Simon Glass
2022-12-07 8:50 ` [PATCH 20/71] lib: Support printing an error string Simon Glass
2022-12-07 8:50 ` [PATCH 21/71] event: Correct duplicate log message in event_notify() Simon Glass
2022-12-07 8:50 ` [PATCH 22/71] efi: Improve logging in efi_disk Simon Glass
2022-12-07 8:50 ` [PATCH 23/71] bootstd: Add the concept of a bootdev hunter Simon Glass
2022-12-07 8:50 ` [PATCH 24/71] bootstd: Support running bootdev hunters Simon Glass
2022-12-07 8:50 ` [PATCH 25/71] dm: usb: Drop some dead code Simon Glass
2022-12-07 8:50 ` [PATCH 26/71] dm: usb: Mark the device name as alloced when binding Simon Glass
2022-12-07 8:50 ` [PATCH 27/71] test: Add a generic function to skip delays Simon Glass
2022-12-07 8:50 ` [PATCH 28/71] bootstd: Add a USB hunter Simon Glass
2022-12-07 8:50 ` [PATCH 29/71] bootstd: Add an MMC hunter Simon Glass
2022-12-07 8:50 ` [PATCH 30/71] net: Add a function to run dhcp Simon Glass
2022-12-07 8:50 ` [PATCH 31/71] bootstd: Add a hunter for ethernet Simon Glass
2022-12-07 8:50 ` [PATCH 32/71] part: Add a function to find the first bootable partition Simon Glass
2022-12-07 8:50 ` [PATCH 33/71] bootstd: Only scan bootable partitions Simon Glass
2022-12-07 8:51 ` [PATCH 34/71] scsi: Correct allocation of block-device name Simon Glass
2022-12-07 8:51 ` [PATCH 35/71] scsi: Remove all children of SCSI devices before rescanning Simon Glass
2022-12-07 8:51 ` [PATCH 36/71] bootstd: Add a SCSI bootdev Simon Glass
2022-12-07 8:51 ` [PATCH 37/71] bootstd: Add an IDE bootdev Simon Glass
2022-12-07 8:51 ` [PATCH 38/71] bootstd: Add an NVMe bootdev Simon Glass
2022-12-07 8:51 ` [PATCH 39/71] virtio: Avoid repeating a long expression Simon Glass
2022-12-07 8:51 ` [PATCH 40/71] virtio: Fix returning -ENODEV Simon Glass
2022-12-07 8:51 ` [PATCH 41/71] virtio: Avoid strange behaviour on removal Simon Glass
2022-12-07 8:51 ` [PATCH 42/71] virtio: Add a block device Simon Glass
2022-12-07 8:51 ` [PATCH 43/71] bootstd: Add a virtio bootdev Simon Glass
2022-12-07 8:51 ` [PATCH 44/71] ata: Don't try to use non-existent ports Simon Glass
2022-12-07 8:51 ` [PATCH 45/71] bootstd: Rename bootdev checkers Simon Glass
2022-12-07 8:51 ` [PATCH 46/71] bootstd: Allow reading an EFI file from the network Simon Glass
2022-12-07 8:51 ` [PATCH 47/71] bootstd: Include the device tree in the bootflow Simon Glass
2022-12-07 8:51 ` [PATCH 48/71] bootstd: Support reading the device tree with EFI Simon Glass
2022-12-07 8:51 ` [PATCH 49/71] bootstd: Set the distro_bootpart env var with scripts Simon Glass
2022-12-07 8:51 ` [PATCH 50/71] bootstd: Update docs on bootmeth_try_file() for sandbox Simon Glass
2022-12-07 8:51 ` [PATCH 51/71] bootstd: Move label parsing into its own function Simon Glass
2022-12-07 8:51 ` [PATCH 52/71] bootstd: Add a new bootmeth method to set the bootflow Simon Glass
2022-12-07 8:51 ` [PATCH 53/71] sandbox: Allow SPI flash bootdevs to be disabled for tests Simon Glass
2022-12-07 8:51 ` [PATCH 54/71] bootstd: Add a SPI flash bootdev Simon Glass
2022-12-07 8:51 ` [PATCH 55/71] bootstd: Support reading a script from network or SPI flash Simon Glass
2022-12-07 8:51 ` [PATCH 56/71] bootstd: Treat DHCP and PXE as bootdev labels Simon Glass
2022-12-07 8:51 ` [PATCH 57/71] bootstd: Use hunters when scanning for bootflows Simon Glass
2022-12-07 8:51 ` [PATCH 58/71] bootstd: Allow hunting for bootdevs of a given priority Simon Glass
2022-12-07 8:51 ` [PATCH 59/71] bootstd: Add a new pre-scan priority for bootdevs Simon Glass
2022-12-07 8:51 ` [PATCH 60/71] bootstd: Allow hunting for a bootdev by label Simon Glass
2022-12-07 8:51 ` [PATCH 61/71] bootstd: Allow iterating to the next label in a list Simon Glass
2022-12-07 8:51 ` [PATCH 62/71] bootstd: Allow iterating to the next bootdev priortiy Simon Glass
2022-12-07 8:51 ` [PATCH 63/71] extension: Refactor to allow non-command usage Simon Glass
2022-12-07 8:51 ` [PATCH 64/71] bootstd: Add a hunter for the extension feature Simon Glass
2022-12-07 8:51 ` [PATCH 65/71] bootstd: Switch bootdev scanning to use labels Simon Glass
2022-12-07 8:51 ` [PATCH 66/71] bootstd: Allow scanning a single bootdev label Simon Glass
2022-12-07 8:51 ` [PATCH 67/71] bootstd: Drop the old bootflow_scan_first() Simon Glass
2022-12-07 8:51 ` [PATCH 68/71] bootstd: Record the bootdevs used during scanning Simon Glass
2022-12-07 8:51 ` [PATCH 69/71] bootstd: Add a little more logging of bootflows Simon Glass
2022-12-07 8:51 ` [PATCH 70/71] bootstd: Update documentation for new features Simon Glass
2022-12-07 8:51 ` [PATCH 71/71] rockchip: Convert rockpro64-rk3399 to use standard boot Simon Glass
2023-02-19 2:19 ` rk3399 boards broken, only partially converted to standard boot? (was Re: [PATCH 71/71] rockchip: Convert rockpro64-rk3399 to use standard boot) Vagrant Cascadian
2023-02-20 16:21 ` Simon Glass
2023-02-21 19:35 ` Simon Glass
2023-02-21 20:32 ` Vagrant Cascadian [this message]
2023-02-21 20:37 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfeypxns.fsf@yucca \
--to=vagrant@debian.org \
--cc=hl@rock-chips.com \
--cc=jbx6244@gmail.com \
--cc=jeffy.chen@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=peng.fan@nxp.com \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot-custodians@lists.denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox