From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12FCAC636D7 for ; Tue, 21 Feb 2023 20:37:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EA84F85B5E; Tue, 21 Feb 2023 21:33:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=debian.org header.i=@debian.org header.b="dewJfZsX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 65A3E85B10; Tue, 21 Feb 2023 21:32:53 +0100 (CET) Received: from cascadia.aikidev.net (cascadia.aikidev.net [IPv6:2600:3c01:e000:267:0:a171:de7:c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 555D685A88; Tue, 21 Feb 2023 21:32:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=vagrant@debian.org Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:40]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 6E7BB1AB8C; Tue, 21 Feb 2023 12:32:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1677011567; bh=UmNy1KwoBCXkKjNHeRxnh5Cd4VGiolB/Q2AdS9FVNVY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=dewJfZsXu+UrhSENCgxf6fGFJ+ebMiFvDWJVfafpDai0xFXMrOc6G695El9wlHVEx vrph+zC/q9apUrbGaE1KL8l4J7pBfzEzPiux8PkRz5eBZGlBx9vwx+lkuKDcQYa5Cw XZ4vVhXbFqHoPTFypMvtDXyyPKFpa03luIJfeXCUBL9c7PGrDh6j/r6NwopJNdDyeV RXh1zFvmGW1YitDguM/9C4JdBLrElKumnPBDqGTdqXDAvhO4YhYetOK/r1H8J3J1dy DzUBhDyChjP0wft8zVla8VCtMVp7B8tE/5RcASXdt7N0581bGTEM4QEBduJBwkrRCu iz//3LzNsApmA== From: Vagrant Cascadian To: Simon Glass Cc: U-Boot Mailing List , U-Boot Custodians , Jeffy Chen , Johan Jonker , Kever Yang , Peng Fan , Philipp Tomsich , Philipp Tomsich , huang lin Subject: Re: rk3399 boards broken, only partially converted to standard boot? (was Re: [PATCH 71/71] rockchip: Convert rockpro64-rk3399 to use standard boot) In-Reply-To: References: <20221207085137.445249-1-sjg@chromium.org> <20221207085137.445249-72-sjg@chromium.org> <87r0um9z2t.fsf@contorta> Date: Tue, 21 Feb 2023 12:32:23 -0800 Message-ID: <87sfeypxns.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --=-=-= Content-Type: text/plain On 2023-02-20, Simon Glass wrote: > On Sat, 18 Feb 2023 at 19:19, Vagrant Cascadian wrote: >> On 2022-12-07, Simon Glass wrote: >> > Drop the use of scripts and rely on standard boot for all operation. >> >> This patch, applied as 3891c68ef50eda38d78c95ecd03aed030aa6bb53 broke >> booting on pinebook-pro-rk3399, which still tries to "run >> distro_bootcmd" but distro_bootcmd is no longer defined... probably >> several other rk3399 systems are similarly affected? Maybe other >> rockchip systems as well? Reverting the patch fixes booting on the >> pinebook-pro-rk3399, at least. >> >> It seems that rockpro64-rk3399 was used as an example, so that >> presumably works, but in actuality, this commit only modifies common >> files for many rockchip and rk3399 boards and nothing rockpro64-rk3399 >> specific, so the commit message is a bit misleading. >> >> I am not sure what the best way forward is; to quickly convert all the >> other boards in a new patch series, or incrementally shift one system at >> a time over (and somehow restore previous behavior in the >> meantime?)... as it stands it appears we are left with rk3399 boards >> partially converted but broken... >> >> FWIW, I have not confirmed for sure that other boards are broken, so it >> might just be pinebook-pro-rk3399 for some reason. I have a few rk3399 >> based boards I can test to confirm... > > I suspect it needs BOOTSTD_DEFAULTS enabled. Could you try that? I can > send a patch if you like? I added CONFIG_BOOTSTD_DEFAULTS=y to configs/pinebook-pro-rk3399_defconfig but it still had the same issue... bootcmd does not get updated to use bootstd instead of distro_bootcmd ... and distro_bootcmd is not defined, so it fails to boot! At least it gets as far as a u-boot prompt! As mentioned on irc, I wasn't able to get rockpro64-rk3399 to boot at all (hanging at SPL), so cannot test if it also needs further changes for BOOTSTD to work... and for good measure, rock64-rk3328 also fails in the same way. I also have puma-rk3399, firefly-rk3399 and firefly-rk3288 to test... though might wait on some of those till the dust settles a bit... live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY/UqWAAKCRDcUY/If5cW qm+/AP9sHyeSkywx5HzVFeoSJF14MCiVsB5kIk5DCQQjZv8kSwEAp3+HY9GVrXwM cngd1xqEnWFk2ObFViIGZs4asQoVews= =JF+p -----END PGP SIGNATURE----- --=-=-=--