From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Sean Anderson <seanga2@gmail.com>,
Roman Stratiienko <r.stratiienko@gmail.com>,
u-boot@lists.denx.de
Cc: sjg@chromium.org, roman.kovalivskyi@globallogic.com,
erosca@de.adit-jv.com
Subject: Re: [PATCH] fastboot: fix fastboot_set_reboot_flag()
Date: Thu, 18 Nov 2021 15:20:54 +0100 [thread overview]
Message-ID: <87sfvtee9l.fsf@baylibre.com> (raw)
In-Reply-To: <ff49da64-7ad9-d750-6f08-e2b30d5bb52f@gmail.com>
Hi Roman,
Thank you for your patch.
Sean Anderson <seanga2@gmail.com> writes:
> On 5/8/21 6:25 PM, Roman Stratiienko wrote:
>> In case CONFIG_FASTBOOT_FLASH_MMC_DEV == 0, compile-time condition
>> is not met and fastboot_set_reboot_flag() fails.
>>
>> Fixes: a362ce214f03 ("fastboot: Implement generic fastboot_set_reboot_flag")
>> Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
>> ---
>> drivers/fastboot/fb_common.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c
>> index cbcc3683c47..ef399d0c4ab 100644
>> --- a/drivers/fastboot/fb_common.c
>> +++ b/drivers/fastboot/fb_common.c
>> @@ -91,7 +91,7 @@ void fastboot_okay(const char *reason, char *response)
>> */
>> int __weak fastboot_set_reboot_flag(enum fastboot_reboot_reason reason)
>> {
>> -#if CONFIG_IS_ENABLED(FASTBOOT_FLASH_MMC_DEV)
>> +#ifdef CONFIG_FASTBOOT_FLASH_MMC_DEV
>> static const char * const boot_cmds[] = {
>> [FASTBOOT_REBOOT_REASON_BOOTLOADER] = "bootonce-bootloader",
>> [FASTBOOT_REBOOT_REASON_FASTBOOTD] = "boot-fastboot",
>>
>
> Reviewed-by: Sean Anderson <seanga2@gmail.com>
I'm using this in the (out of tree) U-Boot for khadas VIM3L/VIM3 boards:
https://gitlab.com/baylibre/amlogic/atv/u-boot/-/tree/u-boot/v2021.07/integ
Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
next prev parent reply other threads:[~2021-11-18 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 22:25 [PATCH] fastboot: fix fastboot_set_reboot_flag() Roman Stratiienko
2021-11-03 16:22 ` Sean Anderson
2021-11-18 14:20 ` Mattijs Korpershoek [this message]
2022-01-28 20:15 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfvtee9l.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=erosca@de.adit-jv.com \
--cc=r.stratiienko@gmail.com \
--cc=roman.kovalivskyi@globallogic.com \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox