From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1303C433F5 for ; Thu, 18 Nov 2021 14:21:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4756E610FB for ; Thu, 18 Nov 2021 14:21:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4756E610FB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 10AEE80F54; Thu, 18 Nov 2021 15:21:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20210112.gappssmtp.com header.i=@baylibre-com.20210112.gappssmtp.com header.b="oz5p6jgS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E775F811DE; Thu, 18 Nov 2021 15:21:00 +0100 (CET) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 62D03805DF for ; Thu, 18 Nov 2021 15:20:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mkorpershoek@baylibre.com Received: by mail-wm1-x32e.google.com with SMTP id b184-20020a1c1bc1000000b0033140bf8dd5so4922268wmb.5 for ; Thu, 18 Nov 2021 06:20:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=DIfqfRqiqEDdg9SsjEJ9ZbyB60dmuo4vZeuoSIYL/no=; b=oz5p6jgSNvY0EeDReVvVuAzikQ0ETQ8vDgbAaAND1y7bRGXp1VkyctMZ4JQ8p5tr56 e9PplWEKX5zx55aZvCMsrMdFif9syrmSX3EPlztFZ1588s+9v38GmQjKmhncybIJEhhf ei+Id4gBC8uvUbJAGbQqWR65m9BQvuNsqPsWfuQ/ivo3W/+S//DGXqc2ET5tzqjTLAJO kyi2LA6PMq3XAy1YfiFMzrYamdDIPna3inaKbEntIOOZE2JFe9PltApTYcso8wosyz0w 2H3JMgbLNRfnTJlydPuqxd14RMzdlV/2Q+j7u1jvVhKsExCSss9kgEB/SjUcIb4xcnwN 7a+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=DIfqfRqiqEDdg9SsjEJ9ZbyB60dmuo4vZeuoSIYL/no=; b=TNYVE4jcrcaYAVhnTZXKSnUm44oCJm5J/UgmhhfC0umILosm4jofyY/TTImjTMTwhJ CAEJ9GSZAVQhYE549v5hvTy5BwzttSS9iB/o1eoG0N1ZpBdZ4knCSaK03TYBqoUjEAGO 480V340VqanxWvPtXkIbHgeJh1AvX68lS7qaoNILIZs8aVG2uulROau3nfve27U5GMd7 R6EArIOmw7fSrTXM1mMn95zwFEe4Wg4qLEZFRirLQxAWsqdszftnEbfRKX234bzP9y5G +fUl/1mxbWTzylZ0ExgbgBZKTeql6FenIRsuu1HzVYhEHc6OC7ps1d9p2rSG7TOVp9LO iSPA== X-Gm-Message-State: AOAM531VKqMvgbIkI3v2RjTY2UMtqIwa+tvJplCD9anO3jYFkEPQxySy tiVTtKVpyU6KrW2lGJc4nT5kDA== X-Google-Smtp-Source: ABdhPJza9gRbjLWVxRXolq95G5b4EDrM3Tx/4gJUOhAHbpR6z9426JvASm68lqZzxAihjfjx+r7IdQ== X-Received: by 2002:a7b:c388:: with SMTP id s8mr10426086wmj.170.1637245256780; Thu, 18 Nov 2021 06:20:56 -0800 (PST) Received: from localhost ([2a01:cb19:826e:8e00:8424:912f:867a:382b]) by smtp.gmail.com with ESMTPSA id l7sm4281090wry.86.2021.11.18.06.20.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Nov 2021 06:20:56 -0800 (PST) From: Mattijs Korpershoek To: Sean Anderson , Roman Stratiienko , u-boot@lists.denx.de Cc: sjg@chromium.org, roman.kovalivskyi@globallogic.com, erosca@de.adit-jv.com Subject: Re: [PATCH] fastboot: fix fastboot_set_reboot_flag() In-Reply-To: References: <20210508222524.4511-1-r.stratiienko@gmail.com> Date: Thu, 18 Nov 2021 15:20:54 +0100 Message-ID: <87sfvtee9l.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Roman, Thank you for your patch. Sean Anderson writes: > On 5/8/21 6:25 PM, Roman Stratiienko wrote: >> In case CONFIG_FASTBOOT_FLASH_MMC_DEV == 0, compile-time condition >> is not met and fastboot_set_reboot_flag() fails. >> >> Fixes: a362ce214f03 ("fastboot: Implement generic fastboot_set_reboot_flag") >> Signed-off-by: Roman Stratiienko >> --- >> drivers/fastboot/fb_common.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c >> index cbcc3683c47..ef399d0c4ab 100644 >> --- a/drivers/fastboot/fb_common.c >> +++ b/drivers/fastboot/fb_common.c >> @@ -91,7 +91,7 @@ void fastboot_okay(const char *reason, char *response) >> */ >> int __weak fastboot_set_reboot_flag(enum fastboot_reboot_reason reason) >> { >> -#if CONFIG_IS_ENABLED(FASTBOOT_FLASH_MMC_DEV) >> +#ifdef CONFIG_FASTBOOT_FLASH_MMC_DEV >> static const char * const boot_cmds[] = { >> [FASTBOOT_REBOOT_REASON_BOOTLOADER] = "bootonce-bootloader", >> [FASTBOOT_REBOOT_REASON_FASTBOOTD] = "boot-fastboot", >> > > Reviewed-by: Sean Anderson I'm using this in the (out of tree) U-Boot for khadas VIM3L/VIM3 boards: https://gitlab.com/baylibre/amlogic/atv/u-boot/-/tree/u-boot/v2021.07/integ Tested-by: Mattijs Korpershoek