[U-Boot-Users] [PATCH] Remove duplicate #undef SHOW_INFO inside drivers\usb\usb_ohci.c

[U-Boot-Users] [PATCH] Remove duplicate #undef SHOW_INFO inside drivers\usb\usb_ohci.c

[Gururaja Hebbar K R]

Hi,
 
In drivers\usb\usb_ohci.c file, SHOW_INFO is undef at 2 locations. @line
77 and @line 112. Below patch removes them for code size savings.
 
comments welcome.
 
Thanks in advance
 
Signed-off-by: gururaja hebbar <gururajakr@sanyo.co.in>
 
--- usb_orig.c 2007-12-06 01:21:19.000000000 -0800
+++ usb_ohci.c 2008-04-02 14:06:23.937500000 -0700
@@ -109,7 +109,6 @@ static struct pci_device_id ohci_pci_ids
 #define dbg(format, arg...) do {} while(0)
 #endif /* DEBUG */
 #define err(format, arg...) printf("ERROR: " format "\n", ## arg)
-#undef SHOW_INFO
 #ifdef SHOW_INFO
 #define info(format, arg...) printf("INFO: " format "\n", ## arg)
 #else
 

Regards
Gururaja
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20080402/08ece611/attachment.htm 

[U-Boot-Users] [PATCH] Remove duplicate #undef SHOW_INFO inside drivers\usb\usb_ohci.c

[Markus Klotzbücher]

Dear Gururaja,

"Gururaja Hebbar K R" <gururajakr@sanyo.co.in> writes:

>    In drivers\usb\usb_ohci.c file, SHOW_INFO is undef at 2 locations.
>    @line 77 and @line 112. Below patch removes them for code size savings.
>
>    comments welcome.

Thank you, well spotted.

But, git-am fails for for two reasons:

1. It chokes on your HTML mail. Please send plain text. 

>    --- usb_orig.c 2007-12-06 01:21:19.000000000 -0800
>    +++ usb_ohci.c 2008-04-02 14:06:23.937500000 -0700
>    @@ -109,7 +109,6 @@ static struct pci_device_id ohci_pci_ids
>     #define dbg(format, arg...) do {} while(0)

2. Please send a real diff containing the full path. Check the section
   "Submitting Patches" in the README if unsure.

Please cleanup and resubmit.

Thanks!

Best regards

Markus Klotzbuecher

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de

[U-Boot-Users] [PATCH] Remove duplicate #undef SHOW_INFO inside drivers\usb\usb_ohci.c

[Wolfgang Denk]

In message <5BF78BCE8D9BF14A83F836BD9E3916BA0DDAF5@blrms.slti.sanyo.co.in> you wrote:
> 
> In drivers\usb\usb_ohci.c file, SHOW_INFO is undef at 2 locations. @line
> 77 and @line 112. Below patch removes them for code size savings.

Applied, thanks, but *please* provide proper patches with usable file
name information next time. I recommend to use git-format-patch to
create the patches.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
On the subject of C program indentation: "In My Egotistical  Opinion,
most  people's  C  programs  should be indented six feet downward and
covered with dirt."                               - Blair P. Houghton

[U-Boot-Users] [PATCH] Remove duplicate #undef SHOW_INFO inside drivers\usb\usb_ohci.c

[Gururaja Hebbar K R]

Hi,

Thanks and sorry for the mistake. will sure make it a point not to
repeat this.

Regards
Gururaja 

-----Original Message-----
From: wd@denx.de [mailto:wd at denx.de] 
Sent: Thursday, April 17, 2008 9:14 PM
To: Gururaja Hebbar K R
Cc: u-boot-users at lists.sourceforge.net
Subject: Re: [PATCH] Remove duplicate #undef SHOW_INFO inside
drivers\usb\usb_ohci.c

In message
<5BF78BCE8D9BF14A83F836BD9E3916BA0DDAF5@blrms.slti.sanyo.co.in> you
wrote:
> 
> In drivers\usb\usb_ohci.c file, SHOW_INFO is undef at 2 locations. 
> @line
> 77 and @line 112. Below patch removes them for code size savings.

Applied, thanks, but *please* provide proper patches with usable file
name information next time. I recommend to use git-format-patch to
create the patches.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de On
the subject of C program indentation: "In My Egotistical  Opinion, most
people's  C  programs  should be indented six feet downward and
covered with dirt."                               - Blair P. Houghton