From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?q?Markus_Klotzb=FCcher?= <mk@denx.de>
Date: Wed, 31 May 2006 12:29:50 +0200
Subject: [U-Boot-Users] USB OHCI drivers unification
In-Reply-To: <20060531092135.GB3630@enneenne.com> (Rodolfo Giometti's
 message of "Wed, 31 May 2006 11:21:35 +0200")
References: <20060530140405.GB21734@enneenne.com>
	<20060530141700.8F726353450@atlas.denx.de>
	<20060530145421.GU21995@enneenne.com> <8764jmfuu6.fsf@denx.de>
	<20060531092135.GB3630@enneenne.com>
Message-ID: <87slmqcwrl.fsf@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Rodolfo,

Rodolfo Giometti <giometti@linux.it> writes:

> On Wed, May 31, 2006 at 10:43:13AM +0200, Markus Klotzb?cher wrote:

>> I have currently adapted the monahans, the at91rm9200, and the s3c24x0
>> cpus to use the generic driver. Please note that I used the
>> cpu/arm920t/at91rm9200/usb_ohci.[hc] driver as a starting point for the
>> generic driver.
>
> File usb_ohci.h is quite the same, but usb_ohci.c has some
> differences. I decided to start from "cpu/mpc5xxx/usb_ohci.c" since it
> seemed to have a better events handling. Please, see
> submit_common_msg() at comment "NOTE: since we are not interrupt
> driven in U-Boot..." or have a look at:

Yes, the s3c24x0 also uses this, and for now I included it (see
S3C24X0_merge #define), although I'm not sure this is really
necessary. At least the TRAB board worked fine without. Let's keep it
for now.

>    diff -Ebu cpu/arm920t/at91rm9200/usb_ohci.c cpu/mpc5xxx/usb_ohci.c
>
> where you can better see the new variable "urb_finished".
>
> However my mayor changes was about substitution of m16_swap() with
> proper ohci_cpu_to_le16() (and similar) and in adding virt_to_phys()
> and phys_to_virt() functions where needed (see my last patch for
> au1x00).

I understand that the virt_to_phys() are required, but why do you need
the ohci_cpu_to_le16 macros? They seem to be the same as the m16_swap,
m32_swap macros?

>> Your patch looks fine, but would you mind resubmitting it against the
>> USB testing branch using the generic driver (drivers/usb_ohci.c) ?
>
> I'll do it ASAP.

Thanks!

Regards

Markus Klotzbuecher