Re: [PATCH 1/3] gunzip: Add ability to disable progress indicator

Mattijs Korpershoek
2026-01-29T19:21:45Z

On Thu, Jan 29, 2026 at 17:33, Marek Vasut <marek.vasut@mailbox.org> wrote:

> On 1/29/26 5:17 PM, Mattijs Korpershoek wrote:
>
> Hi,
>
>> +++ b/lib/gunzip.c
>> @@ -8,6 +8,7 @@
>> #include <command.h>
>> #include <console.h>
>> #include <div64.h>
>> +#include <env.h>
>> #include <gzip.h>
>> #include <image.h>
>> #include <malloc.h>
>
> This is part of
>
> gunzip: Implement chunked decompression
>
> so clearly I should move that part here already.
>
>> Maybe this should be included conditionally depending on the command
>> being enabled or not?
> Why conditionally ?

Tom seems to have chimed in already but code size was one of them.
Other reason was that it seems weird to have library code (that should
not have too many dependencies) depend on environment (which is
optional).
Especially if it's just for test cases.

I see from the thread that this will be dropped for v2 so no longer need
to debate about this :)