Re: [PATCH 1/3] gunzip: Add ability to disable progress indicator

Tom Rini
2026-01-29T17:16:25Z

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

On Thu, Jan 29, 2026 at 05:57:47PM +0100, Marek Vasut wrote:
> On 1/29/26 5:53 PM, Tom Rini wrote:
> > On Thu, Jan 29, 2026 at 05:33:45PM +0100, Marek Vasut wrote:
> > > On 1/29/26 5:17 PM, Mattijs Korpershoek wrote:
> > >
> > > Hi,
> > >
> > > > +++ b/lib/gunzip.c
> > > > @@ -8,6 +8,7 @@
> > > > #include <command.h>
> > > > #include <console.h>
> > > > #include <div64.h>
> > > > +#include <env.h>
> > > > #include <gzip.h>
> > > > #include <image.h>
> > > > #include <malloc.h>
> > >
> > > This is part of
> > >
> > > gunzip: Implement chunked decompression
> > >
> > > so clearly I should move that part here already.
> > >
> > > > Maybe this should be included conditionally depending on the command
> > > > being enabled or not?
> > > Why conditionally ?
> >
> > A good general question I had is, what's the overall size impact of
> > these features?
> A more general question is, can we do without this patch. I think yes, but I
> didn't find a way to make the test pass without inhibiting this odd
> self-rewriting progress line. Is there a way to ignore output until specific
> line shows up or something along those lines ?

I believe so, but I don't recall off-hand.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]