U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Tom Rini <trini@konsulko.com>,  Simon Glass <sjg@chromium.org>,
	 Jaehoon Chung <jh80.chung@samsung.com>,
	 Lukasz Majewski <lukma@denx.de>,
	 Sean Anderson <seanga2@gmail.com>,
	 Anatolij Gustschin <agust@denx.de>,
	 Fabio Estevm <festevam@gmail.com>,  Peng Fan <peng.fan@nxp.com>,
	 Mario Six <mario.six@gdsys.cc>,
	 Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	u-boot@lists.denx.de,  Ian Ray <ian.ray@gehealthcare.com>,
	 Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	 Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	 Adam Ford <aford173@gmail.com>, Marek Vasut <marex@denx.de>
Subject: Re: [PATCH v5 01/12] core: ofnode: Fix a comment
Date: Wed, 26 Mar 2025 17:47:19 +0100	[thread overview]
Message-ID: <87tt7foi20.fsf@bootlin.com> (raw)
In-Reply-To: <CAPVz0n0hZCXEEwrE=22SV_c-L9=7GfL1B=sCrY-6cddEQuTESg@mail.gmail.com> (Svyatoslav Ryhel's message of "Wed, 26 Mar 2025 18:31:02 +0200")

Hello,

On 26/03/2025 at 18:31:02 +02, Svyatoslav Ryhel <clamor95@gmail.com> wrote:

> ср, 26 бер. 2025 р. о 17:01 Miquel Raynal <miquel.raynal@bootlin.com> пише:
>>
>> Naming between the parameter list, the prototype and the main comment do
>> not match. Fix the comment which seems the be the one that is incorrect.
>>
>> Fixes: 9057077cf4e1 ("core: ofnode: add of_graph parsing helpers")
>> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>> ---
>>  drivers/core/ofnode_graph.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> If you will be rebasing it once more, adjust please commit title to
> "core: ofnode_graph: ..." since this commit targets existing
> ofnode_graph.c file. Thank you.
>
> That is not mandatory if the rest of your patches are accepted.

There will be one, I'll fix it.

> Reviewed-by: Svyatoslav Ryhel <clamor95@gmail.com>

Thanks,
Miquèl

  reply	other threads:[~2025-03-27  4:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-26 15:00 [PATCH v5 00/12] Add imx8mp video support Miquel Raynal
2025-03-26 15:00 ` [PATCH v5 01/12] core: ofnode: Fix a comment Miquel Raynal
2025-03-26 16:31   ` Svyatoslav Ryhel
2025-03-26 16:47     ` Miquel Raynal [this message]
2025-03-26 15:00 ` [PATCH v5 02/12] dm: doc: Fix example Miquel Raynal
2025-03-26 15:00 ` [PATCH v5 03/12] dm: core: Add a helper to retrieve devices through graph endpoints Miquel Raynal
2025-03-26 16:47   ` Svyatoslav Ryhel
2025-04-03  7:45     ` Miquel Raynal
2025-03-26 15:00 ` [PATCH v5 04/12] test: dm: test-fdt: Add checks for uclass_get_device_by_endpoint() Miquel Raynal
2025-03-26 15:00 ` [PATCH v5 05/12] power-domain: Add refcounting Miquel Raynal
2025-03-26 15:00 ` [PATCH v5 06/12] clk: Ensure the parent clocks are enabled while reparenting Miquel Raynal
2025-03-26 15:00 ` [PATCH v5 07/12] clk: imx8mp: Add media related clocks Miquel Raynal
2025-03-26 15:39   ` Adam Ford
2025-03-26 15:48     ` Miquel Raynal
2025-03-26 15:00 ` [PATCH v5 08/12] imx: power-domain: Describe the i.MX8 MEDIAMIX domain Miquel Raynal
2025-03-26 15:00 ` [PATCH v5 09/12] imx: power-domain: Add support for the MEDIAMIX control block Miquel Raynal
2025-03-26 15:00 ` [PATCH v5 10/12] video: imx: Fix Makefile in order to be able to add other imx drivers Miquel Raynal
2025-03-26 15:00 ` [PATCH v5 11/12] video: imx: Add LDB driver Miquel Raynal
2025-03-26 15:00 ` [PATCH v5 12/12] video: imx: Add LCDIF driver Miquel Raynal
2025-03-26 15:22 ` [PATCH v5 00/12] Add imx8mp video support Miquel Raynal
2025-03-28 13:59   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tt7foi20.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=aford173@gmail.com \
    --cc=agust@denx.de \
    --cc=clamor95@gmail.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=festevam@gmail.com \
    --cc=ian.ray@gehealthcare.com \
    --cc=jh80.chung@samsung.com \
    --cc=lukma@denx.de \
    --cc=marex@denx.de \
    --cc=mario.six@gdsys.cc \
    --cc=michael@amarulasolutions.com \
    --cc=peng.fan@nxp.com \
    --cc=seanga2@gmail.com \
    --cc=sjg@chromium.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox