U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tobias Waldekranz <tobias@waldekranz.com>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Sughosh Ganu <sughosh.ganu@linaro.org>
Cc: u-boot@lists.denx.de, Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>,
	Anton Antonov <Anton.Antonov@arm.com>,
	Bin Meng <bmeng@tinylab.org>
Subject: Re: [PATCH v3 0/5] Add pmem node for preserving distro ISO's
Date: Fri, 24 Jan 2025 22:19:50 +0100	[thread overview]
Message-ID: <87tt9n6hah.fsf@waldekranz.com> (raw)
In-Reply-To: <CAC_iWjJtjNE0-VJJT1+aCoaADDNYyy-niZSizo-Sn6898ArLHg@mail.gmail.com>

On fre, jan 24, 2025 at 13:39, Ilias Apalodimas <ilias.apalodimas@linaro.org> wrote:
> Heinrich, Tobias
>
> There's a slight problem that I forgot when commenting v2.
>
> Heinrich's idea of plugging this into blkmap is eventually the right
> thing to do.
>
> However, when I started coding this I only added the pmem memory as
> 'reserved' in the DT hoping that would work.
> Unfortunately, this depends on a kernel config option. I've managed to
> track down the problem here[0], but I haven't found time to test it
> properly and send it upstream.
> So for this feature to work reliably we *need* to remove the memory
> map we hand over to the OS.
>
> Since using EFI memmap function into the blkmap code makes no sense,
> can we perhaps merge v2 (or a variant of it), which only targets EFI,
> with an explanation of *why* while I try to sort out the kernel issue?

I was not a part of the first two iterations of this series, but my view
is basically this:

Adding some flag to memory backed slices of block maps, that the
fdt-fixup code can use to know whether a pmem node should be injected or
not, is completely fine by me.

What I am opposed to is adding restrictions on how block maps can be
composed, i.e., limiting a block map to only contain either linear or
memory mappings.

  parent reply	other threads:[~2025-01-24 21:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-20 10:50 [PATCH v3 0/5] Add pmem node for preserving distro ISO's Sughosh Ganu
2025-01-20 10:50 ` [PATCH v3 1/5] fdt: add support for adding pmem nodes Sughosh Ganu
2025-01-20 12:31   ` Heinrich Schuchardt
2025-01-20 14:02     ` Sughosh Ganu
2025-01-24 10:56       ` Sughosh Ganu
2025-01-20 10:50 ` [PATCH v3 2/5] efi_loader: add a function to remove memory from the EFI map Sughosh Ganu
2025-01-20 12:36   ` Heinrich Schuchardt
2025-01-20 10:50 ` [PATCH v3 3/5] efi_loader: preserve installer images in pmem Sughosh Ganu
2025-01-20 10:50 ` [PATCH v3 4/5] blkmap: store type of blkmap device in corresponding structure Sughosh Ganu
2025-01-20 12:25   ` Tobias Waldekranz
2025-01-20 14:00     ` Sughosh Ganu
2025-01-20 14:36       ` Tobias Waldekranz
2025-01-20 15:40         ` Sughosh Ganu
2025-01-20 16:20           ` Tobias Waldekranz
2025-01-20 19:25             ` Sughosh Ganu
2025-01-20 21:36               ` Tobias Waldekranz
2025-01-21  6:43                 ` Sughosh Ganu
2025-01-21 15:54   ` Ilias Apalodimas
2025-01-21 16:02     ` Sughosh Ganu
2025-01-21 21:47       ` Ilias Apalodimas
2025-01-22  6:38         ` Sughosh Ganu
2025-01-20 10:50 ` [PATCH v3 5/5] blkmap: add pmem nodes for blkmap mem mapping devices Sughosh Ganu
2025-01-24 11:39 ` [PATCH v3 0/5] Add pmem node for preserving distro ISO's Ilias Apalodimas
2025-01-24 19:18   ` Tom Rini
2025-01-24 21:19   ` Tobias Waldekranz [this message]
2025-01-27  6:46   ` Sughosh Ganu
2025-01-27 11:44     ` Ilias Apalodimas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tt9n6hah.fsf@waldekranz.com \
    --to=tobias@waldekranz.com \
    --cc=Anton.Antonov@arm.com \
    --cc=bmeng@tinylab.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=sjg@chromium.org \
    --cc=sughosh.ganu@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox