From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Quentin Schulz <quentin.schulz@cherry.de>,
Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] bootstd: Fix a handful of doc typos in bootmeth
Date: Tue, 04 Jun 2024 17:17:48 +0200 [thread overview]
Message-ID: <87tti820v7.fsf@baylibre.com> (raw)
In-Reply-To: <a57a03d8-5e45-4ebc-884c-9626a03c6aa9@cherry.de>
Hi Quentin,
Thanks for the review!
On mar., juin 04, 2024 at 14:22, Quentin Schulz <quentin.schulz@cherry.de> wrote:
> Hi Mattijs,
>
> On 6/4/24 2:04 PM, Mattijs Korpershoek wrote:
[...]
>>
>> There seems indeed to be some inconsistencies around bootmeths versus
>> bootmethods.
>>
>> To me, we should use 'bootmeth' everywhere.
>>
>> Simon, as the maintainer of bootflow, do you agree ?
>>
>> I can spin up another patch to fix this.
>>
>
> c.f. https://lore.kernel.org/u-boot/20211023232635.9195-1-sjg@chromium.org/
>
> """
> For version 2, a new naming scheme is used as above:
>
> - bootdev is used instead of bootdevice, because 'device' is overused,
> is everywhere in U-Boot, can be confused with udevice
> - bootmeth - because 'method' is too vanilla, appears 1300 times in
> U-Boot
> """
>
> SO I think we should change it to bootmeth(s) indeed.
Ah, thank you for the link, that is helpful.
I've done the global rename, made this into a series here:
https://lore.kernel.org/all/20240604-bootmeth-typos-v2-0-821683a95aaf@baylibre.com
>
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
>
> Thanks,
> Quentin
prev parent reply other threads:[~2024-06-04 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 9:11 [PATCH] bootstd: Fix a handful of doc typos in bootmeth Mattijs Korpershoek
2024-06-04 9:47 ` Quentin Schulz
2024-06-04 12:04 ` Mattijs Korpershoek
2024-06-04 12:22 ` Quentin Schulz
2024-06-04 15:17 ` Mattijs Korpershoek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tti820v7.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox