* Re: [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards
2024-05-03 7:00 [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards Benjamin Hahn
@ 2024-05-03 8:41 ` Wadim Egorov
2024-05-03 12:44 ` Fabio Estevam
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Wadim Egorov @ 2024-05-03 8:41 UTC (permalink / raw)
To: Benjamin Hahn, Teresa Remmet, Yannic Moog, Tom Rini, Martyn Welch,
Parthiban Nallathambi, Fabio Estevam
Cc: u-boot, upstream
Am 03.05.24 um 09:00 schrieb Benjamin Hahn:
> Set CONFIG_USB_GADGET_MANUFACTURER to PHYTEC for all PHYTEC boards.
>
> Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
Acked-by: Wadim Egorov <w.egorov@phytec.de>
> ---
> configs/phycore-imx8mp_defconfig | 2 +-
> configs/phycore_am64x_a53_defconfig | 2 +-
> configs/phycore_am64x_r5_defconfig | 2 +-
> configs/phycore_pcl063_defconfig | 2 +-
> configs/phycore_pcl063_ull_defconfig | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/configs/phycore-imx8mp_defconfig b/configs/phycore-imx8mp_defconfig
> index e9a287cb441f..9f42edd72324 100644
> --- a/configs/phycore-imx8mp_defconfig
> +++ b/configs/phycore-imx8mp_defconfig
> @@ -147,7 +147,7 @@ CONFIG_USB_DWC3=y
> CONFIG_USB_DWC3_GENERIC=y
> CONFIG_USB_STORAGE=y
> CONFIG_USB_GADGET=y
> -CONFIG_USB_GADGET_MANUFACTURER="FSL"
> +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC"
> CONFIG_USB_GADGET_VENDOR_NUM=0x0525
> CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
> CONFIG_IMX_WATCHDOG=y
> diff --git a/configs/phycore_am64x_a53_defconfig b/configs/phycore_am64x_a53_defconfig
> index 1a9359773b45..9b52f8ad0644 100644
> --- a/configs/phycore_am64x_a53_defconfig
> +++ b/configs/phycore_am64x_a53_defconfig
> @@ -159,7 +159,7 @@ CONFIG_USB_CDNS3=y
> CONFIG_USB_CDNS3_GADGET=y
> CONFIG_USB_CDNS3_HOST=y
> CONFIG_USB_GADGET=y
> -CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
> +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC"
> CONFIG_USB_GADGET_VENDOR_NUM=0x0451
> CONFIG_USB_GADGET_PRODUCT_NUM=0x6165
> CONFIG_USB_GADGET_DOWNLOAD=y
> diff --git a/configs/phycore_am64x_r5_defconfig b/configs/phycore_am64x_r5_defconfig
> index 61d784fa17f6..15a7e7089e73 100644
> --- a/configs/phycore_am64x_r5_defconfig
> +++ b/configs/phycore_am64x_r5_defconfig
> @@ -171,7 +171,7 @@ CONFIG_USB_STORAGE=y
> CONFIG_SPL_USB_STORAGE=y
> CONFIG_USB_GADGET=y
> CONFIG_SPL_USB_GADGET=y
> -CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
> +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC"
> CONFIG_USB_GADGET_VENDOR_NUM=0x0451
> CONFIG_USB_GADGET_PRODUCT_NUM=0x6165
> CONFIG_USB_GADGET_DOWNLOAD=y
> diff --git a/configs/phycore_pcl063_defconfig b/configs/phycore_pcl063_defconfig
> index 017054a8e12b..2f6b158a6772 100644
> --- a/configs/phycore_pcl063_defconfig
> +++ b/configs/phycore_pcl063_defconfig
> @@ -62,7 +62,7 @@ CONFIG_IMX_THERMAL=y
> CONFIG_USB=y
> CONFIG_SPL_USB_HOST=y
> CONFIG_USB_GADGET=y
> -CONFIG_USB_GADGET_MANUFACTURER="Phytec"
> +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC"
> CONFIG_USB_GADGET_VENDOR_NUM=0x1b67
> CONFIG_USB_GADGET_PRODUCT_NUM=0x4fff
> CONFIG_CI_UDC=y
> diff --git a/configs/phycore_pcl063_ull_defconfig b/configs/phycore_pcl063_ull_defconfig
> index b3da43a5bf1e..b42a410da69c 100644
> --- a/configs/phycore_pcl063_ull_defconfig
> +++ b/configs/phycore_pcl063_ull_defconfig
> @@ -53,7 +53,7 @@ CONFIG_IMX_THERMAL=y
> CONFIG_USB=y
> CONFIG_SPL_USB_HOST=y
> CONFIG_USB_GADGET=y
> -CONFIG_USB_GADGET_MANUFACTURER="Phytec"
> +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC"
> CONFIG_USB_GADGET_VENDOR_NUM=0x1b67
> CONFIG_USB_GADGET_PRODUCT_NUM=0x4fff
> CONFIG_CI_UDC=y
>
> ---
> base-commit: 6fdb021f148f598a67eb3cac5e3eb4a569cdaacd
> change-id: 20240503-wip-bhahn-bspimx8m-3196-c1ebd0bab6ac
>
> Best regards,
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards
2024-05-03 7:00 [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards Benjamin Hahn
2024-05-03 8:41 ` Wadim Egorov
@ 2024-05-03 12:44 ` Fabio Estevam
2024-05-06 10:52 ` Benjamin Hahn
2024-05-07 12:46 ` Mattijs Korpershoek
2024-05-14 9:59 ` Mattijs Korpershoek
3 siblings, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2024-05-03 12:44 UTC (permalink / raw)
To: Benjamin Hahn
Cc: Teresa Remmet, Yannic Moog, Tom Rini, Wadim Egorov, Martyn Welch,
Parthiban Nallathambi, u-boot, upstream
Hi Benjamin,
On Fri, May 3, 2024 at 4:01 AM Benjamin Hahn <B.Hahn@phytec.de> wrote:
> -CONFIG_USB_GADGET_MANUFACTURER="FSL"
> +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC"
> CONFIG_USB_GADGET_VENDOR_NUM=0x0525
> CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
...
> -CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
> +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC"
> CONFIG_USB_GADGET_VENDOR_NUM=0x0451
> CONFIG_USB_GADGET_PRODUCT_NUM=0x6165
What about making VENDOR_NUM/PRODUCT_NUM consistent as well?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards
2024-05-03 12:44 ` Fabio Estevam
@ 2024-05-06 10:52 ` Benjamin Hahn
2024-05-07 10:54 ` Fabio Estevam
0 siblings, 1 reply; 7+ messages in thread
From: Benjamin Hahn @ 2024-05-06 10:52 UTC (permalink / raw)
To: Fabio Estevam
Cc: Teresa Remmet, Yannic Moog, Tom Rini, Wadim Egorov, Martyn Welch,
Parthiban Nallathambi, u-boot@lists.denx.de,
upstream@lists.phytec.de
Hi Fabio,
On 03.05.24 14:44, Fabio Estevam wrote:
> Hi Benjamin,
>
> On Fri, May 3, 2024 at 4:01 AM Benjamin Hahn <B.Hahn@phytec.de> wrote:
>
>> -CONFIG_USB_GADGET_MANUFACTURER="FSL"
>> +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC"
>> CONFIG_USB_GADGET_VENDOR_NUM=0x0525
>> CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
> ...
>> -CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
>> +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC"
>> CONFIG_USB_GADGET_VENDOR_NUM=0x0451
>> CONFIG_USB_GADGET_PRODUCT_NUM=0x6165
> What about making VENDOR_NUM/PRODUCT_NUM consistent as well?
We are not registered at USB-IF and therefore don't have a valid
VENDOR_NUM and PRODUCT_NUM, so we rely on the VENDOR_NUM and PRODUCT_NUM
of the SoC Vendor, so the correct features get enabled by the driver.
With kind regards,
Benjamin Hahn
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards
2024-05-06 10:52 ` Benjamin Hahn
@ 2024-05-07 10:54 ` Fabio Estevam
0 siblings, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2024-05-07 10:54 UTC (permalink / raw)
To: Benjamin Hahn
Cc: Teresa Remmet, Yannic Moog, Tom Rini, Wadim Egorov, Martyn Welch,
Parthiban Nallathambi, u-boot@lists.denx.de,
upstream@lists.phytec.de
Hi Benjamin,
On Mon, May 6, 2024 at 7:52 AM Benjamin Hahn <B.Hahn@phytec.de> wrote:
> We are not registered at USB-IF and therefore don't have a valid
> VENDOR_NUM and PRODUCT_NUM, so we rely on the VENDOR_NUM and PRODUCT_NUM
> of the SoC Vendor, so the correct features get enabled by the driver.
Ok, understood.
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards
2024-05-03 7:00 [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards Benjamin Hahn
2024-05-03 8:41 ` Wadim Egorov
2024-05-03 12:44 ` Fabio Estevam
@ 2024-05-07 12:46 ` Mattijs Korpershoek
2024-05-14 9:59 ` Mattijs Korpershoek
3 siblings, 0 replies; 7+ messages in thread
From: Mattijs Korpershoek @ 2024-05-07 12:46 UTC (permalink / raw)
To: Benjamin Hahn, Teresa Remmet, Yannic Moog, Tom Rini, Wadim Egorov,
Martyn Welch, Parthiban Nallathambi, Fabio Estevam
Cc: u-boot, upstream, Benjamin Hahn
Hi Benjamin,
Thank you for the patch.
On ven., mai 03, 2024 at 09:00, Benjamin Hahn <B.Hahn@phytec.de> wrote:
> Set CONFIG_USB_GADGET_MANUFACTURER to PHYTEC for all PHYTEC boards.
>
> Signed-off-by: Benjamin Hahn <B.Hahn@phytec.de>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
This is assigned to me on patchwork. I can pick it up through
u-boot-dfu.
If someone else wants to pick it up, please let me know.
> ---
> configs/phycore-imx8mp_defconfig | 2 +-
> configs/phycore_am64x_a53_defconfig | 2 +-
> configs/phycore_am64x_r5_defconfig | 2 +-
> configs/phycore_pcl063_defconfig | 2 +-
> configs/phycore_pcl063_ull_defconfig | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/configs/phycore-imx8mp_defconfig b/configs/phycore-imx8mp_defconfig
> index e9a287cb441f..9f42edd72324 100644
> --- a/configs/phycore-imx8mp_defconfig
> +++ b/configs/phycore-imx8mp_defconfig
> @@ -147,7 +147,7 @@ CONFIG_USB_DWC3=y
> CONFIG_USB_DWC3_GENERIC=y
> CONFIG_USB_STORAGE=y
> CONFIG_USB_GADGET=y
> -CONFIG_USB_GADGET_MANUFACTURER="FSL"
> +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC"
> CONFIG_USB_GADGET_VENDOR_NUM=0x0525
> CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
> CONFIG_IMX_WATCHDOG=y
> diff --git a/configs/phycore_am64x_a53_defconfig b/configs/phycore_am64x_a53_defconfig
> index 1a9359773b45..9b52f8ad0644 100644
> --- a/configs/phycore_am64x_a53_defconfig
> +++ b/configs/phycore_am64x_a53_defconfig
> @@ -159,7 +159,7 @@ CONFIG_USB_CDNS3=y
> CONFIG_USB_CDNS3_GADGET=y
> CONFIG_USB_CDNS3_HOST=y
> CONFIG_USB_GADGET=y
> -CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
> +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC"
> CONFIG_USB_GADGET_VENDOR_NUM=0x0451
> CONFIG_USB_GADGET_PRODUCT_NUM=0x6165
> CONFIG_USB_GADGET_DOWNLOAD=y
> diff --git a/configs/phycore_am64x_r5_defconfig b/configs/phycore_am64x_r5_defconfig
> index 61d784fa17f6..15a7e7089e73 100644
> --- a/configs/phycore_am64x_r5_defconfig
> +++ b/configs/phycore_am64x_r5_defconfig
> @@ -171,7 +171,7 @@ CONFIG_USB_STORAGE=y
> CONFIG_SPL_USB_STORAGE=y
> CONFIG_USB_GADGET=y
> CONFIG_SPL_USB_GADGET=y
> -CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
> +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC"
> CONFIG_USB_GADGET_VENDOR_NUM=0x0451
> CONFIG_USB_GADGET_PRODUCT_NUM=0x6165
> CONFIG_USB_GADGET_DOWNLOAD=y
> diff --git a/configs/phycore_pcl063_defconfig b/configs/phycore_pcl063_defconfig
> index 017054a8e12b..2f6b158a6772 100644
> --- a/configs/phycore_pcl063_defconfig
> +++ b/configs/phycore_pcl063_defconfig
> @@ -62,7 +62,7 @@ CONFIG_IMX_THERMAL=y
> CONFIG_USB=y
> CONFIG_SPL_USB_HOST=y
> CONFIG_USB_GADGET=y
> -CONFIG_USB_GADGET_MANUFACTURER="Phytec"
> +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC"
> CONFIG_USB_GADGET_VENDOR_NUM=0x1b67
> CONFIG_USB_GADGET_PRODUCT_NUM=0x4fff
> CONFIG_CI_UDC=y
> diff --git a/configs/phycore_pcl063_ull_defconfig b/configs/phycore_pcl063_ull_defconfig
> index b3da43a5bf1e..b42a410da69c 100644
> --- a/configs/phycore_pcl063_ull_defconfig
> +++ b/configs/phycore_pcl063_ull_defconfig
> @@ -53,7 +53,7 @@ CONFIG_IMX_THERMAL=y
> CONFIG_USB=y
> CONFIG_SPL_USB_HOST=y
> CONFIG_USB_GADGET=y
> -CONFIG_USB_GADGET_MANUFACTURER="Phytec"
> +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC"
> CONFIG_USB_GADGET_VENDOR_NUM=0x1b67
> CONFIG_USB_GADGET_PRODUCT_NUM=0x4fff
> CONFIG_CI_UDC=y
>
> ---
> base-commit: 6fdb021f148f598a67eb3cac5e3eb4a569cdaacd
> change-id: 20240503-wip-bhahn-bspimx8m-3196-c1ebd0bab6ac
>
> Best regards,
> --
> Benjamin Hahn <B.Hahn@phytec.de>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards
2024-05-03 7:00 [PATCH] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards Benjamin Hahn
` (2 preceding siblings ...)
2024-05-07 12:46 ` Mattijs Korpershoek
@ 2024-05-14 9:59 ` Mattijs Korpershoek
3 siblings, 0 replies; 7+ messages in thread
From: Mattijs Korpershoek @ 2024-05-14 9:59 UTC (permalink / raw)
To: Teresa Remmet, Yannic Moog, Tom Rini, Wadim Egorov, Martyn Welch,
Parthiban Nallathambi, Fabio Estevam, Benjamin Hahn
Cc: u-boot, upstream
Hi,
On Fri, 03 May 2024 09:00:38 +0200, Benjamin Hahn wrote:
> Set CONFIG_USB_GADGET_MANUFACTURER to PHYTEC for all PHYTEC boards.
>
>
Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu)
[1/1] configs: Make USB_GADGET_MANUFACTURER consistent over all PHYTEC boards
https://source.denx.de/u-boot/custodians/u-boot-dfu/-/commit/371b379edbf3488d77bc321dc5d2a0e22e067744
--
Mattijs
^ permalink raw reply [flat|nested] 7+ messages in thread