From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFFBBC38142 for ; Wed, 1 Feb 2023 08:36:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1BC9D85C18; Wed, 1 Feb 2023 09:36:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20210112.gappssmtp.com header.i=@baylibre-com.20210112.gappssmtp.com header.b="vWKaYIoN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6B0C485C1B; Wed, 1 Feb 2023 09:36:52 +0100 (CET) Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0AB2385C02 for ; Wed, 1 Feb 2023 09:36:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mkorpershoek@baylibre.com Received: by mail-wr1-x435.google.com with SMTP id r2so16507427wrv.7 for ; Wed, 01 Feb 2023 00:36:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=mytwnIpJj/t3T3nhEQdb9CGfBd+h5Q58Ed1ZXTWuVlg=; b=vWKaYIoNCezYmRzB0z/386MthEuuGuvzFsIBDmCgudng8Y3aC+z7Xq/qQVQwgM3BKb OaiadhuR5M70tHFnvv7iUzRagm8wXOu/hqoUgBqnI0HdY0a6PNfdJALE5nNKPvggYyvq P82X9BMOnM+9U5dSfSwNLtZMEetC5BINGhpAjqPOGewdBbpi07APiDEcy6IUDgnNfUAH v3fNCn9Ib6HlY+aHsI7sF7TaozetiOpoExtUSAF384DXrZtoj0xCu4nOvbVgcRsbwuw1 DmpNGEoDYQKTFC+KYNgbxTtQnqvUc3F3vd26BRwdg+yFHHzdCWin8YYL3tuanM0FqwJU 71ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mytwnIpJj/t3T3nhEQdb9CGfBd+h5Q58Ed1ZXTWuVlg=; b=mbl6g6Y6QkNyU0aqpRQTLK3zJ2QIL/s4dx4H2Tj7f9o0towozsvj96M0IzdroOAJu1 oJOAh9GR0oLJ3V1ImQPx5+7N91TYgG87dKe5PuuEI1hfNnXxcw63ZxfJpp/L3XVhbrzS jvVw0RbHhTKi/m3BHvvX2UfnzIpdYoXJc1AVasmqhsuMBrSnA4cT+15LZhLTQpwxyJfm 3vu6EdDYyqU2ffiwuzsabBQ3VGXPx3nkCSPIbWkDzhDEwLCL7tWIhYQpdJI6xYABkuM1 zVLr7yV4omzO2Wij25mHxk8NGb7qtFoTuTKwZx/0nbH/mH8TobjuXtAq8xI987uasKuQ kxoA== X-Gm-Message-State: AO0yUKVZdLv2Vwv6H4PRnaEbd9ADCeMsiX9ArOI6teK5VM3R6zcPmGmm 8lYNZZbiVwQ7x0XwCRPzGwZTIg== X-Google-Smtp-Source: AK7set8fx1fRQMqUxpPC7viPU/PhEyICk9r/qjUkFe+WG6+J6LJ1i+eb3Howp+Vu/Z63F+0eGsUkfw== X-Received: by 2002:a05:6000:982:b0:2bf:bd43:aacc with SMTP id by2-20020a056000098200b002bfbd43aaccmr1789669wrb.55.1675240609536; Wed, 01 Feb 2023 00:36:49 -0800 (PST) Received: from localhost ([82.66.159.240]) by smtp.gmail.com with ESMTPSA id m14-20020a5d6a0e000000b002bfd09f2ca6sm14736350wru.3.2023.02.01.00.36.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 00:36:49 -0800 (PST) From: Mattijs Korpershoek To: Simon Glass , Safae Ouajih Cc: u-boot@lists.denx.de, sean.anderson@seco.com, r.stratiienko@gmail.com, glaroque@baylibre.com, khilman@baylibre.com Subject: Re: [PATCH v2 07/17] android: boot: content print is not supported for v3,v4 header version In-Reply-To: References: <20230126160506.1026643-1-souajih@baylibre.com> <20230126160506.1026643-8-souajih@baylibre.com> <951c8476-45f1-892e-c372-6f9c2b014040@baylibre.com> Date: Wed, 01 Feb 2023 09:36:48 +0100 Message-ID: <87tu05ixy7.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Fri, Jan 27, 2023 at 10:15, Simon Glass wrote: > On Fri, 27 Jan 2023 at 08:50, Safae Ouajih wrote: >> >> >> On 27/01/2023 01:54, Simon Glass wrote: >> > Hi Safae, >> > >> > On Thu, 26 Jan 2023 at 09:05, Safae Ouajih wrote: >> >> Content print is not supported for version 3 and 4 of boot image header. >> >> Thus, only print that content when v2 is used. >> >> >> >> Update android_print_contents() to print an error message >> >> when trying to print boot image header version 3 or 4 content. >> >> >> >> Signed-off-by: Safae Ouajih >> >> --- >> >> boot/image-android.c | 6 +++++- >> >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> >> > Why is that? >> > >> > Regards, >> > Simon >> >> Hi Simon, >> >> Thank you for the review. >> >> Content print for boot image header v4 can be supported >> >> and only requires updating the existing functions. >> >> This is something I intend to support later on. > > OK thanks > > Reviewed-by: Simon Glass Reviewed-by: Mattijs Korpershoek