* [PATCH] imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL @ 2020-10-29 0:02 Simon Glass 2020-10-29 5:14 ` Baruch Siach 0 siblings, 1 reply; 6+ messages in thread From: Simon Glass @ 2020-10-29 0:02 UTC (permalink / raw) To: u-boot This feature is incompatble with of-platdata since it uses the U_BOOT_DEVICE() macro. With of-platdata the only devices permitted are those created by dtoc. Drop this option for now, until the driver can be corrected. Signed-off-by: Simon Glass <sjg@chromium.org> --- include/configs/mx6cuboxi.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/configs/mx6cuboxi.h b/include/configs/mx6cuboxi.h index cfab9a7fc02..55717c77ab3 100644 --- a/include/configs/mx6cuboxi.h +++ b/include/configs/mx6cuboxi.h @@ -13,8 +13,6 @@ #include "imx6_spl.h" -#define CONFIG_IMX_THERMAL - #define CONFIG_SYS_MALLOC_LEN (10 * SZ_1M) /* MMC Configs */ -- 2.29.1.341.ge80a0c044ae-goog ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL 2020-10-29 0:02 [PATCH] imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL Simon Glass @ 2020-10-29 5:14 ` Baruch Siach 2020-10-29 15:19 ` Tom Rini 0 siblings, 1 reply; 6+ messages in thread From: Baruch Siach @ 2020-10-29 5:14 UTC (permalink / raw) To: u-boot Hi Simon, Adding Walter to Cc. On Thu, Oct 29 2020, Simon Glass wrote: > This feature is incompatble with of-platdata since it uses the > U_BOOT_DEVICE() macro. With of-platdata the only devices permitted are > those created by dtoc. > > Drop this option for now, until the driver can be corrected. As I understand, of-platdata is only enabled in SPL. Is there a way to limit imx_thermal drop to SPL? The thermal driver in not very useful in SPL anyway, right? Thanks, baruch > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > include/configs/mx6cuboxi.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/configs/mx6cuboxi.h b/include/configs/mx6cuboxi.h > index cfab9a7fc02..55717c77ab3 100644 > --- a/include/configs/mx6cuboxi.h > +++ b/include/configs/mx6cuboxi.h > @@ -13,8 +13,6 @@ > > #include "imx6_spl.h" > > -#define CONFIG_IMX_THERMAL > - > #define CONFIG_SYS_MALLOC_LEN (10 * SZ_1M) > > /* MMC Configs */ -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL 2020-10-29 5:14 ` Baruch Siach @ 2020-10-29 15:19 ` Tom Rini 2020-10-29 16:11 ` Walter Lozano 0 siblings, 1 reply; 6+ messages in thread From: Tom Rini @ 2020-10-29 15:19 UTC (permalink / raw) To: u-boot On Thu, Oct 29, 2020 at 07:14:55AM +0200, Baruch Siach wrote: > Hi Simon, > > Adding Walter to Cc. > > On Thu, Oct 29 2020, Simon Glass wrote: > > This feature is incompatble with of-platdata since it uses the > > U_BOOT_DEVICE() macro. With of-platdata the only devices permitted are > > those created by dtoc. > > > > Drop this option for now, until the driver can be corrected. > > As I understand, of-platdata is only enabled in SPL. Is there a way to > limit imx_thermal drop to SPL? The thermal driver in not very useful in > SPL anyway, right? Well, sigh, step one is to finish the migration to Kconfig for IMX_THERMAL as it has a symbol, but it's still set in a ton of board config files. We only build thermal in SPL when SPL_THERMAL is set, so I assume this is about trying to use of-platdata in U-Boot proper too, to keep / further reduce the size of U-Boot itself to stay within size limits. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201029/1e7307bb/attachment.sig> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL 2020-10-29 15:19 ` Tom Rini @ 2020-10-29 16:11 ` Walter Lozano 2020-10-29 16:14 ` Tom Rini 0 siblings, 1 reply; 6+ messages in thread From: Walter Lozano @ 2020-10-29 16:11 UTC (permalink / raw) To: u-boot On 29/10/20 12:19, Tom Rini wrote: > On Thu, Oct 29, 2020 at 07:14:55AM +0200, Baruch Siach wrote: >> Hi Simon, >> >> Adding Walter to Cc. >> >> On Thu, Oct 29 2020, Simon Glass wrote: >>> This feature is incompatble with of-platdata since it uses the >>> U_BOOT_DEVICE() macro. With of-platdata the only devices permitted are >>> those created by dtoc. >>> >>> Drop this option for now, until the driver can be corrected. >> As I understand, of-platdata is only enabled in SPL. Is there a way to >> limit imx_thermal drop to SPL? The thermal driver in not very useful in >> SPL anyway, right? As you pointed of-platdata is intended for TPL/SPL to avoid the overhead of DTB and libraries. If this option is enabled and the driver does not support it, the device won't be created in TPL/SPL but is should on U-Boot. In order to limit the drop to SPL can CONFIG_SPL_BUILD be used? Regarding the usefulness of im_thermal in SPL I can't comment. > Well, sigh, step one is to finish the migration to Kconfig for > IMX_THERMAL as it has a symbol, but it's still set in a ton of board > config files. We only build thermal in SPL when SPL_THERMAL is set, so > I assume this is about trying to use of-platdata in U-Boot proper too, > to keep / further reduce the size of U-Boot itself to stay within size > limits. > Regards, Walter ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL 2020-10-29 16:11 ` Walter Lozano @ 2020-10-29 16:14 ` Tom Rini 2020-10-29 17:06 ` Simon Glass 0 siblings, 1 reply; 6+ messages in thread From: Tom Rini @ 2020-10-29 16:14 UTC (permalink / raw) To: u-boot On Thu, Oct 29, 2020 at 01:11:15PM -0300, Walter Lozano wrote: > > On 29/10/20 12:19, Tom Rini wrote: > > On Thu, Oct 29, 2020 at 07:14:55AM +0200, Baruch Siach wrote: > > > Hi Simon, > > > > > > Adding Walter to Cc. > > > > > > On Thu, Oct 29 2020, Simon Glass wrote: > > > > This feature is incompatble with of-platdata since it uses the > > > > U_BOOT_DEVICE() macro. With of-platdata the only devices permitted are > > > > those created by dtoc. > > > > > > > > Drop this option for now, until the driver can be corrected. > > > As I understand, of-platdata is only enabled in SPL. Is there a way to > > > limit imx_thermal drop to SPL? The thermal driver in not very useful in > > > SPL anyway, right? > > As you pointed of-platdata is intended for TPL/SPL to avoid the overhead of > DTB and libraries. If this option is enabled and the driver does not support > it, the device won't be created in TPL/SPL but is should on U-Boot. In order > to limit the drop to SPL can CONFIG_SPL_BUILD be used? > > Regarding the usefulness of im_thermal in SPL I can't comment. > > > Well, sigh, step one is to finish the migration to Kconfig for > > IMX_THERMAL as it has a symbol, but it's still set in a ton of board > > config files. We only build thermal in SPL when SPL_THERMAL is set, so > > I assume this is about trying to use of-platdata in U-Boot proper too, > > to keep / further reduce the size of U-Boot itself to stay within size > > limits. Well, I suspect maybe part of the problem is that since the symbol isn't migrated properly, it's not being not built when we don't need it. I did the migration and queued up a build, I should have some answers later today. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201029/b7f17b01/attachment.sig> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL 2020-10-29 16:14 ` Tom Rini @ 2020-10-29 17:06 ` Simon Glass 0 siblings, 0 replies; 6+ messages in thread From: Simon Glass @ 2020-10-29 17:06 UTC (permalink / raw) To: u-boot Hi, On Thu, 29 Oct 2020 at 10:15, Tom Rini <trini@konsulko.com> wrote: > > On Thu, Oct 29, 2020 at 01:11:15PM -0300, Walter Lozano wrote: > > > > On 29/10/20 12:19, Tom Rini wrote: > > > On Thu, Oct 29, 2020 at 07:14:55AM +0200, Baruch Siach wrote: > > > > Hi Simon, > > > > > > > > Adding Walter to Cc. > > > > > > > > On Thu, Oct 29 2020, Simon Glass wrote: > > > > > This feature is incompatble with of-platdata since it uses the > > > > > U_BOOT_DEVICE() macro. With of-platdata the only devices permitted are > > > > > those created by dtoc. > > > > > > > > > > Drop this option for now, until the driver can be corrected. > > > > As I understand, of-platdata is only enabled in SPL. Is there a way to > > > > limit imx_thermal drop to SPL? The thermal driver in not very useful in > > > > SPL anyway, right? > > > > As you pointed of-platdata is intended for TPL/SPL to avoid the overhead of > > DTB and libraries. If this option is enabled and the driver does not support > > it, the device won't be created in TPL/SPL but is should on U-Boot. In order > > to limit the drop to SPL can CONFIG_SPL_BUILD be used? > > > > Regarding the usefulness of im_thermal in SPL I can't comment. > > > > > Well, sigh, step one is to finish the migration to Kconfig for > > > IMX_THERMAL as it has a symbol, but it's still set in a ton of board > > > config files. We only build thermal in SPL when SPL_THERMAL is set, so > > > I assume this is about trying to use of-platdata in U-Boot proper too, > > > to keep / further reduce the size of U-Boot itself to stay within size > > > limits. > > Well, I suspect maybe part of the problem is that since the symbol > isn't migrated properly, it's not being not built when we don't need it. > I did the migration and queued up a build, I should have some answers > later today. In the meantime I'll send a v2 patch which just disables the driver in SPL. Regards, Simon ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-29 17:06 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-10-29 0:02 [PATCH] imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL Simon Glass 2020-10-29 5:14 ` Baruch Siach 2020-10-29 15:19 ` Tom Rini 2020-10-29 16:11 ` Walter Lozano 2020-10-29 16:14 ` Tom Rini 2020-10-29 17:06 ` Simon Glass
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox