From: Vagrant Cascadian <vagrant@debian.org>
To: u-boot@lists.denx.de
Subject: [PATCH] drivers: video: rockchip: fix building eDP and LVDS drivers
Date: Mon, 20 Apr 2020 18:02:13 -0700 [thread overview]
Message-ID: <87tv1dwt0q.fsf@ponder> (raw)
In-Reply-To: <20200420181825.935797-1-pbrobinson@gmail.com>
On 2020-04-20, Peter Robinson wrote:
> The rk_edp.c and rk_lvds.c files reference rk_setreg which is declared in
> hardware.h so include it so the drivers build. Adjust rk_lvds.c so
> includes are in alphabetical order while updating.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> Reviewed-by: Anatolij Gustschin <agust@denx.de>
This fixed the build I was having with the pinebook pro patches when
applied to v2020.04, built on both Debian and GNU Guix.
Thanks!
Tested-by: Vagrant Cascadian <vagrant@debian.org>
> ---
> drivers/video/rockchip/rk_edp.c | 1 +
> drivers/video/rockchip/rk_lvds.c | 3 ++-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/rockchip/rk_edp.c b/drivers/video/rockchip/rk_edp.c
> index 8703df0ec0..cf84b886e7 100644
> --- a/drivers/video/rockchip/rk_edp.c
> +++ b/drivers/video/rockchip/rk_edp.c
> @@ -18,6 +18,7 @@
> #include <asm/arch-rockchip/clock.h>
> #include <asm/arch-rockchip/edp_rk3288.h>
> #include <asm/arch-rockchip/grf_rk3288.h>
> +#include <asm/arch-rockchip/hardware.h>
> #include <dt-bindings/clock/rk3288-cru.h>
>
> #define MAX_CR_LOOP 5
> diff --git a/drivers/video/rockchip/rk_lvds.c b/drivers/video/rockchip/rk_lvds.c
> index cf5c0439b1..79e24baf53 100644
> --- a/drivers/video/rockchip/rk_lvds.c
> +++ b/drivers/video/rockchip/rk_lvds.c
> @@ -13,8 +13,9 @@
> #include <asm/gpio.h>
> #include <asm/io.h>
> #include <asm/arch-rockchip/clock.h>
> -#include <asm/arch-rockchip/lvds_rk3288.h>
> #include <asm/arch-rockchip/grf_rk3288.h>
> +#include <asm/arch-rockchip/hardware.h>
> +#include <asm/arch-rockchip/lvds_rk3288.h>
> #include <dt-bindings/clock/rk3288-cru.h>
> #include <dt-bindings/video/rk3288.h>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200420/cb9c018b/attachment-0001.sig>
next prev parent reply other threads:[~2020-04-21 1:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 18:18 [PATCH] drivers: video: rockchip: fix building eDP and LVDS drivers Peter Robinson
2020-04-20 18:45 ` Anatolij Gustschin
2020-04-21 1:02 ` Vagrant Cascadian [this message]
2020-04-26 21:10 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv1dwt0q.fsf@ponder \
--to=vagrant@debian.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox