public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vagrant Cascadian <vagrant@aikidev.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pmic: Fix pfuze100 bit definitions
Date: Wed, 25 Nov 2015 15:54:08 -0800	[thread overview]
Message-ID: <87two9y6sf.fsf@aikidev.net> (raw)
In-Reply-To: <1448493344-6336-1-git-send-email-marex@denx.de>

On 2015-11-25, Marek Vasut wrote:
> The following patch changed the PFUZE100 swbst register bit definitions
> and broke PMIC configuration on multiple boards, at least on the novena
> and gw_ventana. This patch fixes it.
>
> commit 8fa46350a4c7dca7710362f6c871098557b934ad
> Author: Peng Fan <Peng.Fan@freescale.com>
> Date:   Fri Aug 7 16:43:45 2015 +0800
>
>     power: regulator: add pfuze100 support
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Peng Fan <Peng.Fan@freescale.com>
> Cc: Przemyslaw Marczak <p.marczak@samsung.com>
> Cc: Tim Harvey <tharvey@gateworks.com>
> Cc: Vagrant Cascadian <vagrant@aikidev.net>
> ---
>  include/power/pfuze100_pmic.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Tested on a Novena PVT2-A, fixes USB support.

Tested-by: Vagrant Cascadian <vagrant@aikidev.net>

live well,
  vagrant

> diff --git a/include/power/pfuze100_pmic.h b/include/power/pfuze100_pmic.h
> index 41cb710..cc019a9 100644
> --- a/include/power/pfuze100_pmic.h
> +++ b/include/power/pfuze100_pmic.h
> @@ -215,10 +215,10 @@ enum {
>  #define SWBST_VOL_MASK	0x3
>  #define SWBST_MODE_MASK	0xC
>  #define SWBST_MODE_SHIFT 0x2
> -#define SWBST_MODE_OFF	0
> -#define SWBST_MODE_PFM	1
> -#define SWBST_MODE_AUTO	2
> -#define SWBST_MODE_APS	3
> +#define SWBST_MODE_OFF	(0 << 2)
> +#define SWBST_MODE_PFM	(1 << 2)
> +#define SWBST_MODE_AUTO	(2 << 2)
> +#define SWBST_MODE_APS	(3 << 2)
>  
>  /*
>   * Regulator Mode Control
> -- 
> 2.6.2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151125/9e1987da/attachment.sig>

  reply	other threads:[~2015-11-25 23:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 23:15 [U-Boot] [PATCH] pmic: Fix pfuze100 bit definitions Marek Vasut
2015-11-25 23:54 ` Vagrant Cascadian [this message]
2015-11-26  1:27 ` Peng Fan
2015-11-26  1:35   ` Marek Vasut
2015-11-26  1:46     ` Peng Fan
2015-11-26 12:21 ` Przemyslaw Marczak
2015-11-26 13:08   ` Marek Vasut
2015-11-26 14:35     ` Przemyslaw Marczak
2015-11-26 15:39       ` Marek Vasut
2015-11-26 16:13         ` Przemyslaw Marczak
2015-11-26 16:21           ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87two9y6sf.fsf@aikidev.net \
    --to=vagrant@aikidev.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox