public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] [PATCH] Fix the issue of usb_kbd driver missing the scan code of key 'z'.
@ 2007-10-25  9:51 Zhang Wei
  2007-10-31  9:12 ` Markus Klotzbücher
  2007-11-03 21:22 ` Wolfgang Denk
  0 siblings, 2 replies; 3+ messages in thread
From: Zhang Wei @ 2007-10-25  9:51 UTC (permalink / raw)
  To: u-boot

The scan code of the key 'z' is 0x1d, which should be handled.

The change has be tested on NOVATEK USB keyboard and ULI PCI OHCI
controller.

Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
---
 common/usb_kbd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/common/usb_kbd.c b/common/usb_kbd.c
index aec558a..7bdfcc0 100644
--- a/common/usb_kbd.c
+++ b/common/usb_kbd.c
@@ -257,7 +257,7 @@ static int usb_kbd_translate(unsigned char scancode,unsigned char modifier,int p
 		repeat_delay=REPEAT_DELAY;
 	}
 	keycode=0;
-	if((scancode>3) && (scancode<0x1d)) { /* alpha numeric values */
+	if((scancode>3) && (scancode<=0x1d)) { /* alpha numeric values */
 		keycode=scancode-4 + 0x61;
 		if(caps_lock)
 			keycode&=~CAPITAL_MASK; /* switch to capital Letters */
-- 
1.5.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot-Users] [PATCH] Fix the issue of usb_kbd driver missing the scan code of key 'z'.
  2007-10-25  9:51 [U-Boot-Users] [PATCH] Fix the issue of usb_kbd driver missing the scan code of key 'z' Zhang Wei
@ 2007-10-31  9:12 ` Markus Klotzbücher
  2007-11-03 21:22 ` Wolfgang Denk
  1 sibling, 0 replies; 3+ messages in thread
From: Markus Klotzbücher @ 2007-10-31  9:12 UTC (permalink / raw)
  To: u-boot

Zhang Wei <wei.zhang@freescale.com> writes:

> The scan code of the key 'z' is 0x1d, which should be handled.
>
> The change has be tested on NOVATEK USB keyboard and ULI PCI OHCI
> controller.
>
> Signed-off-by: Zhang Wei <wei.zhang@freescale.com>

Thanks, add to USB custodian repo.

Best regards

Markus Klotzb?cher

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot-Users] [PATCH] Fix the issue of usb_kbd driver missing the scan code of key 'z'.
  2007-10-25  9:51 [U-Boot-Users] [PATCH] Fix the issue of usb_kbd driver missing the scan code of key 'z' Zhang Wei
  2007-10-31  9:12 ` Markus Klotzbücher
@ 2007-11-03 21:22 ` Wolfgang Denk
  1 sibling, 0 replies; 3+ messages in thread
From: Wolfgang Denk @ 2007-11-03 21:22 UTC (permalink / raw)
  To: u-boot

In message <11933058872007-git-send-email-wei.zhang@freescale.com> you wrote:
> The scan code of the key 'z' is 0x1d, which should be handled.
> 
> The change has be tested on NOVATEK USB keyboard and ULI PCI OHCI
> controller.
> 
> Signed-off-by: Zhang Wei <wei.zhang@freescale.com>

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The face of war has never changed.  Surely it is more logical to heal
than to kill.
	-- Surak of Vulcan, "The Savage Curtain", stardate 5906.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-11-03 21:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-25  9:51 [U-Boot-Users] [PATCH] Fix the issue of usb_kbd driver missing the scan code of key 'z' Zhang Wei
2007-10-31  9:12 ` Markus Klotzbücher
2007-11-03 21:22 ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox