Re: [PATCH 2/4] fastboot: blk: add block device flashing configuration

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

On lun., nov. 25, 2024 at 23:41, Dmitrii Merkurev <dimorinny@google.com> wrote:

> Hey Neil.
>
> Will do it by the end of the year. Only tested it with a virtio-block
> though.
>
> On Thu, Nov 21, 2024 at 12:44 PM <neil.armstrong@linaro.org> wrote:
>
>> Hi Dmitrii,
>>
>> So you plan to send a new version of this patchset ?
>>
>> It would be very useful to enable fastboot onr UFS/SCSI based devices.

FYI another development for UFS/SCSI has been submitted here:

https://patchwork.ozlabs.org/project/uboot/patch/20241125110354.602124-1-quic_varada@quicinc.com/

>>
>> Thanks,
>> Neil
>>
>> On 06/03/2024 19:59, Dmitrii Merkurev wrote:
>> > Signed-off-by: Dmitrii Merkurev <dimorinny@google.com>
>> > Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
>> > Cc: Simon Glass <sjg@chromium.org>
>> > Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
>> > Cc: Ying-Chun Liu (PaulLiu) <paul.liu@linaro.org>
>> > ---
>> >   drivers/fastboot/Kconfig | 20 ++++++++++++++++++--
>> >   1 file changed, 18 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/fastboot/Kconfig b/drivers/fastboot/Kconfig
>> > index 5e5855a76c..460c5e98d7 100644
>> > --- a/drivers/fastboot/Kconfig
>> > +++ b/drivers/fastboot/Kconfig
>> > @@ -87,7 +87,7 @@ config FASTBOOT_USB_DEV
>> >   config FASTBOOT_FLASH
>> >       bool "Enable FASTBOOT FLASH command"
>> >       default y if ARCH_SUNXI || ARCH_ROCKCHIP
>> > -     depends on MMC || (MTD_RAW_NAND && CMD_MTDPARTS)
>> > +     depends on MMC || (MTD_RAW_NAND && CMD_MTDPARTS) || BLK
>> >       select IMAGE_SPARSE
>> >       help
>> >         The fastboot protocol includes a "flash" command for writing
>> > @@ -109,12 +109,16 @@ choice
>> >
>> >   config FASTBOOT_FLASH_MMC
>> >       bool "FASTBOOT on MMC"
>> > -     depends on MMC
>> > +     depends on MMC && BLK
>> >
>> >   config FASTBOOT_FLASH_NAND
>> >       bool "FASTBOOT on NAND"
>> >       depends on MTD_RAW_NAND && CMD_MTDPARTS
>> >
>> > +config FASTBOOT_FLASH_BLOCK
>> > +     bool "FASTBOOT on block device"
>> > +     depends on BLK
>> > +
>> >   endchoice
>> >
>> >   config FASTBOOT_FLASH_MMC_DEV
>> > @@ -189,6 +193,18 @@ config FASTBOOT_MMC_USER_NAME
>> >         defined here.
>> >         The default target name for erasing EMMC_USER is "mmc0".
>> >
>> > +config FASTBOOT_FLASH_BLOCK_INTERFACE_NAME
>> > +     string "Define FASTBOOT block interface name"
>> > +     depends on FASTBOOT_FLASH_BLOCK
>> > +     help
>> > +       "Fastboot block interface name (mmc, virtio, etc)"
>> > +
>> > +config FASTBOOT_FLASH_BLOCK_DEVICE_ID
>> > +     int "Define FASTBOOT block device id"
>> > +     depends on FASTBOOT_FLASH_BLOCK
>> > +     help
>> > +       "Fastboot block device id"
>> > +
>> >   config FASTBOOT_GPT_NAME
>> >       string "Target name for updating GPT"
>> >       depends on FASTBOOT_FLASH_MMC && EFI_PARTITION
>>
>>