U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: Janne Grunau <j@jannau.net>
Cc: u-boot@lists.denx.de, j@jannau.net
Subject: Re: [PATCH] apple_m1_defconfig: Bump CONFIG_LMB_MAX_REGIONS to 64
Date: Mon, 13 Mar 2023 15:31:32 +0100	[thread overview]
Message-ID: <87v8j4bu4b.fsf@bloch.sibelius.xs4all.nl> (raw)
In-Reply-To: <20230313-apple_m1_defconfig_lmb_max_regions-v1-1-d2eac7bcfd20@jannau.net> (message from Janne Grunau on Mon, 13 Mar 2023 14:54:32 +0100)

> From: Janne Grunau <j@jannau.net>
> Date: Mon, 13 Mar 2023 14:54:32 +0100
> 
> Apple silicon SoCs have numerous embedded co-processors with pre-loaded
> firmware. The co-processors text and data sections need to be mapped via
> DART iommus controlled by the main processor. Those sections are
> exported as reserved-memory. Bump CONFIG_LMB_MAX_REGIONS from 8 to 64 to
> deal with the large amount of reserved-memory regions.

We recently bumped the default for CONFIG_LMB_MAX_REGIONS from 8 to
16, but 64 would be a safer value for this platform as there are more
co-processor drivers in the pipeline that may add reserved-memory
regions.  These machines have plenty of memory.

> Signed-off-by: Janne Grunau <j@jannau.net>

Reviewed-by: Mark Kettenis <kettenis@openbsd.org>

> ---
>  configs/apple_m1_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig
> index b4ecf73cbc78..755560971e57 100644
> --- a/configs/apple_m1_defconfig
> +++ b/configs/apple_m1_defconfig
> @@ -21,3 +21,4 @@ CONFIG_SYS_WHITE_ON_BLACK=y
>  CONFIG_NO_FB_CLEAR=y
>  CONFIG_VIDEO_SIMPLE=y
>  # CONFIG_GENERATE_SMBIOS_TABLE is not set
> +CONFIG_LMB_MAX_REGIONS=64
> 
> ---
> base-commit: 6c1cdf158c4f3ccc8c5f9552f049a3386899dcd2
> change-id: 20230313-apple_m1_defconfig_lmb_max_regions-a18f5612d3c3
> 
> Best regards,
> -- 
> Janne Grunau <j@jannau.net>
> 
> 

  reply	other threads:[~2023-03-13 14:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 13:54 [PATCH] apple_m1_defconfig: Bump CONFIG_LMB_MAX_REGIONS to 64 Janne Grunau
2023-03-13 14:31 ` Mark Kettenis [this message]
2023-03-17 16:43   ` Tom Rini
2023-03-17 18:16     ` Mark Kettenis
2023-03-30  1:54 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8j4bu4b.fsf@bloch.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=j@jannau.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox