From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98882C433EF for ; Mon, 30 May 2022 09:21:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 07785842B2; Mon, 30 May 2022 11:21:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=tkos.co.il Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=tkos.co.il header.i=@tkos.co.il header.b="ZXbESytL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 91CC1842A8; Mon, 30 May 2022 11:21:34 +0200 (CEST) Received: from mail.tkos.co.il (wiki.tkos.co.il [84.110.109.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1DD70842B2 for ; Mon, 30 May 2022 11:21:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=tkos.co.il Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=baruch@tkos.co.il Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.tkos.co.il (Postfix) with ESMTPS id 1EA6D4409AF; Mon, 30 May 2022 12:21:27 +0300 (IDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1653902487; bh=yKIg7V718puc6ZaKD5ZlLDVdDqvIg3/Yv9vogXSaQsI=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=ZXbESytLZm5AcWj0NV4Yvn02vQDaEZHj3wkat/mMWfITBC434t2HlebgaC6cYb7xJ jnIDY5QpTs2Ovk4X/1QaPubX3/hHMNPYe0D1VDBnY0VXyPBgyvdfbkX79455FZjTFh KI1MNjmCfQTmD0kFUY8l7ET47wbiYwOaCmqrGL/29D/H2m9IEpRZJzbKBN57W28Ac3 S0GNHew18FyU877e75BPL71fOt+15MBzPt7IRvg2kKPP0muPsiBppJJ/rIrdxfKra6 nbbtjFZMtcqU11sMYWCW/jkAESLoRHA7lm/1HRsYjDDTvOElQuZ0p28hbxmHZyR8hB lhTrOmG/vYXYg== References: <20220530084235.13027-1-pali@kernel.org> User-agent: mu4e 1.6.10; emacs 27.1 From: Baruch Siach To: Pali =?utf-8?Q?Roh=C3=A1r?= Cc: Stefan Roese , Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH] tlv_eeprom: Add missing CRC32 dependency Date: Mon, 30 May 2022 12:20:46 +0300 In-reply-to: <20220530084235.13027-1-pali@kernel.org> Message-ID: <87v8tne5pi.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Pali, On Mon, May 30 2022, Pali Roh=C3=A1r wrote: > tlv_eeprom uses crc32() function, so add dependency into Kconfig. > > Signed-off-by: Pali Roh=C3=A1r Reviewed-by: Baruch Siach Thanks, baruch > --- > cmd/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index 69c1814d24af..d513d808aa3d 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -167,6 +167,7 @@ config CMD_REGINFO > config CMD_TLV_EEPROM > bool "tlv_eeprom" > depends on I2C_EEPROM > + select CRC32 > help > Display and program the system EEPROM data block in ONIE Tlvinfo > format. TLV stands for Type-Length-Value. > @@ -175,6 +176,7 @@ config SPL_CMD_TLV_EEPROM > bool "tlv_eeprom for SPL" > depends on SPL_I2C_EEPROM > select SPL_DRIVERS_MISC > + select SPL_CRC32 > help > Read system EEPROM data block in ONIE Tlvinfo format from SPL. --=20 ~. .~ Tk Open Systems =3D}------------------------------------------------ooO--U--Ooo------------= {=3D - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -