* Re: [PATCH] tlv_eeprom: Add missing CRC32 dependency
2022-05-30 8:42 [PATCH] tlv_eeprom: Add missing CRC32 dependency Pali Rohár
@ 2022-05-30 9:20 ` Baruch Siach
2022-05-30 9:25 ` Stefan Roese
2022-07-21 12:25 ` Stefan Roese
2 siblings, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2022-05-30 9:20 UTC (permalink / raw)
To: Pali Rohár; +Cc: Stefan Roese, Simon Glass, u-boot
Hi Pali,
On Mon, May 30 2022, Pali Rohár wrote:
> tlv_eeprom uses crc32() function, so add dependency into Kconfig.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Baruch Siach <baruch@tkos.co.il>
Thanks,
baruch
> ---
> cmd/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 69c1814d24af..d513d808aa3d 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -167,6 +167,7 @@ config CMD_REGINFO
> config CMD_TLV_EEPROM
> bool "tlv_eeprom"
> depends on I2C_EEPROM
> + select CRC32
> help
> Display and program the system EEPROM data block in ONIE Tlvinfo
> format. TLV stands for Type-Length-Value.
> @@ -175,6 +176,7 @@ config SPL_CMD_TLV_EEPROM
> bool "tlv_eeprom for SPL"
> depends on SPL_I2C_EEPROM
> select SPL_DRIVERS_MISC
> + select SPL_CRC32
> help
> Read system EEPROM data block in ONIE Tlvinfo format from SPL.
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tlv_eeprom: Add missing CRC32 dependency
2022-05-30 8:42 [PATCH] tlv_eeprom: Add missing CRC32 dependency Pali Rohár
2022-05-30 9:20 ` Baruch Siach
@ 2022-05-30 9:25 ` Stefan Roese
2022-07-21 12:25 ` Stefan Roese
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Roese @ 2022-05-30 9:25 UTC (permalink / raw)
To: Pali Rohár, Simon Glass, Baruch Siach; +Cc: u-boot
On 30.05.22 10:42, Pali Rohár wrote:
> tlv_eeprom uses crc32() function, so add dependency into Kconfig.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> cmd/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 69c1814d24af..d513d808aa3d 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -167,6 +167,7 @@ config CMD_REGINFO
> config CMD_TLV_EEPROM
> bool "tlv_eeprom"
> depends on I2C_EEPROM
> + select CRC32
> help
> Display and program the system EEPROM data block in ONIE Tlvinfo
> format. TLV stands for Type-Length-Value.
> @@ -175,6 +176,7 @@ config SPL_CMD_TLV_EEPROM
> bool "tlv_eeprom for SPL"
> depends on SPL_I2C_EEPROM
> select SPL_DRIVERS_MISC
> + select SPL_CRC32
> help
> Read system EEPROM data block in ONIE Tlvinfo format from SPL.
>
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tlv_eeprom: Add missing CRC32 dependency
2022-05-30 8:42 [PATCH] tlv_eeprom: Add missing CRC32 dependency Pali Rohár
2022-05-30 9:20 ` Baruch Siach
2022-05-30 9:25 ` Stefan Roese
@ 2022-07-21 12:25 ` Stefan Roese
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Roese @ 2022-07-21 12:25 UTC (permalink / raw)
To: Pali Rohár, Simon Glass, Baruch Siach; +Cc: u-boot
On 30.05.22 10:42, Pali Rohár wrote:
> tlv_eeprom uses crc32() function, so add dependency into Kconfig.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Applied to u-boot-marvell/master
Thanks,
Stefan
> ---
> cmd/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 69c1814d24af..d513d808aa3d 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -167,6 +167,7 @@ config CMD_REGINFO
> config CMD_TLV_EEPROM
> bool "tlv_eeprom"
> depends on I2C_EEPROM
> + select CRC32
> help
> Display and program the system EEPROM data block in ONIE Tlvinfo
> format. TLV stands for Type-Length-Value.
> @@ -175,6 +176,7 @@ config SPL_CMD_TLV_EEPROM
> bool "tlv_eeprom for SPL"
> depends on SPL_I2C_EEPROM
> select SPL_DRIVERS_MISC
> + select SPL_CRC32
> help
> Read system EEPROM data block in ONIE Tlvinfo format from SPL.
>
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 4+ messages in thread