From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BDE1C4338F for ; Fri, 30 Jul 2021 12:31:08 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9741F6024A for ; Fri, 30 Jul 2021 12:31:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9741F6024A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C5544832C5; Fri, 30 Jul 2021 14:29:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="eydNJS9h"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 72798832EF; Fri, 30 Jul 2021 14:29:21 +0200 (CEST) Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 07C2083310 for ; Fri, 30 Jul 2021 14:29:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mkorpershoek@baylibre.com Received: by mail-wm1-x32a.google.com with SMTP id o7-20020a05600c5107b0290257f956e02dso2663955wms.1 for ; Fri, 30 Jul 2021 05:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=T5ji4+YdB1xROcgS4tTzyeB0RcBlnqg55EmlR+mhg+c=; b=eydNJS9h6PphwH8FcEqQrebmwGckc3o3PCtVlMSzgCC8VVEUpbtbiXY4O+Qw/TW3Yx PoCNWu6mO3A7wMIykOOr9yiAGFTDJky8jBfzG7u0ZwLpyjrsMv6macEpP/8ywzA50923 8SspP9+qLRPTM3QsVczmYVnOlHn7aJeAivQdWrSSp5/gkoZWvlobPHrz1BAUJIEewC9T zGqhqRY5SlUi7w19SvXAZxgj5M/244kk0V4QXCc5E6sNBxuJPI0S4tBJ8zDZU+6jmXQW VrRBBHOdFzMxEtWmhBBy0H0PpglpSDJiqgCjFWprwR4h38uy6cE4M2czr3os0cZsmruE X42A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=T5ji4+YdB1xROcgS4tTzyeB0RcBlnqg55EmlR+mhg+c=; b=ZF2WFXpTG+ksE0yvw0n/JQ0wQMN0iL5N9ksA3iAnj2idfTv6PVUOzpQKdM2c8TifNx etHX9vRISa+lT0aGqh21orq7y4Uj3Z17gdAvCpm4VEyjjiCL5gQTUbGraYn936IC6HC0 809hDuc49rx2O+8XiwYsya/Zi3yxTxUsiZuD+TVpmfJzFSjndSGrdkAwiILCqDtPRV8m OqsTAgV/MEyp7y4K1NDQCnQusOo5dt2NM+m4wUDJ67X7GHog2NVam+0KZB5nCZByr/If c1zC88VnMLLRBQwnjYiFSe4u5WMeOaPiAodixSDodn/KFD9RM8K2iYVO7UuSf4eTZqDO hWrg== X-Gm-Message-State: AOAM531jELC1NzeM/50pybhfaUYlDsnL9fS3LxBn0PwOSI1KJgy6EsFn q2bXjL/HHZoxfwZggIf3J99qyQ== X-Google-Smtp-Source: ABdhPJwBGjpGOdWp/ipTzN8TGaPSoQqsof5JFlNWGhvRdxe9sufsF9jyFLD1WZgO58b0/hkj74wjEg== X-Received: by 2002:a7b:c351:: with SMTP id l17mr2650588wmj.120.1627648154428; Fri, 30 Jul 2021 05:29:14 -0700 (PDT) Received: from localhost ([2a01:cb19:826e:8e00:6536:8a22:58a3:a175]) by smtp.gmail.com with ESMTPSA id f2sm1522830wrq.69.2021.07.30.05.29.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jul 2021 05:29:14 -0700 (PDT) From: Mattijs Korpershoek To: Neil Armstrong Cc: u-boot-amlogic@groups.io, u-boot@lists.denx.de Subject: Re: [PATCH 0/5] meson64_android: use BCB for reboot reason In-Reply-To: <2a76c618-8d6a-8a1c-19dd-2ce899c49459@baylibre.com> References: <20210730085531.2849834-1-mkorpershoek@baylibre.com> <2a76c618-8d6a-8a1c-19dd-2ce899c49459@baylibre.com> Date: Fri, 30 Jul 2021 14:29:13 +0200 Message-ID: <87v94s56jq.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Neil, Neil Armstrong writes: > On 30/07/2021 10:55, Mattijs Korpershoek wrote: >> The SEI-610 and SEI-510 boards are well supported in the >> Android Open Source project via the yukawa [1] platform. >> >> Their U-Boot version, despite being public [2] is not in mainline. >> >> Android has multiple OSes it can boot into: >> * Main android >> * Recovery OS >> * Fastbootd (recovery OS with fastboot mode) >> * Bootloader (U-Boot) with fastboot mode >> >> The decision of which OS to boot into is taken by the bootloader based on >> the "reboot reason". >> >> For amlogic boards, we pass the reboot reason via a custom smc call. >> This support is limited: we don't r >> >> These series reworks the reboot reason handling to use the BCB, which >> is the standard Android way. >> >> [1] https://android.googlesource.com/device/amlogic/yukawa >> [2] https://gitlab.com/baylibre/amlogic/atv/u-boot/-/tree/u-boot/v2021.07/integ >> >> Mattijs Korpershoek (5): >> Revert "ARM: meson: Add support for fastboot_set_reboot_flag()" >> configs: meson64_android: use BCB for reboot to bootloader >> configs: meson64_android: implement recovery boot via BCB >> configs: meson64_android: reboot to fastbootd from bootloader >> configs: sei610/sei510: set CONFIG_CMD_BCB=y >> >> arch/arm/mach-meson/board-common.c | 34 ----------------- >> configs/sei510_defconfig | 1 + >> configs/sei610_defconfig | 1 + >> include/configs/meson64_android.h | 60 ++++++++++++++++++++---------- >> 4 files changed, 42 insertions(+), 54 deletions(-) >> > > Looks fine, but I'll move the patch 1 as last. Thanks for your review. > > Can you re-post ? > > Please add: > Acked-by: Neil Armstrong > > to all patches if you repost. I've reposted a v2 with your ack. Mattijs > > Neil