From: "Marcin Niestrój" <m.niestroj@grinn-global.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] am335x: chilisom: Initial support for different DDR3 chips
Date: Mon, 21 Jan 2019 18:16:04 +0100 [thread overview]
Message-ID: <87va2i53u3.fsf@grinn-global.com> (raw)
In-Reply-To: <20190121170533.GL18346@bill-the-cat>
Hi Tom,
Tom Rini <trini@konsulko.com> writes:
> On Mon, Jan 21, 2019 at 12:28:42PM +0100, Maciej Zagrabski wrote:
>> Manufacturing process changes caused that several versions
>> of chiliSOM with different memory chips are present on market.
>> Patch introduces method for selecting actual memory chip
>> on som through Kconfig. Patch creates space for adding more
>> memory chips in future.
>>
>> Memory chip configuration is constructed by preprocesor
>> basing on DDR3 part no from Kconfig. To do this,
>> Makefile translates string from Kconfig into preprocesor token.
>>
>> Signed-off-by: Maciej Zagrabski <maciej.zagrabski@grinn-global.com>
> [snip]
>> diff --git a/arch/arm/mach-omap2/am33xx/Makefile b/arch/arm/mach-omap2/am33xx/Makefile
>> index 61c76d045f3..81c7a82f21e 100644
>> --- a/arch/arm/mach-omap2/am33xx/Makefile
>> +++ b/arch/arm/mach-omap2/am33xx/Makefile
>> @@ -26,3 +26,4 @@ obj-y += fdt.o
>> obj-$(CONFIG_CLOCK_SYNTHESIZER) += clk_synthesizer.o
>>
>> obj-$(CONFIG_AM33XX_CHILISOM) += chilisom.o
>> +CFLAGS_chilisom.o := -DCHILISOM_DDR3_CHIP_NAME=$(CONFIG_CHILISOM_DDR3_CHIP_NAME)
>
> I'm not super happy with this. Can't we use __stringify() in the code
> directly instead?
The problem is that we need the opposite convertion. Kconfig is
generating macro value with "" quotes. We need that macro without
quotes in C code.
--
Marcin Niestrój
prev parent reply other threads:[~2019-01-21 17:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 11:28 [U-Boot] [PATCH] am335x: chilisom: Initial support for different DDR3 chips Maciej Zagrabski
2019-01-21 17:05 ` Tom Rini
2019-01-21 17:16 ` Marcin Niestrój [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va2i53u3.fsf@grinn-global.com \
--to=m.niestroj@grinn-global.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox