From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcin =?utf-8?Q?Niestr=C3=B3j?= Date: Mon, 21 Jan 2019 18:16:04 +0100 Subject: [U-Boot] [PATCH] am335x: chilisom: Initial support for different DDR3 chips In-Reply-To: <20190121170533.GL18346@bill-the-cat> References: <20190121112842.8999-1-maciej.zagrabski@grinn-global.com> <20190121170533.GL18346@bill-the-cat> Message-ID: <87va2i53u3.fsf@grinn-global.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de Hi Tom, Tom Rini writes: > On Mon, Jan 21, 2019 at 12:28:42PM +0100, Maciej Zagrabski wrote: >> Manufacturing process changes caused that several versions >> of chiliSOM with different memory chips are present on market. >> Patch introduces method for selecting actual memory chip >> on som through Kconfig. Patch creates space for adding more >> memory chips in future. >> >> Memory chip configuration is constructed by preprocesor >> basing on DDR3 part no from Kconfig. To do this, >> Makefile translates string from Kconfig into preprocesor token. >> >> Signed-off-by: Maciej Zagrabski > [snip] >> diff --git a/arch/arm/mach-omap2/am33xx/Makefile b/arch/arm/mach-omap2/a= m33xx/Makefile >> index 61c76d045f3..81c7a82f21e 100644 >> --- a/arch/arm/mach-omap2/am33xx/Makefile >> +++ b/arch/arm/mach-omap2/am33xx/Makefile >> @@ -26,3 +26,4 @@ obj-y +=3D fdt.o >> obj-$(CONFIG_CLOCK_SYNTHESIZER) +=3D clk_synthesizer.o >> >> obj-$(CONFIG_AM33XX_CHILISOM) +=3D chilisom.o >> +CFLAGS_chilisom.o :=3D -DCHILISOM_DDR3_CHIP_NAME=3D$(CONFIG_CHILISOM_DD= R3_CHIP_NAME) > > I'm not super happy with this. Can't we use __stringify() in the code > directly instead? The problem is that we need the opposite convertion. Kconfig is generating macro value with "" quotes. We need that macro without quotes in C code. -- Marcin Niestr=C3=B3j