From: Peter Korsgaard <jacmet@sunsite.dk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] lib/string: memmove: use memcpy if it is safe to do so
Date: Sat, 29 Oct 2011 01:28:06 +0200 [thread overview]
Message-ID: <87vcr8ofw9.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20111028202530.1231B1809855@gemini.denx.de> (Wolfgang Denk's message of "Fri, 28 Oct 2011 22:25:30 +0200")
>>>>> "Wolfgang" == Wolfgang Denk <wd@denx.de> writes:
Hi,
>> memmove is used in a number of performance critical places, like copying the
>> linux kernel from nor flash to ram, so optimizing it can be interesting.
>>
>> Unfortunately, an arch specific version of memmove often isn't used, and
>> not supported at all on a number of archs (arm/mips/nds32/nios2/x86) -
>> But memcpy typically is.
Wolfgang> So you are adding code, making the system even less efficient? This
Wolfgang> sounds to be acounter-productive approach.
Well, slightly less efficient for the (uncommon) situation where
src/dest overlaps in return for significantly more efficiency for the
situation where they don't.
Wolfgang> Can you not instead arrange for arch specific, optimized versions
Wolfgang> memmove() to be used?
That's another option, but more work for implementers - So I would
prefer this trivial patch instead.
But I'll drop it if you disagree.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2011-10-28 23:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 8:04 [U-Boot] [PATCH] lib/string: memmove: use memcpy if it is safe to do so Peter Korsgaard
2011-10-28 20:25 ` Wolfgang Denk
2011-10-28 23:28 ` Peter Korsgaard [this message]
2011-10-29 13:29 ` Wolfgang Denk
2011-10-29 0:35 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcr8ofw9.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox