public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH] dfu: Correct dependencies for DFU_TFTP
@ 2026-03-17  1:24 Tom Rini
  2026-03-26  8:56 ` Mattijs Korpershoek
  2026-04-08  9:26 ` Mattijs Korpershoek
  0 siblings, 2 replies; 3+ messages in thread
From: Tom Rini @ 2026-03-17  1:24 UTC (permalink / raw)
  To: u-boot; +Cc: Mattijs Korpershoek

As exposed by "make randconfig", we have an issue with the dependencies
for DFU_TFTP. This really depends on the legacy networking stack being
enabled, not just lwIP not being enabled (as it will fail in the NO_NET
case).

Signed-off-by: Tom Rini <trini@konsulko.com>
---
Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>
---
 drivers/dfu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
index 962bda40ad2d..1d5d8caa7daa 100644
--- a/drivers/dfu/Kconfig
+++ b/drivers/dfu/Kconfig
@@ -20,7 +20,7 @@ if DFU
 config DFU_TFTP
 	bool "DFU via TFTP"
 	depends on NETDEVICES
-	depends on !NET_LWIP
+	depends on NET # Legacy stack only
 	select UPDATE_COMMON
 	select DFU_OVER_TFTP
 	help
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dfu: Correct dependencies for DFU_TFTP
  2026-03-17  1:24 [PATCH] dfu: Correct dependencies for DFU_TFTP Tom Rini
@ 2026-03-26  8:56 ` Mattijs Korpershoek
  2026-04-08  9:26 ` Mattijs Korpershoek
  1 sibling, 0 replies; 3+ messages in thread
From: Mattijs Korpershoek @ 2026-03-26  8:56 UTC (permalink / raw)
  To: Tom Rini, u-boot; +Cc: Mattijs Korpershoek

Hi Tom,

Thank you for the patch.

On Mon, Mar 16, 2026 at 19:24, Tom Rini <trini@konsulko.com> wrote:

> As exposed by "make randconfig", we have an issue with the dependencies
> for DFU_TFTP. This really depends on the legacy networking stack being
> enabled, not just lwIP not being enabled (as it will fail in the NO_NET
> case).
>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> ---
> Cc: Mattijs Korpershoek <mkorpershoek@kernel.org>
> ---
>  drivers/dfu/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
> index 962bda40ad2d..1d5d8caa7daa 100644
> --- a/drivers/dfu/Kconfig
> +++ b/drivers/dfu/Kconfig
> @@ -20,7 +20,7 @@ if DFU
>  config DFU_TFTP
>  	bool "DFU via TFTP"
>  	depends on NETDEVICES
> -	depends on !NET_LWIP
> +	depends on NET # Legacy stack only
>  	select UPDATE_COMMON
>  	select DFU_OVER_TFTP
>  	help
> -- 
> 2.43.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dfu: Correct dependencies for DFU_TFTP
  2026-03-17  1:24 [PATCH] dfu: Correct dependencies for DFU_TFTP Tom Rini
  2026-03-26  8:56 ` Mattijs Korpershoek
@ 2026-04-08  9:26 ` Mattijs Korpershoek
  1 sibling, 0 replies; 3+ messages in thread
From: Mattijs Korpershoek @ 2026-04-08  9:26 UTC (permalink / raw)
  To: u-boot, Tom Rini

Hi,

On Mon, 16 Mar 2026 19:24:35 -0600, Tom Rini wrote:
> As exposed by "make randconfig", we have an issue with the dependencies
> for DFU_TFTP. This really depends on the legacy networking stack being
> enabled, not just lwIP not being enabled (as it will fail in the NO_NET
> case).
> 
> 

Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu (u-boot-dfu)

[1/1] dfu: Correct dependencies for DFU_TFTP
      https://source.denx.de/u-boot/custodians/u-boot-dfu/-/commit/93a362d9f29227b94927ae1534e765a45cefc807

--
Mattijs

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-08  9:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-17  1:24 [PATCH] dfu: Correct dependencies for DFU_TFTP Tom Rini
2026-03-26  8:56 ` Mattijs Korpershoek
2026-04-08  9:26 ` Mattijs Korpershoek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox