* Re: [PATCH v2] usb: gadget: Kconfig: Correct Qualcomm config name used
2025-12-24 4:47 [PATCH v2] usb: gadget: Kconfig: Correct Qualcomm config name used Balaji Selvanathan
@ 2025-12-26 7:40 ` Sumit Garg
2026-01-05 9:40 ` Mattijs Korpershoek
2026-01-16 18:03 ` Casey Connolly
2 siblings, 0 replies; 4+ messages in thread
From: Sumit Garg @ 2025-12-26 7:40 UTC (permalink / raw)
To: Balaji Selvanathan
Cc: lukma, mkorpershoek, marex, trini, kever.yang, jonas,
quentin.schulz, gchan9527, u-boot
On Wed, Dec 24, 2025 at 10:17:47AM +0530, Balaji Selvanathan wrote:
> Correct ARCH_QCOM to ARCH_SNAPDRAGON as ARCH_QCOM is outdated/unused
> config. Using ARCH_QCOM was causing USB fastboot mode to fail.
>
> Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
> ---
> v2:
> - Corrected ARCH_QCOM to ARCH_SNAPDRAGON
> - Link to v1: https://lore.kernel.org/u-boot/20251114063507.3834973-1-balaji.selvanathan@oss.qualcomm.com/
> ---
> drivers/usb/gadget/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
-Sumit
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 7e08aeab904..ebb306852a6 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -61,7 +61,7 @@ config USB_GADGET_VENDOR_NUM
> default 0x0955 if ARCH_TEGRA
> default 0x1f3a if ARCH_SUNXI
> default 0x2207 if ARCH_ROCKCHIP
> - default 0x18d1 if ARCH_QCOM
> + default 0x18d1 if ARCH_SNAPDRAGON
> default 0x0
> help
> Vendor ID of the USB device emulated, reported to the host device.
> @@ -89,7 +89,7 @@ config USB_GADGET_PRODUCT_NUM
> default 0x350b if ROCKCHIP_RK3588
> default 0x350c if ROCKCHIP_RK3528
> default 0x350e if ROCKCHIP_RK3576
> - default 0x4ee0 if ARCH_QCOM
> + default 0x4ee0 if ARCH_SNAPDRAGON
> default 0x0
> help
> Product ID of the USB device emulated, reported to the host device.
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] usb: gadget: Kconfig: Correct Qualcomm config name used
2025-12-24 4:47 [PATCH v2] usb: gadget: Kconfig: Correct Qualcomm config name used Balaji Selvanathan
2025-12-26 7:40 ` Sumit Garg
@ 2026-01-05 9:40 ` Mattijs Korpershoek
2026-01-16 18:03 ` Casey Connolly
2 siblings, 0 replies; 4+ messages in thread
From: Mattijs Korpershoek @ 2026-01-05 9:40 UTC (permalink / raw)
To: Balaji Selvanathan, lukma, mkorpershoek, marex, trini, kever.yang,
jonas, quentin.schulz, gchan9527, balaji.selvanathan, u-boot,
Casey Connolly
Hi Balaji,
Thank you for the patch.
On Wed, Dec 24, 2025 at 10:17, Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com> wrote:
> Correct ARCH_QCOM to ARCH_SNAPDRAGON as ARCH_QCOM is outdated/unused
> config. Using ARCH_QCOM was causing USB fastboot mode to fail.
>
> Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
Acked-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
Casey, this is assigned to you on patchwork. Feel free to pick it up.
If you want me to take it instead, please assign to me on patchwork!
Mattijs
> ---
> v2:
> - Corrected ARCH_QCOM to ARCH_SNAPDRAGON
> - Link to v1: https://lore.kernel.org/u-boot/20251114063507.3834973-1-balaji.selvanathan@oss.qualcomm.com/
> ---
> drivers/usb/gadget/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 7e08aeab904..ebb306852a6 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -61,7 +61,7 @@ config USB_GADGET_VENDOR_NUM
> default 0x0955 if ARCH_TEGRA
> default 0x1f3a if ARCH_SUNXI
> default 0x2207 if ARCH_ROCKCHIP
> - default 0x18d1 if ARCH_QCOM
> + default 0x18d1 if ARCH_SNAPDRAGON
> default 0x0
> help
> Vendor ID of the USB device emulated, reported to the host device.
> @@ -89,7 +89,7 @@ config USB_GADGET_PRODUCT_NUM
> default 0x350b if ROCKCHIP_RK3588
> default 0x350c if ROCKCHIP_RK3528
> default 0x350e if ROCKCHIP_RK3576
> - default 0x4ee0 if ARCH_QCOM
> + default 0x4ee0 if ARCH_SNAPDRAGON
> default 0x0
> help
> Product ID of the USB device emulated, reported to the host device.
> --
> 2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] usb: gadget: Kconfig: Correct Qualcomm config name used
2025-12-24 4:47 [PATCH v2] usb: gadget: Kconfig: Correct Qualcomm config name used Balaji Selvanathan
2025-12-26 7:40 ` Sumit Garg
2026-01-05 9:40 ` Mattijs Korpershoek
@ 2026-01-16 18:03 ` Casey Connolly
2 siblings, 0 replies; 4+ messages in thread
From: Casey Connolly @ 2026-01-16 18:03 UTC (permalink / raw)
To: lukma, mkorpershoek, marex, trini, kever.yang, jonas,
quentin.schulz, gchan9527, u-boot, Balaji Selvanathan
On Wed, 24 Dec 2025 10:17:47 +0530, Balaji Selvanathan wrote:
> Correct ARCH_QCOM to ARCH_SNAPDRAGON as ARCH_QCOM is outdated/unused
> config. Using ARCH_QCOM was causing USB fastboot mode to fail.
>
>
Applied, thanks!
[1/1] usb: gadget: Kconfig: Correct Qualcomm config name used
https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/fe3b827a5937
Best regards,
--
// Casey (she/they)
^ permalink raw reply [flat|nested] 4+ messages in thread