Re: [PATCH v2 4/8] arm: dts: k3-am625-sk: Enable emmc in SPL

Dhruva Gole
2023-09-19T12:08:47Z

On Sep 19, 2023 at 06:19:02 -0500, Nishanth Menon wrote:
> On 07:35-20230919, Sverdlin, Alexander wrote:
> > Hello Sjoerd,
> >
> > On Thu, 2023-04-06 at 20:55 +0200, Sjoerd Simons wrote:
> > > sdhci0 on the k3-am625-sk is the emmc, enable this in SPL as well to
> > > allow booting from that media.
> > >
> > > Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
> > > Reviewed-by: Tom Rini <trini@konsulko.com>
> >
> > thanks for the patch! I've tested the eMMC boot on AM625 SK
> > and this was exactly the missing piece, with the patch it boots fine:
> >
> > Tested-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
>
> note: I have also posted https://lore.kernel.org/r/20230911162535.1044560-4-nm@ti.com
>
> That should take care of this in the kernel sync next time around.
>
> But, for next:
>
> Reviewed-by: Nishanth Menon <nm@ti.com>
>

Reviewed-by: Dhruva Gole <d-gole@ti.com>

> >
> > > ---
> > >
> > > (no changes since v1)
> > >
> > >  arch/arm/dts/k3-am625-sk-u-boot.dtsi | 8 ++++++++
> > >  1 file changed, 8 insertions(+)
> > >
> > > diff --git a/arch/arm/dts/k3-am625-sk-u-boot.dtsi b/arch/arm/dts/k3-am625-sk-u-boot.dtsi
> > > index 0def84b4cf0..5f90a4b56f1 100644
> > > --- a/arch/arm/dts/k3-am625-sk-u-boot.dtsi
> > > +++ b/arch/arm/dts/k3-am625-sk-u-boot.dtsi
> > > @@ -92,6 +92,14 @@
> > >         bootph-pre-ram;
> > >  };
> > >
> > > +&sdhci0 {
> > > +       bootph-pre-ram;
> > > +};
> > > +
> > > +&main_mmc0_pins_default {
> > > +       bootph-pre-ram;
> > > +};
> > > +
> > >  &sdhci1 {
> > >         bootph-pre-ram;
> > >  };
> >
> > --
> > Alexander Sverdlin
> > Siemens AG
> > www.siemens.com
>
> --
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
>

--
Best regards,
Dhruva Gole <d-gole@ti.com>