From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Alexey Romanov <avromanov@salutedevices.com>,
michal.simek@amd.com, marex@denx.de, michael@walle.cc,
stcarlso@linux.microsoft.com, tobias@waldekranz.com,
seanedmond@microsoft.com, abdellatif.elkhlifi@arm.com,
neil.armstrong@linaro.org, n-jain1@ti.com, xypron.glpk@gmx.de,
dario.binacchi@amarulasolutions.com,
michael@amarulasolutions.com, frieder.schrempf@kontron.de,
sjg@chromium.org, hs@denx.de, sean.anderson@seco.com,
dimorinny@google.com, patrick.delaunay@foss.st.com
Cc: u-boot@lists.denx.de, kernel@salutedevices.com,
Alexey Romanov <avromanov@salutedevices.com>
Subject: Re: [PATCH v1 10/12] fastboot: check device type for SPI NAND too
Date: Tue, 02 Jan 2024 14:00:02 +0100 [thread overview]
Message-ID: <87wmsr51rh.fsf@baylibre.com> (raw)
In-Reply-To: <20231228153922.84323-11-avromanov@salutedevices.com>
Hi Alexey,
Thank you for the patch.
On Thu, Dec 28, 2023 at 18:39, Alexey Romanov <avromanov@salutedevices.com> wrote:
> SPI NAND devices also supports 'fastboot erase / flash' commands.
>
> Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> drivers/fastboot/fb_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastboot/fb_nand.c
> index 6d3a900c77..39d888301f 100644
> --- a/drivers/fastboot/fb_nand.c
> +++ b/drivers/fastboot/fb_nand.c
> @@ -53,7 +53,7 @@ static int fb_nand_lookup(const char *partname,
> return ret;
> }
>
> - if (dev->id->type != MTD_DEV_TYPE_NAND) {
> + if (dev->id->type != MTD_DEV_TYPE_NAND && dev->id->type != MTD_DEV_TYPE_SPINAND) {
> pr_err("partition '%s' is not stored on a NAND device",
> partname);
> fastboot_fail("not a NAND device", response);
> --
> 2.30.1
next prev parent reply other threads:[~2024-01-02 13:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 15:39 [PATCH v1 00/12] Support SPI NAND in fastboot protocol Alexey Romanov
2023-12-28 15:39 ` [PATCH v1 01/12] nand: move NAND initialization API to nand/core.c Alexey Romanov
2023-12-28 16:51 ` Sean Anderson
2023-12-28 15:39 ` [PATCH v1 02/12] nand: don't overwrite mtd name in nand_register() Alexey Romanov
2023-12-28 15:39 ` [PATCH v1 03/12] nand: move nand_util.c to NAND core folder Alexey Romanov
2023-12-28 15:39 ` [PATCH v1 04/12] nand: move nand_erase_opts() to core NAND folder Alexey Romanov
2024-01-03 8:21 ` Michael Nazzareno Trimarchi
2023-12-28 15:39 ` [PATCH v1 05/12] spi: add board_nand_init() function Alexey Romanov
2023-12-28 15:39 ` [PATCH v1 06/12] spi: use nand_register() instead of add_mtd_device() Alexey Romanov
2023-12-28 15:39 ` [PATCH v1 07/12] mtdparts: use negative error codes Alexey Romanov
2024-01-03 8:24 ` Michael Nazzareno Trimarchi
2023-12-28 15:39 ` [PATCH v1 08/12] jffs2: " Alexey Romanov
2023-12-28 15:39 ` [PATCH v1 09/12] cmd: allow to enable CMD_NAND for SPI NAND devices Alexey Romanov
2023-12-28 16:55 ` Sean Anderson
2023-12-28 15:39 ` [PATCH v1 10/12] fastboot: check device type for SPI NAND too Alexey Romanov
2023-12-28 16:54 ` Sean Anderson
2024-01-02 13:00 ` Mattijs Korpershoek [this message]
2023-12-28 15:39 ` [PATCH v1 11/12] fastboot: enable FASTBOOT_FLASH option for SPI NAND devices Alexey Romanov
2023-12-28 16:55 ` Sean Anderson
2024-01-02 13:00 ` Mattijs Korpershoek
2023-12-28 15:39 ` [PATCH v1 12/12] fastboot: fb_nand: add missing newlines in pr_err() macro Alexey Romanov
2023-12-28 16:54 ` Sean Anderson
2024-01-02 13:01 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmsr51rh.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=abdellatif.elkhlifi@arm.com \
--cc=avromanov@salutedevices.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=dimorinny@google.com \
--cc=frieder.schrempf@kontron.de \
--cc=hs@denx.de \
--cc=kernel@salutedevices.com \
--cc=marex@denx.de \
--cc=michael@amarulasolutions.com \
--cc=michael@walle.cc \
--cc=michal.simek@amd.com \
--cc=n-jain1@ti.com \
--cc=neil.armstrong@linaro.org \
--cc=patrick.delaunay@foss.st.com \
--cc=sean.anderson@seco.com \
--cc=seanedmond@microsoft.com \
--cc=sjg@chromium.org \
--cc=stcarlso@linux.microsoft.com \
--cc=tobias@waldekranz.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox