From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] pci: Device scanning range fix.
Date: Mon, 25 Apr 2016 15:38:36 +0900 [thread overview]
Message-ID: <87wpnmp503.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <CAEUhbmU1v2v2Qg8xGaAStV3OEmjK2+mwm3sma+Dqk=BY1qLFmw@mail.gmail.com>
On Mon, 25 Apr 2016 15:27:19 +0900,
Bin Meng wrote:
>
> Hi Yoshinori,
>
> On Mon, Apr 25, 2016 at 2:14 PM, Yoshinori Sato
> <ysato@users.sourceforge.jp> wrote:
> > The terminal condition in the area where a PCI device is scanned is wrong,
> > and 1f.7 isn't scanned.
> >
> > Changes v2:
> > - update commit message.
>
> Please hide this "changes v2" from the commit message.
>
> Also nits: please remove the ending period in the commit title ..
OK.
Thanks comment.
> >
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> > ---
> > drivers/pci/pci-uclass.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
> > index c7fbf7b..32590ce 100644
> > --- a/drivers/pci/pci-uclass.c
> > +++ b/drivers/pci/pci-uclass.c
> > @@ -682,7 +682,7 @@ int pci_bind_bus_devices(struct udevice *bus)
> > found_multi = false;
> > end = PCI_BDF(bus->seq, PCI_MAX_PCI_DEVICES - 1,
> > PCI_MAX_PCI_FUNCTIONS - 1);
> > - for (bdf = PCI_BDF(bus->seq, 0, 0); bdf < end;
> > + for (bdf = PCI_BDF(bus->seq, 0, 0); bdf <= end;
> > bdf += PCI_BDF(0, 0, 1)) {
> > struct pci_child_platdata *pplat;
> > struct udevice *dev;
> > --
>
> Regards,
> Bin
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
next prev parent reply other threads:[~2016-04-25 6:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 8:02 [U-Boot] [PATCH] pci: Device scanning range fix Yoshinori Sato
2016-04-23 15:12 ` Simon Glass
2016-04-25 6:14 ` [U-Boot] [PATCH v2] " Yoshinori Sato
2016-04-25 6:27 ` Bin Meng
2016-04-25 6:38 ` Yoshinori Sato [this message]
2016-04-25 6:41 ` [U-Boot] [PATCH v3] " Yoshinori Sato
2016-04-25 7:07 ` Bin Meng
2016-04-26 0:17 ` [U-Boot] [U-Boot,v3] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpnmp503.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox